1
0
mirror of https://github.com/golang/go synced 2024-10-05 20:41:22 -06:00
go/src/cmd/asm/internal/asm
Rob Pike 49580db149 asm: give error message for unadorned symbol reference
On amd64, the program

TEXT    foo0(SB),7,$-8
    ADDQ R520, R1
    RET

used to trigger this error because R520 was being passed through to obj:

asm: doasm: notfound ft=23 tt=23 00000 (x.s:2)	ADDQ	0, 0 23 23

Now it gets this one, as it is indeed a parse error:

x.s:2: illegal addressing mode for symbol R520

This couldn't be fixed until #12632 had been fixed for arm64.

Fixes #12470.

Change-Id: I19830c4ae9337887b93f85d9a239e2b89dbb2219
Reviewed-on: https://go-review.googlesource.com/14691
Reviewed-by: Aram Hăvărneanu <aram@mgk.ro>
2015-09-18 18:08:52 +00:00
..
testdata cmd/asm/internal/asm: add aliases for ARM64 condition codes 2015-09-17 15:11:08 +00:00
asm.go asm: more early returns on errors 2015-09-15 16:10:05 +00:00
endtoend_test.go cmd/internal/obj: clean up Biobuf 2015-05-01 18:37:04 +00:00
expr_test.go cmd/asm: add tests for erroneous expressions 2015-06-26 23:33:39 +00:00
operand_test.go cmd/asm: fix some fuzz bugs 2015-09-11 00:52:21 +00:00
parse.go asm: give error message for unadorned symbol reference 2015-09-18 18:08:52 +00:00
pseudo_test.go cmd/asm: fix some fuzz bugs 2015-09-11 00:52:21 +00:00