mirror of
https://github.com/golang/go
synced 2024-11-15 03:00:36 -07:00
e99e9a6e01
The compiler renames anonymous and blank result parameters to ~rN or ~bN, but the current semantics for computing N are rather annoying and difficult to reproduce cleanly. They also lead to difficult to read escape analysis results in tests. This CL changes N to always be calculated as the parameter's index within the function's result parameter tuple. E.g., if a function has a single result, it will now always be named "~r0". The normative change to this CL is fairly simple, but it requires updating a lot of test expectations. Change-Id: I58a3c94de00cb822cb94efe52d115531193c993c Reviewed-on: https://go-review.googlesource.com/c/go/+/323010 Trust: Matthew Dempsky <mdempsky@google.com> Trust: Dan Scales <danscales@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dan Scales <danscales@google.com>
175 lines
3.8 KiB
Go
175 lines
3.8 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis through ... parameters.
|
|
|
|
package foo
|
|
|
|
func FooN(vals ...*int) (s int) { // ERROR "vals does not escape"
|
|
for _, v := range vals {
|
|
s += *v
|
|
}
|
|
return s
|
|
}
|
|
|
|
// Append forces heap allocation and copies entries in vals to heap, therefore they escape to heap.
|
|
func FooNx(x *int, vals ...*int) (s int) { // ERROR "leaking param: x" "leaking param content: vals"
|
|
vals = append(vals, x)
|
|
return FooN(vals...)
|
|
}
|
|
|
|
var sink []*int
|
|
|
|
func FooNy(x *int, vals ...*int) (s int) { // ERROR "leaking param: x" "leaking param: vals"
|
|
vals = append(vals, x)
|
|
sink = vals
|
|
return FooN(vals...)
|
|
}
|
|
|
|
func FooNz(vals ...*int) (s int) { // ERROR "leaking param: vals"
|
|
sink = vals
|
|
return FooN(vals...)
|
|
}
|
|
|
|
func TFooN() {
|
|
for i := 0; i < 1000; i++ {
|
|
var i, j int
|
|
FooN(&i, &j) // ERROR "... argument does not escape"
|
|
}
|
|
}
|
|
|
|
func TFooNx() {
|
|
for i := 0; i < 1000; i++ {
|
|
var i, j, k int // ERROR "moved to heap: i" "moved to heap: j" "moved to heap: k"
|
|
FooNx(&k, &i, &j) // ERROR "... argument does not escape"
|
|
}
|
|
}
|
|
|
|
func TFooNy() {
|
|
for i := 0; i < 1000; i++ {
|
|
var i, j, k int // ERROR "moved to heap: i" "moved to heap: j" "moved to heap: k"
|
|
FooNy(&k, &i, &j) // ERROR "... argument escapes to heap"
|
|
}
|
|
}
|
|
|
|
func TFooNz() {
|
|
for i := 0; i < 1000; i++ {
|
|
var i, j int // ERROR "moved to heap: i" "moved to heap: j"
|
|
FooNz(&i, &j) // ERROR "... argument escapes to heap"
|
|
}
|
|
}
|
|
|
|
var isink *int32
|
|
|
|
func FooI(args ...interface{}) { // ERROR "leaking param content: args"
|
|
for i := 0; i < len(args); i++ {
|
|
switch x := args[i].(type) {
|
|
case nil:
|
|
println("is nil")
|
|
case int32:
|
|
println("is int32")
|
|
case *int32:
|
|
println("is *int32")
|
|
isink = x
|
|
case string:
|
|
println("is string")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TFooI() {
|
|
a := int32(1) // ERROR "moved to heap: a"
|
|
b := "cat"
|
|
c := &a
|
|
FooI(a, b, c) // ERROR "a escapes to heap" "b escapes to heap" "... argument does not escape"
|
|
}
|
|
|
|
func FooJ(args ...interface{}) *int32 { // ERROR "leaking param: args to result ~r0 level=1"
|
|
for i := 0; i < len(args); i++ {
|
|
switch x := args[i].(type) {
|
|
case nil:
|
|
println("is nil")
|
|
case int32:
|
|
println("is int32")
|
|
case *int32:
|
|
println("is *int32")
|
|
return x
|
|
case string:
|
|
println("is string")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func TFooJ1() {
|
|
a := int32(1)
|
|
b := "cat"
|
|
c := &a
|
|
FooJ(a, b, c) // ERROR "a does not escape" "b does not escape" "... argument does not escape"
|
|
}
|
|
|
|
func TFooJ2() {
|
|
a := int32(1) // ERROR "moved to heap: a"
|
|
b := "cat"
|
|
c := &a
|
|
isink = FooJ(a, b, c) // ERROR "a escapes to heap" "b escapes to heap" "... argument does not escape"
|
|
}
|
|
|
|
type fakeSlice struct {
|
|
l int
|
|
a *[4]interface{}
|
|
}
|
|
|
|
func FooK(args fakeSlice) *int32 { // ERROR "leaking param: args to result ~r0 level=1"
|
|
for i := 0; i < args.l; i++ {
|
|
switch x := (*args.a)[i].(type) {
|
|
case nil:
|
|
println("is nil")
|
|
case int32:
|
|
println("is int32")
|
|
case *int32:
|
|
println("is *int32")
|
|
return x
|
|
case string:
|
|
println("is string")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func TFooK2() {
|
|
a := int32(1) // ERROR "moved to heap: a"
|
|
b := "cat"
|
|
c := &a
|
|
fs := fakeSlice{3, &[4]interface{}{a, b, c, nil}} // ERROR "a escapes to heap" "b escapes to heap" "&\[4\]interface {}{...} does not escape"
|
|
isink = FooK(fs)
|
|
}
|
|
|
|
func FooL(args []interface{}) *int32 { // ERROR "leaking param: args to result ~r0 level=1"
|
|
for i := 0; i < len(args); i++ {
|
|
switch x := args[i].(type) {
|
|
case nil:
|
|
println("is nil")
|
|
case int32:
|
|
println("is int32")
|
|
case *int32:
|
|
println("is *int32")
|
|
return x
|
|
case string:
|
|
println("is string")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func TFooL2() {
|
|
a := int32(1) // ERROR "moved to heap: a"
|
|
b := "cat"
|
|
c := &a
|
|
s := []interface{}{a, b, c} // ERROR "a escapes to heap" "b escapes to heap" "\[\]interface {}{...} does not escape"
|
|
isink = FooL(s)
|
|
}
|