1
0
mirror of https://github.com/golang/go synced 2024-09-30 16:08:36 -06:00
go/cmd
Rob Pike 0c09ff325a cmd/cover: preserve //go: comments
Cover deleted all comments because they can break the simple way that
counters are injected into the rewritten source. But //go: comments have
semantic value, and for instance go test -cover runtime fails during
compilation because of their absence from the annotated source.

We can keep the //go: comments because they are at the beginning of
the line and are not affected by our counter injection.

Fixes #10270.

After this CL, go test -cover runtime works.
A testing strategy that does not involve a golden file would be welcome
but I can't think of one.

Change-Id: I73f7b7a36383a8efed8e33fa2414cd0eac7d015a
Reviewed-on: https://go-review.googlesource.com/8173
Reviewed-by: Robert Griesemer <gri@golang.org>
2015-03-27 21:01:39 +00:00
..
benchcmp benchmark/parser, cmd/benchcmp: improve names of exported identifiers 2015-01-15 01:28:17 +00:00
callgraph go/loader: rename SourceImports flag to ImportFromBinary and invert sense 2015-02-23 23:01:10 +00:00
cover cmd/cover: preserve //go: comments 2015-03-27 21:01:39 +00:00
digraph tools: add import comments. 2014-12-09 22:42:16 +00:00
eg cmd/eg: improve usage and help messages 2015-03-17 16:03:11 +00:00
godex tools: add import comments. 2014-12-09 22:42:16 +00:00
godoc cmd/godoc: skip tests on arm platforms 2015-03-16 02:06:44 +00:00
goimports goimports: create a var to permit custom implementations of flag parsing and 2015-03-27 18:14:11 +00:00
gomvpkg cmd/mvpkg: a package moving tool 2015-01-14 17:37:29 +00:00
gorename cmd/gorename: make Usage documentation sensible in godoc 2014-12-30 16:36:43 +00:00
gotype tools: add import comments. 2014-12-09 22:42:16 +00:00
html2article all: address vet reports 2014-12-29 06:08:34 +00:00
oracle oracle: when 'implements' is invoked on a method, show related methods, not types. 2015-02-25 22:38:52 +00:00
present cmd/present: do not show help text on localhost 2015-02-23 10:31:29 +00:00
ssadump go/loader: rename SourceImports flag to ImportFromBinary and invert sense 2015-02-23 23:01:10 +00:00
stringer cmd/stringer: remove os.Exit call from Usage func 2015-03-09 01:18:24 +00:00
tipgodoc cmd/tipgodoc: increase startup 'health check' deadline 2015-03-10 03:04:16 +00:00
vet vet: fix documentation about recursive scanning 2015-03-17 00:40:15 +00:00