1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:44:42 -07:00
go/internal/lsp/source
Muir Manders 0bc66720f3 internal/lsp/source: limit to 5 unimported package name candidates
Currently we show up to ~100 unimported package names matching the
completion prefix. This isn't useful since, assuming the user even
wants an unimported package, they will just type more to narrow it
down rather than scroll through 100 options. Having so many candidates
also slows things down due to per-candidate overhead in gopls and in
the LSP client. Now we instead limit to 5 unimported package names.

Unimported package members, on the other hand, make sense to list
many. The user may want to scroll through because they don't remember
the name of what they are looking for. I left the max value at 100.

Change-Id: I00e11fa0420758f8db6c7049f80fa156773a5ee6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/218879
Run-TryBot: Muir Manders <muir@mnd.rs>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-02-11 00:32:09 +00:00
..
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
completion_builtin.go internal/lsp/source: improve completion for "make()" args 2020-02-02 23:20:50 +00:00
completion_format.go internal/lsp: return context cancellation from LookupBuiltin 2020-01-27 18:55:29 +00:00
completion_keywords.go internal/lsp: sort by label after score 2019-12-30 21:11:21 +00:00
completion_labels.go internal/lsp: sort by label after score 2019-12-30 21:11:21 +00:00
completion_literal.go internal/lsp: fix crash completing recursive pointer types 2020-02-07 22:44:06 +00:00
completion_snippet.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion.go internal/lsp/source: limit to 5 unimported package name candidates 2020-02-11 00:32:09 +00:00
deep_completion.go internal/lsp/source: improve completion involving multiple return values 2020-02-06 05:07:08 +00:00
diagnostics.go internal/lsp: don't use overlays from the session in the snapshot 2020-02-07 19:21:16 +00:00
errors.go internal/lsp: remove the checkErrors command in internal/lsp/source 2020-01-24 21:19:55 +00:00
folding_range.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
format_test.go internal/lsp/source: trim file very carefully 2020-01-17 20:34:13 +00:00
format.go internal/lsp/source: trim file very carefully 2020-01-17 20:34:13 +00:00
highlight.go internal/lsp: add highlighting for import statement 2020-01-17 17:07:20 +00:00
hover.go internal/lsp/source: export FindFileInpackage 2020-02-07 21:55:11 +00:00
identifier.go internal/lsp: don't show links in hover for test functions 2020-02-03 21:56:10 +00:00
implementation.go internal/lsp: refactor find-references and rename 2020-01-16 06:24:15 +00:00
options.go internal/lsp/source: default to full documentation for hover 2020-02-07 21:32:44 +00:00
references.go internal/lsp: don't return references for builtins 2020-02-06 19:49:06 +00:00
rename_check.go internal/lsp: improve literal func completion candidates 2019-11-07 21:18:00 +00:00
rename.go internal/lsp: permit renaming symbols declared in other packages 2020-01-27 18:56:10 +00:00
signature_help.go internal/lsp: remove unnecessary source.SignatureInformation type 2020-02-06 19:05:38 +00:00
source_test.go internal/lsp: export DiffSymbols to avoid duplication 2020-02-06 20:09:13 +00:00
symbols.go internal/lsp/source: eliminate setKind 2020-02-07 19:42:34 +00:00
util.go internal/lsp/source: export FindFileInpackage 2020-02-07 21:55:11 +00:00
view.go internal/lsp/cache: hardcode parse modes instead of guessing them 2020-02-07 20:00:15 +00:00
workspace_symbol.go internal/lsp: add support for workspace symbol 2020-02-05 19:03:17 +00:00