Rebecca Stambler d7101b74a4 internal/lsp: set version correctly after textDocument/didOpen ... The early return logic for didOpen events in (*snapshot).invalidateContent was preventing the creation of a new snapshot, which was in turn stopping the versions from being updated. This exposed a fundamental issue in the way we were calculating workspace diagnostics. Since we weren't waiting for diagnostics to be completed for an entire snapshot before replying that the server had been initialized, snapshots were being cloned without any type information. For quickfix code actions, we assume that we have all information cached (since we need to have sent the diagnostics that the quickfix is mapped to), so we were not finding the cached analysis results. To handle this in the short-term, we key analyses by their names, and then regenerate results as-needed for code actions. This is technically more correct than simply assuming that we have the analyses cached. In a follow-up CL, I will send a follow-up that will make sure that snapshots "wait" on each other to be fully constructed before being cloned. Change-Id: Ie89fcdb438b6b8b675f87335561bf47b768641ac Reviewed-on: https://go-review.googlesource.com/c/tools/+/208265 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com>		2019-11-25 19:35:51 +00:00
..
analysis.go	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
diff_test.go	gopls: use go-diff for edit generation	2019-10-10 20:18:25 +00:00
diff.go	gopls: use go-diff for edit generation	2019-10-10 20:18:25 +00:00
hooks.go	internal/lsp: use options hooks to install diff driver	2019-10-11 16:38:31 +00:00