mirror of
https://github.com/golang/go
synced 2024-11-06 00:26:11 -07:00
606019cb4b
This information is redundant with the position information already
provided. Also, no other -m diagnostics print out function name.
While here, report parameter leak diagnostics against the parameter
declaration position rather than the function, and use Warnl for
"moved to heap" messages.
Test cases updated programmatically by removing the first word from
every "no match for" error emitted by run.go:
go run run.go |& \
sed -E -n 's/^(.*):(.*): no match for `([^ ]* (.*))` in:$/\1!\2!\3!\4/p' | \
while IFS='!' read -r fn line before after; do
before=$(echo "$before" | sed 's/[.[\*^$()+?{|]/\\&/g')
after=$(echo "$after" | sed -E 's/(\&|\\)/\\&/g')
fn=$(find . -name "${fn}" | head -1)
sed -i -E -e "${line}s/\"${before}\"/\"${after}\"/" "${fn}"
done
Passes toolstash-check.
Change-Id: I6e02486b1409e4a8dbb2b9b816d22095835426b5
Reviewed-on: https://go-review.googlesource.com/c/go/+/195040
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
89 lines
1.5 KiB
Go
89 lines
1.5 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Tests escape analysis for range of arrays.
|
|
// Compiles but need not run. Inlining is disabled.
|
|
|
|
package main
|
|
|
|
type A struct {
|
|
b [3]uint64
|
|
}
|
|
|
|
type B struct {
|
|
b [3]*uint64
|
|
}
|
|
|
|
func f(a A) int {
|
|
for i, x := range &a.b {
|
|
if x != 0 {
|
|
return 64*i + int(x)
|
|
}
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func g(a *A) int { // ERROR "a does not escape"
|
|
for i, x := range &a.b {
|
|
if x != 0 {
|
|
return 64*i + int(x)
|
|
}
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func h(a *B) *uint64 { // ERROR "leaking param: a to result ~r1 level=1"
|
|
for i, x := range &a.b {
|
|
if i == 0 {
|
|
return x
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func h2(a *B) *uint64 { // ERROR "leaking param: a to result ~r1 level=1"
|
|
p := &a.b
|
|
for i, x := range p {
|
|
if i == 0 {
|
|
return x
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Seems like below should be level=1, not 0.
|
|
func k(a B) *uint64 { // ERROR "leaking param: a to result ~r1 level=0"
|
|
for i, x := range &a.b {
|
|
if i == 0 {
|
|
return x
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
var sink *uint64
|
|
|
|
func main() {
|
|
var a1, a2 A
|
|
var b1, b2, b3, b4 B
|
|
var x1, x2, x3, x4 uint64 // ERROR "moved to heap: x1" "moved to heap: x3"
|
|
b1.b[0] = &x1
|
|
b2.b[0] = &x2
|
|
b3.b[0] = &x3
|
|
b4.b[0] = &x4
|
|
f(a1)
|
|
g(&a2)
|
|
sink = h(&b1)
|
|
h(&b2)
|
|
sink = h2(&b1)
|
|
h2(&b4)
|
|
x1 = 17
|
|
println("*sink=", *sink) // Verify that sink addresses x1
|
|
x3 = 42
|
|
sink = k(b3)
|
|
println("*sink=", *sink) // Verify that sink addresses x3
|
|
}
|