1
0
mirror of https://github.com/golang/go synced 2024-11-18 19:34:41 -07:00
go/internal/lsp/cache
Rob Findley 8ddc06776e internal/lsp/source: don't link to packages matching GOPRIVATE in hover
Currently, our hover text by default links point to public documentation
sites (e.g. pkg.go.dev). This doesn't make sense for private repos, so
hide the hovertext link when the import path matches GOPRIVATE.

Implementing this was a little messy. To be optimal I had to thread
the value of goprivate through cache.view, and to be correct I had to
duplicate some code from cmd/go internal.

Regtest will follow after https://golang.org/cl/232983 is submitted.

Updates golang/go#36998

Change-Id: I1e556471bf919fea30132d9642426a08fdb7f434
Reviewed-on: https://go-review.googlesource.com/c/tools/+/233524
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-05-15 19:36:02 +00:00
..
analysis.go internal/lsp: fix caching issue with duplicate handles 2020-05-07 19:23:25 +00:00
cache.go internal/lsp: move the debug.Instance onto the Context 2020-03-03 22:54:53 +00:00
check.go internal/lsp/cache: pass UsesCgo to go/types 2020-05-15 01:05:26 +00:00
debug.go internal/lsp/lsprpc: add a handshake between forwarder and remote 2020-02-24 22:51:04 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
external.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
load.go internal/lsp: make sure diagnostics only refer to existing files 2020-05-07 02:01:22 +00:00
mod.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp/cache: avoid string(int) conversion 2020-05-07 05:02:07 +00:00
pkg.go internal/lsp/cache: hide type errors if we fix up the AST 2020-04-10 04:07:51 +00:00
session.go internal/lsp/cache: add an UnsavedFiles method to Session 2020-05-07 17:51:45 +00:00
snapshot.go internal/lsp: use TypecheckCgo when possible 2020-05-13 17:53:51 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp/source: don't link to packages matching GOPRIVATE in hover 2020-05-15 19:36:02 +00:00