1
0
mirror of https://github.com/golang/go synced 2024-11-23 13:00:07 -07:00
The Go programming language
Go to file
Russ Cox 0a8a719ded cmd/5g, cmd/6g, cmd/8g: preserve wide values in large functions
In large functions with many variables, the register optimizer
may give up and choose not to track certain variables at all.
In this case, the "nextinnode" information linking together
all the words from a given variable will be incomplete, and
the result may be that only some of a multiword value is
preserved across a call. That confuses the garbage collector,
so don't do that. Instead, mark those variables as having
their address taken, so that they will be preserved at all
calls. It's overkill, but correct.

Tested by hand using the 6g -S output to see that it does fix
the buggy generated code leading to the issue 7726 failure.

There is no automated test because I managed to break the
compiler while writing a test (see issue 7727). I will check
in a test along with the fix to issue 7727.

Fixes #7726.

LGTM=khr
R=khr, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/85200043
2014-04-16 13:59:42 -04:00
api api: update next.txt 2014-04-01 13:14:45 -04:00
doc doc/go1.3.html: document the state of FreeBSD 2014-04-16 10:40:41 -07:00
include liblink: fix incorrect hash collision in lookup 2014-04-16 11:53:14 -04:00
lib codereview: remove unused upload_options.revision 2014-02-24 10:11:37 -05:00
misc misc/emacs: ignore backquote in comment or string 2014-04-09 12:28:27 -04:00
src cmd/5g, cmd/6g, cmd/8g: preserve wide values in large functions 2014-04-16 13:59:42 -04:00
test undo CL 66510044 / 6c0339d94123 2014-04-14 09:48:11 -04:00
.hgignore lib9: enable on Plan 9 2014-02-13 20:06:41 +01:00
.hgtags tag go1.2.1 2014-03-03 13:22:13 +11:00
AUTHORS A+C: Billie Harold Cleek (individual CLA) 2014-04-16 13:39:51 +10:00
CONTRIBUTORS A+C: Billie Harold Cleek (individual CLA) 2014-04-16 13:39:51 +10:00
favicon.ico
LICENSE
PATENTS
README README: Fix installation instructions 2013-11-20 13:47:37 -08:00
robots.txt

This is the source code repository for the Go programming language.  

For documentation about how to install and use Go,
visit http://golang.org/ or load doc/install-source.html
in your web browser.

After installing Go, you can view a nicely formatted
doc/install-source.html by running godoc --http=:6060
and then visiting http://localhost:6060/doc/install/source.

Unless otherwise noted, the Go source files are distributed
under the BSD-style license found in the LICENSE file.

--

Binary Distribution Notes

If you have just untarred a binary Go distribution, you need to set
the environment variable $GOROOT to the full path of the go
directory (the one containing this README).  You can omit the
variable if you unpack it into /usr/local/go, or if you rebuild
from sources by running all.bash (see doc/install.html).
You should also add the Go binary directory $GOROOT/bin
to your shell's path.

For example, if you extracted the tar file into $HOME/go, you might
put the following in your .profile:

    export GOROOT=$HOME/go
    export PATH=$PATH:$GOROOT/bin

See doc/install.html for more details.