1
0
mirror of https://github.com/golang/go synced 2024-10-01 07:28:35 -06:00
go/internal/lsp/references.go
Rebecca Stambler 700ee2612c internal/lsp: propagate errors from find references
We were ignoring errors in a few cases and returning incorrect errors in
the case of the command-line interface (no identifier found when there
were just no references). I think it is better for references to return
an error than incomplete results.

Change-Id: Id90bca58ebdd9f6a910853cb4ac5b6ab6bec57f8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/213817
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-01-09 21:23:09 +00:00

90 lines
2.1 KiB
Go

// Copyright 2019 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package lsp
import (
"context"
"golang.org/x/tools/internal/lsp/protocol"
"golang.org/x/tools/internal/lsp/source"
"golang.org/x/tools/internal/span"
)
func (s *Server) references(ctx context.Context, params *protocol.ReferenceParams) ([]protocol.Location, error) {
uri := span.NewURI(params.TextDocument.URI)
view, err := s.session.ViewOf(uri)
if err != nil {
return nil, err
}
snapshot := view.Snapshot()
fh, err := snapshot.GetFile(ctx, uri)
if err != nil {
return nil, err
}
// Find all references to the identifier at the position.
if fh.Identity().Kind != source.Go {
return nil, nil
}
phs, err := snapshot.PackageHandles(ctx, fh)
if err != nil {
return nil, nil
}
// Get the location of each reference to return as the result.
var (
locations []protocol.Location
seen = make(map[span.Span]bool)
lastIdent *source.IdentifierInfo
)
for _, ph := range phs {
ident, err := source.Identifier(ctx, snapshot, fh, params.Position, source.SpecificPackageHandle(ph.ID()))
if err != nil {
return nil, err
}
lastIdent = ident
references, err := ident.References(ctx)
if err != nil {
return nil, err
}
for _, ref := range references {
refSpan, err := ref.Span()
if err != nil {
return nil, err
}
if seen[refSpan] {
continue // already added this location
}
seen[refSpan] = true
refRange, err := ref.Range()
if err != nil {
return nil, err
}
locations = append(locations, protocol.Location{
URI: protocol.NewURI(ref.URI()),
Range: refRange,
})
}
}
// Only add the identifier's declaration if the client requests it.
if params.Context.IncludeDeclaration && lastIdent != nil {
rng, err := lastIdent.Declaration.Range()
if err != nil {
return nil, err
}
locations = append([]protocol.Location{
{
URI: protocol.NewURI(lastIdent.Declaration.URI()),
Range: rng,
},
}, locations...)
}
return locations, nil
}