mirror of
https://github.com/golang/go
synced 2024-11-23 17:40:03 -07:00
d31f85009c
The nounified frontend currently tries to construct dictionaries that correspond to invalid instantiations (i.e., instantiations T[X] where X does not satisfy the constraints specified on T's type parameter). As a consequence, we may fail to find method expressions needed by the dictionary. The real fix for this is to avoid creating those dictionaries in the first place, because they should never actually be needed at runtime. But that seems scary for a backport: we've repeatedly attempted to backport generics fixes, which have fixed one issue but introduced another. This CL is a minimally invasive solution to #54225, which avoids the ICE by instead skipping emitting the invalid dictionary. If the dictionary ends up not being needed (which I believe will always be the case), then the linker's reachability analysis will simply ignore its absence. Or worst case, if the dictionary *is* reachable somehow, we've simply turned an ICE into a link-time missing symbol failure. That's not great for user experience, but it seems like a small trade off to avoid risking breaking any other currently working code. Updates #54225. Change-Id: Ic379696079f4729b1dd6a66994a58cca50281a84 Reviewed-on: https://go-review.googlesource.com/c/go/+/429655 Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
34 lines
532 B
Go
34 lines
532 B
Go
// run
|
|
|
|
// Copyright 2022 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
func main() {
|
|
One[TextValue]()
|
|
}
|
|
|
|
func One[V Value]() { Two[Node[V]]() }
|
|
|
|
func Two[V interface{ contentLen() int }]() {
|
|
var v V
|
|
v.contentLen()
|
|
}
|
|
|
|
type Value interface {
|
|
Len() int
|
|
}
|
|
|
|
type Node[V Value] struct{}
|
|
|
|
func (Node[V]) contentLen() int {
|
|
var value V
|
|
return value.Len()
|
|
}
|
|
|
|
type TextValue struct{}
|
|
|
|
func (TextValue) Len() int { return 0 }
|