mirror of
https://github.com/golang/go
synced 2024-11-26 07:38:00 -07:00
f1778c28a9
Change the run.go driver to recognize the "gc" build tag. Change existing tests to use the "gc" build tag if they use some feature that seems specific to the gc compiler, such as passing specific options to or expecting specific behavior from "go tool compile". Change tests to use the "!gccgo" build tag if they use "go build" or "go run", as while those might work with compilers other than gc, they won't work with the way that gccgo runs its testsuite (which happens independently of the go command). For #43252 Change-Id: I666e04b6d7255a77dfc256ee304094e3a6bb15ad Reviewed-on: https://go-review.googlesource.com/c/go/+/279052 Trust: Ian Lance Taylor <iant@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
65 lines
1.2 KiB
Go
65 lines
1.2 KiB
Go
// +build !nacl,!js,gc
|
|
// run
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Issue 11771: Magic comments should ignore carriage returns.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"log"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
)
|
|
|
|
func main() {
|
|
if runtime.Compiler != "gc" {
|
|
return
|
|
}
|
|
|
|
dir, err := ioutil.TempDir("", "go-issue11771")
|
|
if err != nil {
|
|
log.Fatalf("creating temp dir: %v\n", err)
|
|
}
|
|
defer os.RemoveAll(dir)
|
|
|
|
// The go:nowritebarrier magic comment is only permitted in
|
|
// the runtime package. So we confirm that the compilation
|
|
// fails.
|
|
|
|
var buf bytes.Buffer
|
|
fmt.Fprintln(&buf, `
|
|
package main
|
|
|
|
func main() {
|
|
}
|
|
`)
|
|
fmt.Fprintln(&buf, "//go:nowritebarrier\r")
|
|
fmt.Fprintln(&buf, `
|
|
func x() {
|
|
}
|
|
`)
|
|
|
|
if err := ioutil.WriteFile(filepath.Join(dir, "x.go"), buf.Bytes(), 0666); err != nil {
|
|
log.Fatal(err)
|
|
}
|
|
|
|
cmd := exec.Command("go", "tool", "compile", "x.go")
|
|
cmd.Dir = dir
|
|
output, err := cmd.CombinedOutput()
|
|
if err == nil {
|
|
log.Fatal("compile succeeded unexpectedly")
|
|
}
|
|
if !bytes.Contains(output, []byte("only allowed in runtime")) {
|
|
log.Fatalf("wrong error message from compiler; got:\n%s\n", output)
|
|
}
|
|
}
|