mirror of
https://github.com/golang/go
synced 2024-11-18 14:24:44 -07:00
e78e04ce39
DWARF generation uses variable source positions (file/line/col) as a way to uniquely identify locals and parameters, as part of the process of matching up post-optimization variables with the corresponding pre-optimization versions (since the DWARF needs to be in terms of the original source constructs). This strategy can run into problems when compiling obfuscated or machine-generated code, where you can in some circumstances wind up with two local variables that appear to have the same name, file, line, and column. This patch changes DWARF generation to skip over such duplicates as opposed to issuing a fatal error (if an obfuscation tool is in use, it is unlikely that a human being will be able to make much sense of DWARF info in any case). Fixes #44378. Change-Id: I198022d184701aa9ec3dce42c005d29b72d2e321 Reviewed-on: https://go-review.googlesource.com/c/go/+/294289 TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Jeremy Faller <jeremy@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Trust: Than McIntosh <thanm@google.com> Run-TryBot: Than McIntosh <thanm@google.com>
41 lines
1.3 KiB
Go
41 lines
1.3 KiB
Go
// compile
|
|
|
|
// Copyright 2021 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// This test case caused a panic in the compiler's DWARF gen code.
|
|
|
|
// Note to future maintainers of this code:
|
|
//
|
|
// ** Do NOT run gofmt when editing this file **
|
|
//
|
|
// In order for the buggy behavior to be triggered in the compiler,
|
|
// we need to have a the function of interest all on one gigantic line.
|
|
|
|
package a
|
|
|
|
type O interface{}
|
|
type IO int
|
|
type OS int
|
|
|
|
type A struct {
|
|
x int
|
|
}
|
|
|
|
// original versions of the two function
|
|
func (p *A) UO(o O) {
|
|
p.r(o, o)
|
|
}
|
|
func (p *A) r(o1, o2 O) {
|
|
switch x := o1.(type) {
|
|
case *IO:
|
|
p.x = int(*x)
|
|
case *OS:
|
|
p.x = int(*x + 2)
|
|
}
|
|
}
|
|
|
|
// see note above about the importance of all this code winding up on one line.
|
|
var myverylongname0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 int ; func (p *A) UO2(o O) { p.r2(o, o); }; func (p *A) r2(o1, o2 O) { switch x := o1.(type) { case *IO: p.x = int(*x); case *OS: p.x = int(*x + 2); } }
|