071770b846
Currently, we have several tests disabled if GO_GCFLAGS is non-empty. Long ago, this was critical because many of these tests use "go install" with no -gcflags and would thus overwrite std packages in GOROOT built with -gcflags=$GO_GCFLAGS. Now these packages all live in the build cache, so this is no longer a concern. The other reason for this (the reason given in the code comment), is that these tests will rebuild significant portions of std without flags. While this is still theoretically true, there are many tests that run "go build" with no -gcflags, so these tests don't contribute much overall. Empirically, on my linux/amd64 host, running these tests at all grows the Go build cache by 14%, from 1.899 GB to 2.165 GB. When building with GO_GCFLAGS="-N -l" (the only use case on the builders), enabling them grows the Go build cache by 18%, from 1.424 GB to 1.684 GB. This is only a 4 percentage point difference, and still results in a build cache that's smaller than the default build Given all this, there's little reason to carry the complexity of disabling these tests when GO_GCFLAGS != "". Removing this condition is a step toward running these as regular cmd tests. Change-Id: I2c41be721927c40a742e01476cd9a0f7650d38e6 Reviewed-on: https://go-review.googlesource.com/c/go/+/495917 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Austin Clements <austin@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.