Dan Scales c8d6ee12d5 cmd/compile: match Go 1.17 compiler error messages more closely ... When being used by the compiler, fix up types2 error messages to be more like Go 1.17 compiler errors. In particular: - add information about which method is missing when a type is not assignable/convertible/etc. to an interface. - add information about any existing method which has the same name, but wrong type. - add extra hint in the case that the source or destination type is a pointer to an interface, rather than an interface. - add extra hint "need type assertion" in the case that the source is an interface that is implemented by the destination. - the following change in the CL stack also adds information about any existing method with a different name that only differs in case. Include much of the new logic in a new common function (*Checker).missingMethodReason(). types2 still adds a little more information in some cases then the Go 1.17 compiler. For example, it typically says "(value of type T)", rather than "(type T)", where "value" could also be "constant", "variable", etc. I kept the types2 error messages almost all the same when types2 is not used by the compiler. The only change (to reduce amount of compatibility code) was to change "M method" phrasing in one case to "method M" phrasing in one error message (which is the phrasing it uses in all other cases). That is the reason that there are a few small changes in types2/testdata/check/*.src. Added new test test/fixedbugs/issue48471.go to test that the added information is appearing correctly. Also adjusted the pattern matching in a bunch of other test/fixedbugs/*.go, now that types2 is producing error messages closer to Go 1.17. Was able to remove a couple test files from the types2 exception list in run.go. Updated #48471 Change-Id: I8af1eae6eb8a5541d8ea20b66f494e2e795e1956 Reviewed-on: https://go-review.googlesource.com/c/go/+/363436 Trust: Dan Scales <danscales@google.com> Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>		2021-11-12 23:07:01 +00:00
..
embed1.dir
embed3.dir
private.dir
recursive1.dir
assertinline.go
bigdata.go
convert1.go
convert2.go
convert.go
embed1.go
embed2.go	[dev.typeparams] test: adjust more test cases to match compiler -G output	2020-12-03 17:55:56 +00:00
embed3.go
embed.go
explicit.go	cmd/compile: match Go 1.17 compiler error messages more closely	2021-11-12 23:07:01 +00:00
fail.go
fake.go
noeq.go
pointer.go	cmd/compile/internal/types2: avoid "declared but not used" errors for invalid code	2021-09-23 19:41:45 +00:00
private.go
receiver1.go	[dev.typeparams] test: adjust more test cases to match compiler -G output	2020-12-03 17:55:56 +00:00
receiver.go
recursive1.go
recursive.go
returntype.go
struct.go