mirror of
https://github.com/golang/go
synced 2024-11-23 06:10:05 -07:00
978af9c2db
Tuple ops are weird. They are essentially a pair of ops, one which consumes a mem and one which generates a mem (the Select1). The schedule pass didn't handle these quite right. Fix the scheduler to include both parts of the paired op in the store chain. That makes sure that loads are correctly ordered with respect to the first of the pair. Add a check for the ssacheck builder, that there is only one live store at a time. I thought we already had such a check, but apparently not... Fixes #20335 Change-Id: I59eb3446a329100af38d22820b1ca2190ca46a78 Reviewed-on: https://go-review.googlesource.com/43294 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
20 lines
467 B
Go
20 lines
467 B
Go
// compile
|
|
|
|
// Copyright 2017 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Issue 20335: don't reorder loads with stores.
|
|
// This test should fail on the ssacheck builder
|
|
// without the fix in the CL that added this file.
|
|
// TODO: check the generated assembly?
|
|
|
|
package a
|
|
|
|
import "sync/atomic"
|
|
|
|
func f(p, q *int32) bool {
|
|
x := *q
|
|
return atomic.AddInt32(p, 1) == x
|
|
}
|