Heschi Kreinick 058404a2dd internal/lsp/source: fix cloneExpr for SelectorExprs ... A missing return in the SelectorExpr case meant that cloneExpr would return the original node, resulting in AST corruption when the caller modified it. It might be nice to panic in the default case to prevent this from happening again, but for now let's just fix it. Fixes golang/go#38927. Change-Id: Ib99f2dadecf52007ac9319c480fbd2d636a0474a Reviewed-on: https://go-review.googlesource.com/c/tools/+/232990 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2020-05-08 22:40:54 +00:00
..
code_lens.go	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_format.go	internal/lsp: handle different package names in signature help	2020-04-27 20:59:12 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer completion "if err != nil { return err }"	2020-03-10 21:06:53 +00:00
completion.go	internal/lsp: return early in completion where possible	2020-05-07 20:50:54 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: make sure diagnostics only refer to existing files	2020-05-07 02:01:22 +00:00
folding_range.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
format_test.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
format.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
highlight.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
hover.go	internal/lsp: handle hover documentation for package declarations	2020-04-29 20:57:41 +00:00
identifier.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
implementation.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
options.go	internal/lsp/source: use the setString method when setting options	2020-05-08 18:47:48 +00:00
references.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
rename_check.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
rename.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
signature_help.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
source_test.go	internal/lsp: fix imports issue with duplicate package decl	2020-04-16 06:17:24 +00:00
symbols.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
types_format.go	internal/lsp/source: fix cloneExpr for SelectorExprs	2020-05-08 22:40:54 +00:00
util.go	internal/lsp: refactor code for formatting signatures	2020-04-22 20:52:58 +00:00
view.go	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
workspace_symbol.go	internal/lsp/source: return nothing for empty workspace symbol queries	2020-05-08 20:51:52 +00:00