mirror of
https://github.com/golang/go
synced 2024-11-19 00:04:40 -07:00
d7101b74a4
The early return logic for didOpen events in (*snapshot).invalidateContent was preventing the creation of a new snapshot, which was in turn stopping the versions from being updated. This exposed a fundamental issue in the way we were calculating workspace diagnostics. Since we weren't waiting for diagnostics to be completed for an entire snapshot before replying that the server had been initialized, snapshots were being cloned without any type information. For quickfix code actions, we assume that we have all information cached (since we need to have sent the diagnostics that the quickfix is mapped to), so we were not finding the cached analysis results. To handle this in the short-term, we key analyses by their names, and then regenerate results as-needed for code actions. This is technically more correct than simply assuming that we have the analyses cached. In a follow-up CL, I will send a follow-up that will make sure that snapshots "wait" on each other to be fully constructed before being cloned. Change-Id: Ie89fcdb438b6b8b675f87335561bf47b768641ac Reviewed-on: https://go-review.googlesource.com/c/tools/+/208265 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com>
140 lines
3.4 KiB
Go
140 lines
3.4 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package cache
|
|
|
|
import (
|
|
"context"
|
|
"go/ast"
|
|
"go/types"
|
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
"golang.org/x/tools/internal/span"
|
|
errors "golang.org/x/xerrors"
|
|
)
|
|
|
|
// pkg contains the type information needed by the source package.
|
|
type pkg struct {
|
|
// ID and package path have their own types to avoid being used interchangeably.
|
|
id packageID
|
|
pkgPath packagePath
|
|
mode source.ParseMode
|
|
|
|
goFiles []source.ParseGoHandle
|
|
compiledGoFiles []source.ParseGoHandle
|
|
errors []*source.Error
|
|
imports map[packagePath]*pkg
|
|
types *types.Package
|
|
typesInfo *types.Info
|
|
typesSizes types.Sizes
|
|
}
|
|
|
|
// Declare explicit types for package paths and IDs to ensure that we never use
|
|
// an ID where a path belongs, and vice versa. If we confused the two, it would
|
|
// result in confusing errors because package IDs often look like package paths.
|
|
type packageID string
|
|
type packagePath string
|
|
|
|
func (p *pkg) ID() string {
|
|
return string(p.id)
|
|
}
|
|
|
|
func (p *pkg) PkgPath() string {
|
|
return string(p.pkgPath)
|
|
}
|
|
|
|
func (p *pkg) CompiledGoFiles() []source.ParseGoHandle {
|
|
return p.compiledGoFiles
|
|
}
|
|
|
|
func (p *pkg) File(uri span.URI) (source.ParseGoHandle, error) {
|
|
for _, ph := range p.compiledGoFiles {
|
|
if ph.File().Identity().URI == uri {
|
|
return ph, nil
|
|
}
|
|
}
|
|
for _, ph := range p.goFiles {
|
|
if ph.File().Identity().URI == uri {
|
|
return ph, nil
|
|
}
|
|
}
|
|
return nil, errors.Errorf("no ParseGoHandle for %s", uri)
|
|
}
|
|
|
|
func (p *pkg) GetSyntax() []*ast.File {
|
|
var syntax []*ast.File
|
|
for _, ph := range p.compiledGoFiles {
|
|
file, _, _, err := ph.Cached()
|
|
if err == nil {
|
|
syntax = append(syntax, file)
|
|
}
|
|
}
|
|
return syntax
|
|
}
|
|
|
|
func (p *pkg) GetErrors() []*source.Error {
|
|
return p.errors
|
|
}
|
|
|
|
func (p *pkg) GetTypes() *types.Package {
|
|
return p.types
|
|
}
|
|
|
|
func (p *pkg) GetTypesInfo() *types.Info {
|
|
return p.typesInfo
|
|
}
|
|
|
|
func (p *pkg) GetTypesSizes() types.Sizes {
|
|
return p.typesSizes
|
|
}
|
|
|
|
func (p *pkg) IsIllTyped() bool {
|
|
return p.types == nil || p.typesInfo == nil || p.typesSizes == nil
|
|
}
|
|
|
|
func (p *pkg) GetImport(pkgPath string) (source.Package, error) {
|
|
if imp := p.imports[packagePath(pkgPath)]; imp != nil {
|
|
return imp, nil
|
|
}
|
|
// Don't return a nil pointer because that still satisfies the interface.
|
|
return nil, errors.Errorf("no imported package for %s", pkgPath)
|
|
}
|
|
|
|
func (p *pkg) Imports() []source.Package {
|
|
var result []source.Package
|
|
for _, imp := range p.imports {
|
|
result = append(result, imp)
|
|
}
|
|
return result
|
|
}
|
|
|
|
func (s *snapshot) FindAnalysisError(ctx context.Context, pkgID, analyzerName, msg string, rng protocol.Range) (*source.Error, error) {
|
|
analyzer, ok := s.View().Options().Analyzers[analyzerName]
|
|
if !ok {
|
|
return nil, errors.Errorf("unexpected analyzer: %s", analyzerName)
|
|
}
|
|
act, err := s.actionHandle(ctx, packageID(pkgID), source.ParseFull, analyzer)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
errs, _, err := act.analyze(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
for _, err := range errs {
|
|
if err.Category != analyzerName {
|
|
continue
|
|
}
|
|
if err.Message != msg {
|
|
continue
|
|
}
|
|
if protocol.CompareRange(err.Range, rng) != 0 {
|
|
continue
|
|
}
|
|
return err, nil
|
|
}
|
|
return nil, errors.Errorf("no matching diagnostic for %s:%v", pkgID, analyzerName)
|
|
}
|