02482a546f
The following instruction is wrongly encoded on arm64: MOVD (R2)(R3<<0), R1 It's incorrectly encoded as MOVD (R2)(R3<<3), R1 The reason for the error is that we hard-coded the shift encoding to 6, which is correct for the MOVB and MOVBU instructions because it only allows a shift amount of 0, but it is wrong for the MOVD instruction because it also allows other shift values. For instructions MOVB, MOVBU and FMOVB, the extension amount must be 0, encoded in "S" as 0 if omitted, or as 1 if present. But in Go, we don't distinguish between Rn.<EXT> and Rn.<EXT><<0, so we encode it as that does not present. This makes no difference to the function of the instruction. Change-Id: I2afe3498392cc9b2ecd524c7744f28b9d6d107b8 Reviewed-on: https://go-review.googlesource.com/c/go/+/510995 Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Run-TryBot: Eric Fang <eric.fang@arm.com> TryBot-Result: Gopher Robot <gobot@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.