mirror of
https://github.com/golang/go
synced 2024-11-05 19:46:11 -07:00
352a5409fa
There were a few cases where we were not properly qualifying package names, particularly if the original package had a named import. Now, we map between these names correctly - handling the case of multiple packages that need to be qualified. This requires applying edits to *ast.SelectorExprs, as well as *ast.Idents. We still do not fully qualify unimported packages, and likely won't, unless that's an issue for many users. Updates golang/go#38591 Change-Id: I966a4d1f936f37ede89362d03da3ff98d8952a06 Reviewed-on: https://go-review.googlesource.com/c/tools/+/229979 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
293 lines
8.0 KiB
Go
293 lines
8.0 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package source
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"go/ast"
|
|
"go/types"
|
|
"strings"
|
|
|
|
"golang.org/x/tools/internal/event"
|
|
"golang.org/x/tools/internal/imports"
|
|
"golang.org/x/tools/internal/lsp/debug/tag"
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/snippet"
|
|
"golang.org/x/tools/internal/span"
|
|
errors "golang.org/x/xerrors"
|
|
)
|
|
|
|
// formatCompletion creates a completion item for a given candidate.
|
|
func (c *completer) item(ctx context.Context, cand candidate) (CompletionItem, error) {
|
|
obj := cand.obj
|
|
|
|
// Handle builtin types separately.
|
|
if obj.Parent() == types.Universe {
|
|
return c.formatBuiltin(ctx, cand)
|
|
}
|
|
|
|
var (
|
|
label = cand.name
|
|
detail = types.TypeString(obj.Type(), c.qf)
|
|
insert = label
|
|
kind = protocol.TextCompletion
|
|
snip *snippet.Builder
|
|
protocolEdits []protocol.TextEdit
|
|
)
|
|
if obj.Type() == nil {
|
|
detail = ""
|
|
}
|
|
|
|
// expandFuncCall mutates the completion label, detail, and snippet
|
|
// to that of an invocation of sig.
|
|
expandFuncCall := func(sig *types.Signature) error {
|
|
s, err := newSignature(ctx, c.snapshot, c.pkg, c.file, "", sig, nil, c.qf)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
snip = c.functionCallSnippet(label, s.params)
|
|
detail = "func" + s.format()
|
|
|
|
// Add variadic "..." if we are using a function result to fill in a variadic parameter.
|
|
if sig.Results().Len() == 1 && c.inference.matchesVariadic(sig.Results().At(0).Type()) {
|
|
snip.WriteText("...")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
switch obj := obj.(type) {
|
|
case *types.TypeName:
|
|
detail, kind = formatType(obj.Type(), c.qf)
|
|
case *types.Const:
|
|
kind = protocol.ConstantCompletion
|
|
case *types.Var:
|
|
if _, ok := obj.Type().(*types.Struct); ok {
|
|
detail = "struct{...}" // for anonymous structs
|
|
} else if obj.IsField() {
|
|
detail = formatVarType(ctx, c.snapshot, c.pkg, c.file, obj, c.qf)
|
|
}
|
|
if obj.IsField() {
|
|
kind = protocol.FieldCompletion
|
|
snip = c.structFieldSnippet(label, detail)
|
|
} else {
|
|
kind = protocol.VariableCompletion
|
|
}
|
|
if obj.Type() == nil {
|
|
break
|
|
}
|
|
|
|
if sig, ok := obj.Type().Underlying().(*types.Signature); ok && cand.expandFuncCall {
|
|
if err := expandFuncCall(sig); err != nil {
|
|
return CompletionItem{}, err
|
|
}
|
|
}
|
|
|
|
// Add variadic "..." if we are using a variable to fill in a variadic parameter.
|
|
if c.inference.matchesVariadic(obj.Type()) {
|
|
snip = &snippet.Builder{}
|
|
snip.WriteText(insert + "...")
|
|
}
|
|
case *types.Func:
|
|
sig, ok := obj.Type().Underlying().(*types.Signature)
|
|
if !ok {
|
|
break
|
|
}
|
|
kind = protocol.FunctionCompletion
|
|
if sig != nil && sig.Recv() != nil {
|
|
kind = protocol.MethodCompletion
|
|
}
|
|
|
|
if cand.expandFuncCall {
|
|
if err := expandFuncCall(sig); err != nil {
|
|
return CompletionItem{}, err
|
|
}
|
|
}
|
|
case *types.PkgName:
|
|
kind = protocol.ModuleCompletion
|
|
detail = fmt.Sprintf("%q", obj.Imported().Path())
|
|
case *types.Label:
|
|
kind = protocol.ConstantCompletion
|
|
detail = "label"
|
|
}
|
|
|
|
// If this candidate needs an additional import statement,
|
|
// add the additional text edits needed.
|
|
if cand.imp != nil {
|
|
addlEdits, err := c.importEdits(ctx, cand.imp)
|
|
if err != nil {
|
|
return CompletionItem{}, err
|
|
}
|
|
|
|
protocolEdits = append(protocolEdits, addlEdits...)
|
|
if kind != protocol.ModuleCompletion {
|
|
if detail != "" {
|
|
detail += " "
|
|
}
|
|
detail += fmt.Sprintf("(from %q)", cand.imp.importPath)
|
|
}
|
|
}
|
|
|
|
// Prepend "&" or "*" operator as appropriate.
|
|
var prefixOp string
|
|
if cand.takeAddress {
|
|
prefixOp = "&"
|
|
} else if cand.makePointer {
|
|
prefixOp = "*"
|
|
} else if cand.dereference > 0 {
|
|
prefixOp = strings.Repeat("*", cand.dereference)
|
|
}
|
|
|
|
if prefixOp != "" {
|
|
// If we are in a selector, add an edit to place prefix before selector.
|
|
if sel := enclosingSelector(c.path, c.pos); sel != nil {
|
|
edits, err := prependEdit(c.snapshot.View().Session().Cache().FileSet(), c.mapper, sel, prefixOp)
|
|
if err != nil {
|
|
return CompletionItem{}, err
|
|
}
|
|
protocolEdits = append(protocolEdits, edits...)
|
|
} else {
|
|
// If there is no selector, just stick the prefix at the start.
|
|
insert = prefixOp + insert
|
|
}
|
|
|
|
label = prefixOp + label
|
|
}
|
|
|
|
detail = strings.TrimPrefix(detail, "untyped ")
|
|
item := CompletionItem{
|
|
Label: label,
|
|
InsertText: insert,
|
|
AdditionalTextEdits: protocolEdits,
|
|
Detail: detail,
|
|
Kind: kind,
|
|
Score: cand.score,
|
|
Depth: len(c.deepState.chain),
|
|
snippet: snip,
|
|
}
|
|
// If the user doesn't want documentation for completion items.
|
|
if !c.opts.documentation {
|
|
return item, nil
|
|
}
|
|
pos := c.snapshot.View().Session().Cache().FileSet().Position(obj.Pos())
|
|
|
|
// We ignore errors here, because some types, like "unsafe" or "error",
|
|
// may not have valid positions that we can use to get documentation.
|
|
if !pos.IsValid() {
|
|
return item, nil
|
|
}
|
|
uri := span.URIFromPath(pos.Filename)
|
|
|
|
// Find the source file of the candidate, starting from a package
|
|
// that should have it in its dependencies.
|
|
searchPkg := c.pkg
|
|
if cand.imp != nil && cand.imp.pkg != nil {
|
|
searchPkg = cand.imp.pkg
|
|
}
|
|
file, pkg, err := findPosInPackage(c.snapshot.View(), searchPkg, obj.Pos())
|
|
if err != nil {
|
|
return item, nil
|
|
}
|
|
ident, err := findIdentifier(ctx, c.snapshot, pkg, file, obj.Pos())
|
|
if err != nil {
|
|
return item, nil
|
|
}
|
|
hover, err := ident.Hover(ctx)
|
|
if err != nil {
|
|
event.Error(ctx, "failed to find Hover", err, tag.URI.Of(uri))
|
|
return item, nil
|
|
}
|
|
item.Documentation = hover.Synopsis
|
|
if c.opts.fullDocumentation {
|
|
item.Documentation = hover.FullDocumentation
|
|
}
|
|
return item, nil
|
|
}
|
|
|
|
// importEdits produces the text edits necessary to add the given import to the current file.
|
|
func (c *completer) importEdits(ctx context.Context, imp *importInfo) ([]protocol.TextEdit, error) {
|
|
if imp == nil {
|
|
return nil, nil
|
|
}
|
|
|
|
uri := span.URIFromPath(c.filename)
|
|
var ph ParseGoHandle
|
|
for _, h := range c.pkg.CompiledGoFiles() {
|
|
if h.File().Identity().URI == uri {
|
|
ph = h
|
|
}
|
|
}
|
|
if ph == nil {
|
|
return nil, errors.Errorf("building import completion for %v: no ParseGoHandle for %s", imp.importPath, c.filename)
|
|
}
|
|
|
|
return computeOneImportFixEdits(ctx, c.snapshot.View(), ph, &imports.ImportFix{
|
|
StmtInfo: imports.ImportInfo{
|
|
ImportPath: imp.importPath,
|
|
Name: imp.name,
|
|
},
|
|
// IdentName is unused on this path and is difficult to get.
|
|
FixType: imports.AddImport,
|
|
})
|
|
}
|
|
|
|
func (c *completer) formatBuiltin(ctx context.Context, cand candidate) (CompletionItem, error) {
|
|
obj := cand.obj
|
|
item := CompletionItem{
|
|
Label: obj.Name(),
|
|
InsertText: obj.Name(),
|
|
Score: cand.score,
|
|
}
|
|
switch obj.(type) {
|
|
case *types.Const:
|
|
item.Kind = protocol.ConstantCompletion
|
|
case *types.Builtin:
|
|
item.Kind = protocol.FunctionCompletion
|
|
sig, err := newBuiltinSignature(ctx, c.snapshot.View(), obj.Name())
|
|
if err != nil {
|
|
return CompletionItem{}, err
|
|
}
|
|
item.Detail = "func" + sig.format()
|
|
item.snippet = c.functionCallSnippet(obj.Name(), sig.params)
|
|
case *types.TypeName:
|
|
if types.IsInterface(obj.Type()) {
|
|
item.Kind = protocol.InterfaceCompletion
|
|
} else {
|
|
item.Kind = protocol.ClassCompletion
|
|
}
|
|
case *types.Nil:
|
|
item.Kind = protocol.VariableCompletion
|
|
}
|
|
return item, nil
|
|
}
|
|
|
|
// qualifier returns a function that appropriately formats a types.PkgName
|
|
// appearing in a *ast.File.
|
|
func qualifier(f *ast.File, pkg *types.Package, info *types.Info) types.Qualifier {
|
|
// Construct mapping of import paths to their defined or implicit names.
|
|
imports := make(map[*types.Package]string)
|
|
for _, imp := range f.Imports {
|
|
var obj types.Object
|
|
if imp.Name != nil {
|
|
obj = info.Defs[imp.Name]
|
|
} else {
|
|
obj = info.Implicits[imp]
|
|
}
|
|
if pkgname, ok := obj.(*types.PkgName); ok {
|
|
imports[pkgname.Imported()] = pkgname.Name()
|
|
}
|
|
}
|
|
// Define qualifier to replace full package paths with names of the imports.
|
|
return func(p *types.Package) string {
|
|
if p == pkg {
|
|
return ""
|
|
}
|
|
if name, ok := imports[p]; ok {
|
|
return name
|
|
}
|
|
return p.Name()
|
|
}
|
|
}
|