mirror of
https://github.com/golang/go
synced 2024-11-23 06:10:05 -07:00
c12b185a6e
Currently rvalue m[k] is transformed during walk into:
tmp1 := *mapaccess(m, k)
tmp2 := append(tmp1, ...)
*mapassign(m, k) = tmp2
However, this is suboptimal, as we could instead produce just:
tmp := mapassign(m, k)
*tmp := append(*tmp, ...)
Optimization is possible only if during Order it may tell that m[k] is
exactly the same at left and right part of assignment. It doesn't work:
1) m[f(k)] = append(m[f(k)], ...)
2) sink, m[k] = sink, append(m[k]...)
3) m[k] = append(..., m[k],...)
Benchmark:
name old time/op new time/op delta
MapAppendAssign/Int32/256-8 33.5ns ± 3% 22.4ns ±10% -33.24% (p=0.000 n=16+18)
MapAppendAssign/Int32/65536-8 68.2ns ± 6% 48.5ns ±29% -28.90% (p=0.000 n=20+20)
MapAppendAssign/Int64/256-8 34.3ns ± 4% 23.3ns ± 5% -32.23% (p=0.000 n=17+18)
MapAppendAssign/Int64/65536-8 65.9ns ± 7% 61.2ns ±19% -7.06% (p=0.002 n=18+20)
MapAppendAssign/Str/256-8 116ns ±12% 79ns ±16% -31.70% (p=0.000 n=20+19)
MapAppendAssign/Str/65536-8 134ns ±15% 111ns ±45% -16.95% (p=0.000 n=19+20)
name old alloc/op new alloc/op delta
MapAppendAssign/Int32/256-8 47.0B ± 0% 46.0B ± 0% -2.13% (p=0.000 n=19+18)
MapAppendAssign/Int32/65536-8 27.0B ± 0% 20.7B ±30% -23.33% (p=0.000 n=20+20)
MapAppendAssign/Int64/256-8 47.0B ± 0% 46.0B ± 0% -2.13% (p=0.000 n=20+17)
MapAppendAssign/Int64/65536-8 27.0B ± 0% 27.0B ± 0% ~ (all equal)
MapAppendAssign/Str/256-8 94.0B ± 0% 78.0B ± 0% -17.02% (p=0.000 n=20+16)
MapAppendAssign/Str/65536-8 54.0B ± 0% 54.0B ± 0% ~ (all equal)
Fixes #24364
Updates #5147
Change-Id: Id257d052b75b9a445b4885dc571bf06ce6f6b409
Reviewed-on: https://go-review.googlesource.com/100838
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
463 lines
8.7 KiB
Go
463 lines
8.7 KiB
Go
// asmcheck
|
|
|
|
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package codegen
|
|
|
|
// These tests check that mapaccess calls are not used.
|
|
// Issues #23661 and #24364.
|
|
|
|
func mapCompoundAssignmentInt8() {
|
|
m := make(map[int8]int8, 0)
|
|
var k int8 = 0
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] += 67
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] -= 123
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] *= 45
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] |= 78
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] ^= 89
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] <<= 9
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] >>= 10
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k]++
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k]--
|
|
}
|
|
|
|
func mapCompoundAssignmentInt32() {
|
|
m := make(map[int32]int32, 0)
|
|
var k int32 = 0
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] += 67890
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] -= 123
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] *= 456
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] |= 78
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] ^= 89
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] <<= 9
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] >>= 10
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k]++
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k]--
|
|
}
|
|
|
|
func mapCompoundAssignmentInt64() {
|
|
m := make(map[int64]int64, 0)
|
|
var k int64 = 0
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] += 67890
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] -= 123
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] *= 456
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] |= 78
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] ^= 89
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] <<= 9
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] >>= 10
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k]++
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k]--
|
|
}
|
|
|
|
func mapCompoundAssignmentComplex128() {
|
|
m := make(map[complex128]complex128, 0)
|
|
var k complex128 = 0
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] += 67890
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] -= 123
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] *= 456
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k]++
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k]--
|
|
}
|
|
|
|
func mapCompoundAssignmentString() {
|
|
m := make(map[string]string, 0)
|
|
var k string = "key"
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] += "value"
|
|
}
|
|
|
|
var sinkAppend bool
|
|
|
|
// TODO: optimization is not applied because of mapslow flag.
|
|
func mapAppendAssignmentInt8() {
|
|
m := make(map[int8][]int8, 0)
|
|
var k int8 = 0
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k], 1)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k], 1, 2, 3)
|
|
|
|
a := []int8{7, 8, 9, 0}
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k], a...)
|
|
|
|
// Exceptions
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(a, m[k]...)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
sinkAppend, m[k] = !sinkAppend, append(m[k], 99)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k+1], 100)
|
|
}
|
|
|
|
func mapAppendAssignmentInt32() {
|
|
m := make(map[int32][]int32, 0)
|
|
var k int32 = 0
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], 1)
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], 1, 2, 3)
|
|
|
|
a := []int32{7, 8, 9, 0}
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], a...)
|
|
|
|
// Exceptions
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(a, m[k]...)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
sinkAppend, m[k] = !sinkAppend, append(m[k], 99)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k+1], 100)
|
|
}
|
|
|
|
func mapAppendAssignmentInt64() {
|
|
m := make(map[int64][]int64, 0)
|
|
var k int64 = 0
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], 1)
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], 1, 2, 3)
|
|
|
|
a := []int64{7, 8, 9, 0}
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], a...)
|
|
|
|
// Exceptions
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(a, m[k]...)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
sinkAppend, m[k] = !sinkAppend, append(m[k], 99)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k+1], 100)
|
|
}
|
|
|
|
// TODO: optimization is not applied because of mapslow flag.
|
|
func mapAppendAssignmentComplex128() {
|
|
m := make(map[complex128][]complex128, 0)
|
|
var k complex128 = 0
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k], 1)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k], 1, 2, 3)
|
|
|
|
a := []complex128{7, 8, 9, 0}
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k], a...)
|
|
|
|
// Exceptions
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(a, m[k]...)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
sinkAppend, m[k] = !sinkAppend, append(m[k], 99)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k+1], 100)
|
|
}
|
|
|
|
func mapAppendAssignmentString() {
|
|
m := make(map[string][]string, 0)
|
|
var k string = "key"
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], "1")
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], "1", "2", "3")
|
|
|
|
a := []string{"7", "8", "9", "0"}
|
|
|
|
// 386:-".*mapaccess"
|
|
// amd64:-".*mapaccess"
|
|
// arm:-".*mapaccess"
|
|
// arm64:-".*mapaccess"
|
|
m[k] = append(m[k], a...)
|
|
|
|
// Exceptions
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(a, m[k]...)
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
sinkAppend, m[k] = !sinkAppend, append(m[k], "99")
|
|
|
|
// 386:".*mapaccess"
|
|
// amd64:".*mapaccess"
|
|
// arm:".*mapaccess"
|
|
// arm64:".*mapaccess"
|
|
m[k] = append(m[k+"1"], "100")
|
|
}
|