mirror of
https://github.com/golang/go
synced 2024-11-22 05:04:40 -07:00
e99e9a6e01
The compiler renames anonymous and blank result parameters to ~rN or ~bN, but the current semantics for computing N are rather annoying and difficult to reproduce cleanly. They also lead to difficult to read escape analysis results in tests. This CL changes N to always be calculated as the parameter's index within the function's result parameter tuple. E.g., if a function has a single result, it will now always be named "~r0". The normative change to this CL is fairly simple, but it requires updating a lot of test expectations. Change-Id: I58a3c94de00cb822cb94efe52d115531193c993c Reviewed-on: https://go-review.googlesource.com/c/go/+/323010 Trust: Matthew Dempsky <mdempsky@google.com> Trust: Dan Scales <danscales@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dan Scales <danscales@google.com>
34 lines
874 B
Go
34 lines
874 B
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis for runtime/internal/atomic.
|
|
|
|
package escape
|
|
|
|
import (
|
|
"runtime/internal/atomic"
|
|
"unsafe"
|
|
)
|
|
|
|
// BAD: should always be "leaking param: addr to result ~r0 level=1$".
|
|
func Loadp(addr unsafe.Pointer) unsafe.Pointer { // ERROR "leaking param: addr( to result ~r0 level=1)?$"
|
|
return atomic.Loadp(addr)
|
|
}
|
|
|
|
var ptr unsafe.Pointer
|
|
|
|
func Storep() {
|
|
var x int // ERROR "moved to heap: x"
|
|
atomic.StorepNoWB(unsafe.Pointer(&ptr), unsafe.Pointer(&x))
|
|
}
|
|
|
|
func Casp1() {
|
|
// BAD: should always be "does not escape"
|
|
x := new(int) // ERROR "escapes to heap|does not escape"
|
|
var y int // ERROR "moved to heap: y"
|
|
atomic.Casp1(&ptr, unsafe.Pointer(x), unsafe.Pointer(&y))
|
|
}
|