1
0
mirror of https://github.com/golang/go synced 2024-11-18 19:24:39 -07:00
go/internal/lsp/tests
Rebecca Stambler 352a5409fa internal/lsp: handle different package names in signature help
There were a few cases where we were not properly qualifying package
names, particularly if the original package had a named import. Now,
we map between these names correctly - handling the case of multiple
packages that need to be qualified. This requires applying edits to
*ast.SelectorExprs, as well as *ast.Idents.

We still do not fully qualify unimported packages, and likely won't,
unless that's an issue for many users.

Updates golang/go#38591

Change-Id: I966a4d1f936f37ede89362d03da3ff98d8952a06
Reviewed-on: https://go-review.googlesource.com/c/tools/+/229979
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-04-27 20:59:12 +00:00
..
tests_cgo.go internal/lsp/tests: skip cgo tests when not supported 2019-11-25 21:54:41 +00:00
tests.go internal/lsp: correctly handle type aliases when formatting 2020-04-23 20:53:58 +00:00
util.go internal/lsp: handle different package names in signature help 2020-04-27 20:59:12 +00:00