qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 04:17:57 -07:00
Code Releases Activity
8,675 Commits 58 Branches 402 Tags 522 MiB
fd2e24727e
Commit Graph

276 Commits

Author SHA1 Message Date
Peter Mundy
9626180918 doc: fix go_spec spelling error 
R=rsc, gri
CC=golang-dev
https://golang.org/cl/2985041
 2010-11-09 08:46:13 -08:00
Robert Griesemer
d73d1c5f32 go spec: line comments may end in EOF 
Consistency argument: A valid Go program should
remain valid after stripping leading and trailing
whitespace. This was not true so far if the last
text in the source was a line comment.

R=iant, ken2, r, rsc, r2
CC=golang-dev
https://golang.org/cl/2906041
 2010-11-04 13:48:32 -07:00
Robert Griesemer
11684680fa go spec: append is now implemented 
R=r, r2
CC=golang-dev
https://golang.org/cl/2717043
 2010-10-29 11:44:48 -07:00
Robert Griesemer
904adfdc46 go spec: clarify return type of append, argument type for ...T parameters 
R=iant, ken2, r, rsc
CC=golang-dev
https://golang.org/cl/2774041
 2010-10-27 10:44:31 -07:00
Robert Griesemer
a8abb64a71 go spec: note re: append() not being implemented yet 
R=rsc
CC=golang-dev
https://golang.org/cl/2761041
 2010-10-26 20:30:35 -07:00
Robert Griesemer
07e983a965 go spec: append built-in 
R=iant, ken2, r, rsc
CC=golang-dev
https://golang.org/cl/2627043
 2010-10-25 16:50:31 -07:00
Robert Griesemer
425bbadd3c go_spec: allow copy() to copy bytes from a string into a []byte 
(language change as discussed a while ago)

R=iant, ken2, r, rsc
CC=golang-dev
https://golang.org/cl/2716041
 2010-10-25 16:41:06 -07:00
Robert Griesemer
a12141e5f4 go spec: relaxed syntax for array, slice, and map composite literals 
For elements which are themselves composite literals, the type may
be omitted if it is identical to the element type of the containing
composite literal.

R=r, rsc, iant, ken2
CC=golang-dev
https://golang.org/cl/2661041
 2010-10-22 08:58:52 -07:00
Russ Cox
bee2d5b0ad gc, spec, tests: no auto-indirect of pointer to interface value 
Implies no embedding of pointer to interface value either.

R=gri, iant, ken2, r, r2
CC=golang-dev
https://golang.org/cl/2289041
 2010-09-30 14:59:41 -04:00
Robert Griesemer
5474e166bc go spec: clarifications for range clause 
R=iant, r, rsc, rog
CC=golang-dev
https://golang.org/cl/2226047
 2010-09-28 14:44:19 -07:00
Russ Cox
00ffd59c1a gc: fix reflect table method receiver 
Fixes #451.
Fixes #770.

R=ken2
CC=golang-dev
https://golang.org/cl/2207045
 2010-09-28 13:43:50 -04:00
Robert Griesemer
0e66a13d10 go_spec: EOF may insert a semicolon 
R=rsc, r, iant
CC=golang-dev
https://golang.org/cl/2266043
 2010-09-27 18:59:11 -07:00
Robert Griesemer
ac771a8a47 go spec: ... changes 
Also: Fixed a bug in the BuiltinCall production.

R=iant, r, rsc
CC=golang-dev
https://golang.org/cl/2278041
 2010-09-24 14:08:28 -07:00
Joe Poirier
d4c8a54579 doc: fix typo in go_spec.html 
R=rsc
CC=golang-dev
https://golang.org/cl/2250041
 2010-09-20 10:51:05 -07:00
Robert Griesemer
9e5bf27acb go_spec: consistent use of 'low', 'high' in slices section 
Also: Added examples for slices with omitted index expressions.

R=r, rsc
CC=golang-dev
https://golang.org/cl/2106047
 2010-09-07 16:32:35 -07:00
Scott Lawrence
0c1695b42e spec: Allow omission of low slice bound 
See also https://golang.org/cl/1957045/

R=gri, rsc, r
CC=golang-dev
https://golang.org/cl/2163042
 2010-09-07 14:30:17 -07:00
Robert Griesemer
947e2180e9 go_spec: fix typo (pointed out by Hiroshi Iwatani) 
R=iant
CC=golang-dev
https://golang.org/cl/2128045
 2010-09-07 11:14:36 -07:00
Robert Griesemer
c423e95da6 go spec clarification: arrays must be addressable to be sliceable 
R=rsc
CC=golang-dev, r
https://golang.org/cl/2141041
 2010-09-02 10:16:31 -07:00
Rob Pike
cb2730e60c spec: delete spurious space (missed fix from previous review) 
No semantic change.

R=rsc
CC=golang-dev
https://golang.org/cl/2099041
 2010-09-01 10:48:45 +10:00
Rob Pike
68f1609eb4 spec: fix a couple of tiny glitches 
R=gri, rsc
CC=golang-dev
https://golang.org/cl/2078041
 2010-09-01 10:40:50 +10:00
Ian Lance Taylor
659966a988 doc: Update gccgo information for recent changes. 
R=r
CC=golang-dev
https://golang.org/cl/1941052
 2010-08-23 17:50:30 -07:00
Rob Pike
132d2f11a8 spec: delete erroneous word 'pointer' in specification of select. 
R=gri
CC=golang-dev
https://golang.org/cl/1960044
 2010-08-16 06:42:41 +10:00
Stephen Ma
0d40e40f5e spec: trivial syntax fix 
R=golang-dev
CC=golang-dev
https://golang.org/cl/1982042
 2010-08-14 10:27:24 +10:00
Robert Griesemer
07cc6440dc go_spec: don't allow parens around the literal type of composite literals 
Background: The current spec is imprecise with respect to the parsing ambiguity
for composite literals: It says that the ambiguity arises when the TypeName form
of the LiteralType is used. The following code:

    if (B) {} ...

is not using the TypeName form (but the parenthesized TypeName form) and thus
could be interpreted as:

    if ((B){}) ...

instead of

    if B {} ...

Both compilers and gofmt choose the latter interpretation. One could fix the
spec by making the clause regarding the parsing ambiguity more precise ("...using
the _possibly parenthesized_ TypeName form of the LiteralType..."). The alternative
(chosen here) is to simply disallow parenthesized literal types. Except for a single
test case (test/parentype.go) there appears to be no Go code under $GOROOT containing
parenthesized literal types. Furthermore, parentheses are never needed around a
literal type for correct parsing.

R=golang-dev
CC=golang-dev
https://golang.org/cl/1913041
 2010-07-29 18:13:41 -07:00
Andrew Gerrand
88fc337fa2 spec: add recover to predeclared identifiers list 
R=gri
CC=golang-dev
https://golang.org/cl/1894043
 2010-07-27 15:03:30 +10:00
Robert Griesemer
dc60c5a7ec go spec: clarification of channel close() 
R=r, rsc
CC=golang-dev
https://golang.org/cl/1766042
 2010-07-14 16:09:22 -07:00
Rob Pike
041d11623f Go specification: Lock down some details about channels and select: 
- nil channel in regular send or receive panics
- empty select blocks forever

R=rsc, gri, iant, ken2
CC=golang-dev
https://golang.org/cl/1825043
 2010-07-13 16:23:54 -07:00
Robert Griesemer
0c2e6b3637 go spec: specify len/cap for nil slices, maps, and channels 
Fixes #891.

R=r, rsc
CC=golang-dev
https://golang.org/cl/1760043
 2010-07-13 11:54:57 -07:00
Robert Griesemer
73ca127e67 go/spec: fix typo 
R=r
CC=golang-dev
https://golang.org/cl/1790041
 2010-07-09 13:02:54 -07:00
Russ Cox
f4429181df spec: restrict when len(x) is constant 
R=gri, iant, ken2, r
CC=golang-dev
https://golang.org/cl/1687047
 2010-07-01 17:49:47 -07:00
Russ Cox
e495351ff7 spec: struct tags must be identical for types to be identical 
We didn't mention this explicitly during our discussions,
but I think it fits the "identical types are spelled identically"
rule that we used.

R=gri, iant, ken2, r, rsc1
CC=golang-dev
https://golang.org/cl/1698043
 2010-06-21 12:42:33 -07:00
Russ Cox
9562592342 spec: remove ... (keeping ...T) 
R=gri, iant, ken2, r, r2
CC=golang-dev
https://golang.org/cl/1632041
 2010-06-12 11:37:13 -07:00
Rob Pike
db8c2b1803 spec: clarify that result parameters are always zeroed before the function executes. 
R=golang-dev
CC=golang-dev
https://golang.org/cl/1641043
 2010-06-11 21:30:03 -07:00
Robert Griesemer
440cc95470 go spec: rename "assignment compatible" -> "assignable" 
R=r, rsc
CC=golang-dev
https://golang.org/cl/1590041
 2010-06-07 17:40:21 -07:00
Robert Griesemer
7bc03718f4 go spec: clean-up and consolidation of spec with implementation 
Specifically:
- introduced notion of "underlying type"
- removed notion of type compatibility
- consolidated rules about assignment compatibility in
  assignment compatibility section
- be consistent with specyfing that nil is the value
  for uninitialized variables that can be nil (this
  was not specified clearly for pointers, functions, interfaces)
- added/fixed various related links throughout
- clarify language on conversions

R=rsc, r, iant, ken2
CC=golang-dev
https://golang.org/cl/1536041
 2010-06-07 15:49:39 -07:00
Robert Griesemer
1d282a8eb2 go spec: Base comparison compatibility on assignment compatibility. 
Specifically:
- Simplified definition of comparison compatibility and folded into
  section on comparison operators since it's only used there.

This is a small language change/cleanup. As a consequence:
- An interface value may now be compared against a non-interface value.
- Channels with opposite directions cannot be compared directly anymore
  (per discussion with rsc).

R=rsc, r, iant, ken2
CC=golang-dev
https://golang.org/cl/1462041
 2010-06-03 16:55:50 -07:00
Robert Griesemer
63f014910d go spec: change def. of "type compatibility" to be non-recursive 
and adjust conversion rules.

Also:
- clarification of type identity (no language change)
- adjust special rules for channel assignment/comparison to
  require identical element types (in correspondence to non-
  recursiveness of type compatibility)

R=rsc, iant, ken2, r
CC=golang-dev
https://golang.org/cl/1376042
 2010-05-28 14:17:30 -07:00
Robert Griesemer
31f2503cde go spec: Disallow &a notation to obtain a slice 
from an array; one needs to write a[0:] instead.

R=rsc, r, iant, ken2
CC=golang-dev
https://golang.org/cl/1365041
 2010-05-27 17:23:25 -07:00
Evan Shaw
67d30bb696 spec: Fix link to fallthrough statements 
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/1303041
 2010-05-25 18:24:07 -07:00
Robert Griesemer
c7e03a32b3 go spec: minor fix, to match conversion rules 4 and 5 
R=rsc
CC=golang-dev
https://golang.org/cl/1270042
 2010-05-24 21:25:01 -07:00
Robert Griesemer
934a520d75 go spec: fix and clarify syntax of conversions 
Fixes #803.

R=rsc, r, iant, ken2
CC=golang-dev
https://golang.org/cl/1281041
 2010-05-24 14:58:26 -07:00
Russ Cox
e7561de09a spec: index of non-addressable array is not addressable 
Motivated by:

func f() []int
func g() [10]int

f()[1] = 1  // ok
g()[1] = 1 // ERROR

R=gri
CC=golang-dev
https://golang.org/cl/1278041
 2010-05-24 14:31:43 -07:00
Evan Shaw
cb4e9f8508 spec: Fix a code tag 
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/1266042
 2010-05-23 11:21:47 -07:00
Robert Griesemer
3af4803704 go spec: added imaginary literal to semicolon rules (was missing) 
- also added links to the respective sections
- reformatted section for better (source html) readability
- added missing closing </li>'s in many places

R=r
CC=golang-dev
https://golang.org/cl/1220041
 2010-05-14 13:11:48 -07:00
Robert Griesemer
56ca697269 go spec: simplify section on channel types 
R=rsc, iant, r
CC=golang-dev
https://golang.org/cl/1171041
 2010-05-07 18:22:40 -07:00
Robert Griesemer
df674ffb43 go spec: clarification of make arguments, 
specification of runtime exceptions for
make and division by zero

R=r, rsc, ken2, iant
CC=golang-dev
https://golang.org/cl/1081041
 2010-05-04 17:31:40 -07:00
Robert Griesemer
39f009cb8e go spec: fix iota description 
R=r, rsc
CC=golang-dev
https://golang.org/cl/946046
 2010-04-29 10:57:27 -07:00
Rob Pike
de92199648 spec: clarify "continue" with label. the text was obvious in intent but 
inaccurate in meaning.

R=gri
CC=golang-dev
https://golang.org/cl/964045
 2010-04-28 13:18:40 -07:00
Robert Griesemer
f5b3c14f31 go spec: fix wrong comment 
Fixes #743.

R=r, rsc
CC=golang-dev
https://golang.org/cl/944044
 2010-04-27 17:52:44 -07:00
Evan Shaw
21110c799d spec: Fix run-time panic header id 
Everything was linking to "Run_time_panics", but the id was "Run_time_errors".

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/961042
 2010-04-22 10:14:53 -07:00
Russ Cox
6aad41919b go_spec updates 
R=r, iant
CC=golang-dev
https://golang.org/cl/921041
 2010-04-13 20:55:57 -07:00
Joe Poirier
d37e87c1b2 gp_spec typo fix: code example in the "Handling panics" section 
R=rsc, adg
CC=golang-dev
https://golang.org/cl/881047
 2010-04-08 10:25:57 +10:00
Robert Griesemer
d4a1619733 go spec: correct clarification of type declaration 
R=rsc, r
CC=golang-dev
https://golang.org/cl/855043
 2010-04-01 12:48:34 -07:00
Robert Griesemer
735e00d4a0 go spec: clarification of type declarations 
R=r, rsc
CC=golang-dev
https://golang.org/cl/849044
 2010-03-31 16:37:22 -07:00
Robert Griesemer
e8e4987ba3 godoc: support for title and subtitle headers when serving .html docs 
and use it to show version (date) of go spec

Fixes #68.

R=rsc
CC=golang-dev, r
https://golang.org/cl/848042
 2010-03-30 17:37:42 -07:00
Andrew Gerrand
10b77f7a2b spec: typo in switch sample code, missing semicolon 
Fixes #697

R=r
CC=golang-dev
https://golang.org/cl/804042
 2010-03-29 13:12:08 +11:00
Russ Cox
97d0e8fe6c gc: allow taking address of out parameters 
Fixes #186.

R=ken2
CC=golang-dev
https://golang.org/cl/793041
 2010-03-26 18:01:02 -07:00
Rob Pike
5bb29fb116 spec changes for panic and recover. 
R=rsc, gri
CC=golang-dev
https://golang.org/cl/763041
 2010-03-25 17:59:59 -07:00
Rob Pike
bf9b8f2c17 Delete panicln from the spec. 
R=rsc, gri, iant, ken2
CC=golang-dev
https://golang.org/cl/738041
 2010-03-24 15:17:00 -07:00
Robert Griesemer
48f0cd2bd5 go spec: modification of defer statement 
R=r, rsc, ken2, iant
CC=golang-dev
https://golang.org/cl/708041
 2010-03-23 17:30:14 -07:00
Robert Griesemer
29f1ca528b Go spec: map indexing never raises a runtime exception. 
Also: Actual map key must be assignment-compatible with
formal map key type.

Fixes #357.

R=r, iant, rsc, ken2
CC=golang-dev
https://golang.org/cl/673042
 2010-03-23 14:01:51 -07:00
Ian Lance Taylor
11a218444f Revert previous change: complexN only converts to complexN. 
This was discussed with Ken and Russ.  6g has been changed,
and both compilers now work this way.  This avoids a double
type conversion--first to the float type, then to the complex
type.

R=r
CC=golang-dev, ken2, rsc
https://golang.org/cl/419042
 2010-03-10 20:38:38 -08:00
Robert Griesemer
ef4c2b85a0 go_spec.html: fix typo and link 
R=r
CC=golang-dev
https://golang.org/cl/382045
 2010-03-10 15:29:36 -08:00
Ian Lance Taylor
18187e7d49 Complex values may only be compared for equality or inequality. 
R=gri, r
CC=golang-dev
https://golang.org/cl/294042
 2010-03-08 14:05:46 -08:00
Ian Lance Taylor
5cf707b499 Clarify that conversions to complex are OK. 
R=r
CC=golang-dev
https://golang.org/cl/296042
 2010-03-08 13:45:03 -08:00
Rob Pike
7297087101 Spec for complex numbers 
R=rsc, ken2, gri, iant
CC=cw, golang-dev
https://golang.org/cl/227041
 2010-03-04 12:35:16 -08:00
Robert Griesemer
f42e8833b3 language spec: make NUL byte rule an implementation restriction 
R=rsc, r, iant, ken2
CC=golang-dev
https://golang.org/cl/211041
 2010-02-17 15:50:34 -08:00
Russ Cox
b7d9ffeecd spec: disallow NUL in source files 
R=r
CC=golang-dev
https://golang.org/cl/209042
 2010-02-16 16:47:18 -08:00
Rob Pike
1811fac7cb specification of []int(string) and []byte(string). 
also clarify other string conversions.

R=rsc, iant, gri, ken2
CC=golang-dev
https://golang.org/cl/207103
 2010-02-17 11:26:09 +11:00
Rob Pike
810def8484 ...T is now implemented 
R=rsc, gri
CC=golang-dev
https://golang.org/cl/198050
 2010-02-01 18:59:23 -08:00
Rob Pike
22a4952bd2 note that ...T is not yet implemented. 
R=rsc
CC=golang-dev
https://golang.org/cl/194114
 2010-01-27 13:45:16 -08:00
Rob Pike
b81065d07f add definition of new parameter style 
... T
for trailing arguments of type T.

R=rsc, gri, ken2, iant
CC=golang-dev
https://golang.org/cl/194100
 2010-01-27 13:14:40 -08:00
Robert Griesemer
1c369bd55f Clarify parsing of channel types. 
R=r, rsc
CC=golang-dev
https://golang.org/cl/194091
 2010-01-27 09:35:39 -08:00
Russ Cox
46871692c2 spec: allow func() func(). 
no longer ambiguous at top level, thanks to new semicolon rules.

use gofmt layout for function types.

Fixes #528.

R=gri
CC=golang-dev
https://golang.org/cl/194077
 2010-01-26 10:25:56 -08:00
Rob Pike
3909b6b479 log.Fatal does not exist. Use log.Crash. 
R=rsc
CC=golang-dev
https://golang.org/cl/193075
 2010-01-25 07:48:31 +11:00
Russ Cox
16205a3534 spec: mention Inf and NaN are supported at run time. 
add hyperlink at mention of package reflect.

Fixes #438.

R=r
CC=golang-dev
https://golang.org/cl/190042
 2010-01-18 15:59:14 -08:00
Ian Lance Taylor
ae13f43810 Clarify when expressions are evaluated for a range clause. 
R=gri, rsc
CC=golang-dev
https://golang.org/cl/189057
 2010-01-13 12:50:45 -08:00
Rob Pike
632a98592d fix typo found by kevin ballard 
R=gri
CC=golang-dev
https://golang.org/cl/186113
 2010-01-13 12:06:33 +11:00
Rob Pike
7ec0856f01 fix typo 
R=gri, iant
CC=golang-dev
https://golang.org/cl/183160
 2010-01-09 07:32:26 +11:00
Robert Griesemer
30e5ed249d remove reference to "basic literal" since it's never defined 
R=rsc, r
CC=golang-dev
https://golang.org/cl/183113
 2010-01-04 17:28:02 -08:00
Robert Griesemer
eb109a765d Clarify section on tokens. 
Fixes #457.

R=r
CC=golang-dev
https://golang.org/cl/181083
 2009-12-28 14:40:42 -08:00
Russ Cox
c1045db1d8 go_spec: use PrimaryExpr as type switch expression 
Without this change, the spec parses <-c.(type) as (<-c).(type)
but parses <-c.(int) as <-(c.(int)).

With this change, the former parses as <-(c.(type)).

All three parsers already implement this rule, because
they look for the "type" word during parsing of a standard
type assertion.  This change merely brings the
spec in line with the implementations.

http://code.google.com/p/go/source/browse/src/cmd/gc/go.y#801
http://code.google.com/p/go/source/browse/src/pkg/go/parser/parser.go#900
http://gcc.gnu.org/viewcvs/branches/gccgo/gcc/go/parse.cc?revision=155389&view=markup#l2469

Pointed out by Brett Kail on golang-nuts.

R=gri
CC=golang-dev
https://golang.org/cl/182044
 2009-12-23 13:48:44 -08:00
Robert Griesemer
130ac74010 Spec modified to reflect new semicolon rules. 
R=rsc, r, iant, ken2
CC=golang-dev
https://golang.org/cl/166066
 2009-12-10 16:43:01 -08:00
Russ Cox
2a5f0c67ca spec: document that built-ins cannot be used as func values 
R=gri
CC=golang-dev
https://golang.org/cl/164088
 2009-12-04 10:23:12 -08:00
Ian Lance Taylor
ccd026486a Add copy to the list of predeclared functions. 
R=gri
https://golang.org/cl/164081
 2009-12-02 13:26:39 -08:00
Robert Griesemer
e919275825 Integrated feedback by Ken. 
Easy stuff in this round, more to come.

R=iant, rsc, r, ken2
https://golang.org/cl/163058
 2009-12-01 16:15:53 -08:00
Fazlul Shahriar
330139e3f2 Fix typo in spec 
R=golang-dev, rsc
https://golang.org/cl/164052
 2009-11-30 21:23:58 -08:00
Rob Pike
ff6a8fd779 mention arrays of arrays and slices of slices 
Fixes #113.

R=gri, rsc
CC=golang-dev
https://golang.org/cl/159049
 2009-11-20 15:47:15 -08:00
Robert Griesemer
1a8ebcc4b8 Allow optional second expression in slice expressions. 
Built-in function copy.
Addresses issue 203.

R=rsc, r, iant
https://golang.org/cl/156089
 2009-11-18 19:15:25 -08:00
Robert Griesemer
d3b1565716 - Clarify that struct composite literal keys are field names not selectors. 
- Slight re-phrasing of struct type section since "field name" was not
properly introduced.

Fixes #164.

R=r, rsc, iant
https://golang.org/cl/155061
 2009-11-16 08:58:55 -08:00
Robert Griesemer
0660d243b1 Use ElementType consistently. 
Fixes #173.

R=r, rsc, r1
https://golang.org/cl/154156
 2009-11-15 17:42:27 -08:00
Robert Griesemer
13ad5d40c4 Use // to start comment instead of #. 
Fixes #189.

R=r
CC=rsc
https://golang.org/cl/155055
 2009-11-15 11:33:20 -08:00
Rob Pike
9549eeecd1 add a paragraph about semicolons to the tutorial. 
fix a typo caught by kakugawa@gmail.com

Fixes #92.

R=rsc
CC=golang-dev
https://golang.org/cl/152105
 2009-11-12 14:10:16 -08:00
Rob Pike
cf16443c69 fix a couple of typos. 
add a mention of range to the tutorial.
change tutorial's title.

R=rsc
CC=golang-dev
https://golang.org/cl/152098
 2009-11-12 11:05:20 -08:00
Rob Pike
0b4de7aa8a comment out red TODO clauses except for the last one 
R=rsc
CC=go-dev
http://go/go-review/1024037
 2009-11-09 16:09:57 -08:00
Robert Griesemer
fb5fce5532 fix for incorrect composite literal grammar 
(issue found by ken)

R=go-dev, rsc
http://go/go-review/1025030
 2009-11-09 12:35:56 -08:00
Rob Pike
4fe4192ac9 fixes to spec. mostly minor but several of significance. 
- carriage return is white space
- "" strings cannot span newlines
- f(g()) is ok if g is multivalue and matches f's args

R=rsc, gri
CC=go-dev
http://go/go-review/1024017
 2009-11-07 22:00:59 -08:00
Robert Griesemer
30637151c7 remove gccgo restriction with respect to blank identifiers 
R=iant
CC=go-dev
http://go/go-review/1016032
 2009-11-03 15:10:52 -08:00
Rob Pike
9339e0758b pdf cleanup: fix links, remove internal references. 
fix link in spec.

R=rsc
CC=go-dev
http://go/go-review/1017013
 2009-11-02 15:28:41 -08:00
Robert Griesemer
b691e08e2c clarify rule for channel send 
R=rsc
CC=go-dev
http://go/go-review/1018002
 2009-10-28 18:17:24 -07:00