4 Commits

Author	SHA1	Message	Date
Ian Cottrell	48d47c461c	internal/span: fix utf16 column when span is line based ... A span with column 0 is intended to mean the start of the line, which in utf16 mode must be the 1st character Change-Id: I4b98fe86528b889bbfe4b5ed3ae79c4da81017b1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/167459 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>	2019-03-13 22:14:19 +00:00
Ian Cottrell	dbad8e90c9	internal/lsp: convert to the new location library ... This rationalises all the position handling and conversion code out. Fixes golang/go#29149 Change-Id: I2814f3e8ba769924bc70f35df9e5bf4d97d064de Reviewed-on: https://go-review.googlesource.com/c/tools/+/166884 Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-03-13 19:34:21 +00:00
Ian Cottrell	5c2858a9cf	internal/lsp: adding utf16 handling to the span package ... Change-Id: Icf8a531c4257e31178beea8f98b755648938fa7a Reviewed-on: https://go-review.googlesource.com/c/tools/+/166777 Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-03-11 21:50:38 +00:00
Ian Cottrell	b40df0fb21	internal/span: adding a source location package to unify the pos conversions ... This implements a standard way of describing source locations along with printing and parsing of those locations and conversion to and from the token.Pos forms. Change-Id: Ibb3df0a282bc2effb0fa8bd3a51bb0d281b2ffb1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/163778 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-03-08 14:21:31 +00:00