3 Commits

Author	SHA1	Message	Date
Rebecca Stambler	f0a16743a2	internal/lsp: address staticcheck warnings ... Change-Id: I67c689d31b61425b1eec8b4719e906ce26777759 Reviewed-on: https://go-review.googlesource.com/c/tools/+/198441 Reviewed-by: Ian Cottrell <iancottrell@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>	2019-10-04 02:16:23 +00:00
Ian Cottrell	c7cf430b80	internal/lsp: lift the test loops out into the testing framework ... The loops are common to all the testing layers, so lift them. This prepares for more test improvements, without any funcitonal changes. Change-Id: Ib750c8a7bb4c424a185cb0bd841674a69db1385b Reviewed-on: https://go-review.googlesource.com/c/tools/+/197717 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-09-27 18:07:07 +00:00
Ian Cottrell	6816ec868d	gopls: refactor the cmd tests ... This allows them to be run from the gopls module as well to test the code with the hooks installed. Change-Id: I3079a04ffe3bd221ccc2523e746cbed384e05e2f Reviewed-on: https://go-review.googlesource.com/c/tools/+/196321 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-09-23 22:12:42 +00:00