1
0
mirror of https://github.com/golang/go synced 2024-10-04 17:21:20 -06:00
Commit Graph

155 Commits

Author SHA1 Message Date
Robert Griesemer
47afa4dba5 go/printer: don't lose relevant parentheses when rewriting selector expressions
Also: Simplified handling of selector expressions. As a result, complicated
multi-line expressions containing selectors and calls/indices with arguments
broken accross lines don't get indented the same way as before, but the change
is minimal (see tests) and there's no such code in the std library. It seems
a worthwhile compromise given the much simpler code.

Applied gofmt -w $GOROOT/src $GOROOT/misc .

Fixes #1847.

R=rsc
CC=golang-dev
https://golang.org/cl/5675062
2012-02-15 12:25:37 -08:00
Russ Cox
db93edfc28 builder: fix windows environment
Not causing problems yet, but no need to
keep using cygwin paths now that we're off cygwin.

R=alex.brainman
CC=golang-dev
https://golang.org/cl/5656053
2012-02-14 01:23:25 -05:00
Alex Brainman
97235a769f builder: really set $GOBUILDEXIT for Windows
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5649074
2012-02-13 14:32:45 +11:00
Russ Cox
0bc6836e81 builder: set $GOBUILDEXIT for Windows
Actually %GOBUILDEXIT% I suppose.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5651058
2012-02-10 01:27:59 -05:00
Russ Cox
ee3e24f2d7 dashboard: add gobuilder -fail mode
This is for filling a column with "fail", like I just did for
Windows, when the builder would get stuck running that
build.  (We have safeguards against the tests getting stuck
but this was the bootstrap build getting stuck.)

I usually use -cmd=/bin/false, but this avoids the Mercurial
checkouts, which means it runs instantly instead of requiring
~1 minute per "fail".

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5649049
2012-02-09 23:46:48 -05:00
Alex Brainman
947ea6f750 gobuilder: fix windows builder
Do not rewrite commands if they have .bash extnsion.
Use path/filepath to manipulate file paths everywhere.
Use all.bat on windows, not all.bash.
Use HOMEDRIVE/HOMEPATH to find .gobuildkey on windows.

R=rsc
CC=golang-dev
https://golang.org/cl/5630062
2012-02-09 14:52:01 +11:00
Andrew Gerrand
22185aed74 dashboard: update to go1beta
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5624056
2012-02-06 09:26:32 +11:00
Andrew Gerrand
aa716e36a6 dashboard: don't send failing Go commits as todos for subrepos
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5608044
2012-02-03 14:03:46 +11:00
Russ Cox
2050a9e478 build: remove Make.pkg, Make.tool
Consequently, remove many package Makefiles,
and shorten the few that remain.

gomake becomes 'go tool make'.

Turn off test phases of run.bash that do not work,
flagged with $BROKEN.  Future CLs will restore these,
but this seemed like a big enough CL already.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5601057
2012-01-30 23:43:46 -05:00
Andrew Gerrand
1f5f457ba3 dashboard: better ui layout for subrepo status
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5595048
2012-01-31 12:09:56 +11:00
Andrew Gerrand
0f2659a323 builder: drop recover blocks
The one time they recovered from anything they obscured a useful stack
trace. We're better off just crashing hard.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5577073
2012-01-30 14:53:48 +11:00
Andrew Gerrand
faa1bf04fd dashboard: ask builders to re-build Go tip to freshen subrepos
This ensures we always have results for subrepo-tip at go-tip.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5569091
2012-01-30 14:50:36 +11:00
Andrew Gerrand
43ebc6b5c6 gobuilder: use go tool to build and test sub-repositories
R=rsc
CC=golang-dev
https://golang.org/cl/5576047
2012-01-30 12:02:14 +11:00
Andrew Gerrand
d87813b51c dashboard: add sub-repositories to init list
dashboard: add Kind to Package struct
dashboard: add kind parameter to /packages handler

R=rsc, bsiegert, rogpeppe
CC=golang-dev
https://golang.org/cl/5572062
2012-01-30 11:59:06 +11:00
Gustavo Niemeyer
0442087f93 encoding/xml: bring API closer to other packages
Includes gofix module. The only case not covered should be
xml.Unmarshal, since it remains with a similar interface, and
would require introspecting the type of its first argument
better.

Fixes #2626.

R=golang-dev, rsc, gustavo
CC=golang-dev
https://golang.org/cl/5574053
2012-01-24 01:10:32 -02:00
Russ Cox
c1b4be6a4d dashboard: fix -commit for new xml package
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5571046
2012-01-23 11:50:39 -05:00
Robert Griesemer
eac31c67a8 go/doc: streamlined go/doc API
- the main changes are removing the Doc suffix
  from the exported types, so instead of
  doc.TypeDoc one will have doc.Type, etc.

- All exported types now have a Name (or Names) field.
  For Values, the Names field lists all declared variables
  or constants.

- Methods have additional information about where they are
  coming from.

- There's a mode field instead of a bool to
  control the package's operation, which makes
  it easier to extend w/o API changes.

Except for the partially implemented new Method type,
this is based on existing code. A clean rewrite is in
progress based on this new API.

R=rsc, kevlar
CC=golang-dev
https://golang.org/cl/5528060
2012-01-12 17:36:57 -08:00
Russ Cox
c356fc74a1 dashboard: add deployment comment to app.yaml
Also update default app and version to be correct.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5541044
2012-01-12 11:06:09 -08:00
Rob Pike
eb94327068 dashboard: use build.golang.org as the domain
The domain returned by appengine.DefaultVersionHostname
isn't the one we want.
This change has been uploaded to build.golang.org

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/5539043
2012-01-12 10:42:39 -08:00
Olivier Duperray
014c342b1e misc/dashboard/builder: fix comment in http.go
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5534074
2012-01-11 13:23:33 -08:00
Andrew Gerrand
5cf803f438 builder: pass through TMPDIR env var, drop DISABLE_NET_TESTS
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5530076
2012-01-11 15:44:20 +11:00
Robert Hencke
a3baccefd6 various: fix prints
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516049
2012-01-05 18:38:01 -08:00
Andrew Gerrand
126ee245c6 dashboard: increase notification log to 200 lines
The go command lists all packages that were built.
A recent breakage notification included this text:

$ tail -100 < log
ok      errors
ok      exp/ebnf
?       exp/ebnflint [no test files]
ok      exp/gotype
ok      exp/norm
ok      exp/spdy

If the breakage occurred before this point it would
not be visible in the output.

R=golang-dev, gri, kevlar
CC=golang-dev
https://golang.org/cl/5504109
2012-01-04 11:22:58 +11:00
Andrew Gerrand
e6a322b0b9 dashboard: fix todo caching nil
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504082
2011-12-23 16:04:01 +11:00
Andrew Gerrand
5a65cbacd3 dashboard: cache packages, introduce caching helpers
R=rsc, gary.burd, adg
CC=golang-dev
https://golang.org/cl/5498067
2011-12-23 14:44:56 +11:00
David Symonds
0f14ebf993 dashboard: Don't highlight first heading row.
The two heading rows were previously a little hard to pick out,
because they were alternately shaded like the commit rows.

R=adg
CC=golang-dev
https://golang.org/cl/5500074
2011-12-23 13:21:25 +11:00
Robert Griesemer
f927d9c1bb partial build fix: add missing argument to NewPackageDoc
R=r
CC=golang-dev
https://golang.org/cl/5489112
2011-12-22 15:52:56 -08:00
Russ Cox
0b702937f1 dashboard: horizontal crunch
* group builders in to columns by OS
* drop builder suffix (moved to hover title)
* cut all domain names from email (full name+email in hover title)
* make ok smaller

This should easily give us room for netbsd and plan9,
even on small laptop screens.

Running at http://build-rsc.golang.org/.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5501064
2011-12-22 10:22:38 -05:00
Russ Cox
550856c59d dashboard: do not require key in source code
Or else eventually someone will check it in.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504071
2011-12-22 10:21:59 -05:00
Andrew Gerrand
1cf45e388d dashboard: delete old build dashboard code
R=rsc
CC=golang-dev
https://golang.org/cl/5502063
2011-12-22 09:53:52 +11:00
Andrew Gerrand
03805054e3 dashboard: add /key handler
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504066
2011-12-22 09:38:57 +11:00
Andrew Gerrand
ddc85f419f dashboard: deprecation notice for the old dashboard
R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5505056
2011-12-22 09:38:35 +11:00
Andrew Gerrand
866c06b91e dashboard: fix typo in css
R=r
CC=golang-dev
https://golang.org/cl/5500059
2011-12-21 21:47:59 +11:00
Andrew Gerrand
351f7efec4 dashboard: use 'ok' instead of 'hit' or 'miss' for bool return vals
R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5505054
2011-12-21 21:12:03 +11:00
Andrew Gerrand
9754d61552 dashboard: cache todo responses
R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/5500057
2011-12-21 17:24:42 +11:00
Andrew Gerrand
5b12940b09 builder: set default builder host to build.golang.org
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5489099
2011-12-21 17:12:16 +11:00
Andrew Gerrand
eecb6a79ff builder: report run time
dashboard: record run time

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504054
2011-12-21 15:43:12 +11:00
Andrew Gerrand
494e52fe1c dashboard: store front page in memcache
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5503056
2011-12-21 14:57:46 +11:00
Andrew Gerrand
4fe73ef40a dashboard: put http handlers in new file handler.go
This CL contains no code changes.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5498056
2011-12-21 14:07:32 +11:00
Andrew Gerrand
03fbf29927 dashboard: send mail on build failure
R=rsc, adg
CC=golang-dev
https://golang.org/cl/5490081
2011-12-21 13:16:47 +11:00
Andrew Gerrand
15782bbfaf dashboard: fix log recording and output
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5503054
2011-12-21 12:13:27 +11:00
Andrew Gerrand
9f0e39b992 dashboard: more descriptive logging, ui tweaks, show better auth error
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5505050
2011-12-21 11:08:47 +11:00
Andrew Gerrand
b0eb68ad16 dashboard: send builder in commit POST query string
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5498055
2011-12-21 09:59:45 +11:00
Andrew Gerrand
8720105776 builder: use go-build.appspot.com instead of godashboard by default
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5489097
2011-12-21 08:28:54 +11:00
Andrew Gerrand
634f0edabc dashboard: todo sends full Commit with Kind field
Permits us to implement other Kinds of todo instruction in the future.

R=rsc
CC=golang-dev
https://golang.org/cl/5495087
2011-12-20 15:30:11 +11:00
Andrew Gerrand
7c94dc04a7 dashboard: display correct package build state
Includes some boring whitespace tweaks.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5492067
2011-12-20 11:30:48 +11:00
Andrew Gerrand
35755b9cdb dashboard: improve formatting of build status page
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5493077
2011-12-19 16:57:25 +11:00
Andrew Gerrand
9b3799aa89 builder: send commit time to dashboard
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5489084
2011-12-19 16:57:03 +11:00
Andrew Gerrand
3f216c1b5d dashboard: hide build status column (package builder is out of action)
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5489080
2011-12-19 12:37:39 +11:00
Andrew Gerrand
1338347b9c dashboard: improve key panic message
R=dsymonds
CC=golang-dev
https://golang.org/cl/5495060
2011-12-16 14:59:50 +11:00