3 Commits

Author	SHA1	Message	Date
Nick Craig-Wood	578c521fc2	cmd/stringer: fix panic caused by integer overflow ... When String() was called on the maximum value of an integer type (eg 255 for uint8) this would cause an integer overflow, which would cause an index error later in the code. Fixed by re-arranging the code slightly. Fixes golang/go#10563 Change-Id: I9fd016afc5eea22adbc3843f6081091fd50deccf Reviewed-on: https://go-review.googlesource.com/9255 Reviewed-by: Rob Pike <r@golang.org>	2015-06-02 19:44:20 +00:00
Nathan John Youngman	806f1dbf43	tools/cmd/stringer: fake import C. ... Avoid error "could not import C (can't find import: C)" Fixes golang/go#9169. LGTM=adonovan, r R=golang-codereviews, adonovan, r CC=golang-codereviews https://golang.org/cl/184730043	2014-11-27 15:36:14 +11:00
Rob Pike	d0448f16e3	go.tools/cmd/stringer: add end-to-end test that compiles, runs, and verifies the generated method ... In the process, fix a bug in one of the method generators. LGTM=gri R=gri CC=golang-codereviews https://golang.org/cl/141130043	2014-09-05 15:42:23 -07:00