Dave Cheney
9fb96991e6
net: fix data races on deadline vars
...
Fixes #4434 .
This proposal replaces the previous CL 6855110. Due to issue 599, 64-bit atomic operations should probably be avoided, so use a sync.Mutex instead.
Benchmark comparisons against 025b9d070a85 on linux/386:
CL 6855110:
benchmark old ns/op new ns/op delta
BenchmarkTCPOneShot 710024 727409 +2.45%
BenchmarkTCPOneShotTimeout 758178 768620 +1.38%
BenchmarkTCPPersistent 223464 228058 +2.06%
BenchmarkTCPPersistentTimeout 234494 242600 +3.46%
This proposal:
benchmark old ns/op new ns/op delta
BenchmarkTCPOneShot 710024 718492 +1.19%
BenchmarkTCPOneShotTimeout 758178 748783 -1.24%
BenchmarkTCPPersistent 223464 227628 +1.86%
BenchmarkTCPPersistentTimeout 234494 238321 +1.63%
R=rsc, dvyukov, mikioh.mikioh, alex.brainman, bradfitz
CC=golang-dev, remyoudompheng
https://golang.org/cl/6866050
2012-12-05 15:59:01 +11:00
Rémy Oudompheng
b18a7c7cae
net: remove unnecessary Close contention.
...
Contention profile in BenchmarkTCPOneShot (Core 2 Quad):
Before
Total: 80.285 seconds
44.743 55.7% 55.7% 44.743 55.7% runtime.chanrecv1
31.995 39.9% 95.6% 31.995 39.9% sync.(*Mutex).Lock
3.547 4.4% 100.0% 3.547 4.4% runtime.chansend1
After
Total: 48.341 seconds
45.810 94.8% 94.8% 45.810 94.8% runtime.chanrecv1
2.530 5.2% 100.0% 2.530 5.2% runtime.chansend1
0.001 0.0% 100.0% 0.001 0.0% sync.(*Mutex).Lock
R=golang-dev, dave, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6845119
2012-12-01 09:26:07 +01:00
Anthony Martin
253ed02918
net: update docs and sync API for Plan 9
...
R=golang-dev, dave, mikioh.mikioh, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6674043
2012-11-30 11:41:50 -08:00
Dave Cheney
5b425cc3ab
undo CL 6855110 / 869253ef7009
...
64bit atomics are broken on 32bit systems. This is issue 599.
linux/arm builders all broke with this change, I am concerned that the other 32bit builders are silently impacted.
««« original CL description
net: fix data races on deadline vars
Fixes #4434 .
R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman
CC=golang-dev
https://golang.org/cl/6855110
»»»
R=rsc, mikioh.mikioh, dvyukov, minux.ma
CC=golang-dev
https://golang.org/cl/6852105
2012-11-30 20:02:30 +11:00
Dave Cheney
be0d84e335
net: fix data races on deadline vars
...
Fixes #4434 .
R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman
CC=golang-dev
https://golang.org/cl/6855110
2012-11-30 18:26:51 +11:00
Mikio Hara
0ae80785e6
net: make LocalAddr on multicast UDPConn return a listening address
...
The package go.net/ipv4 allows to exist a single UDP listener
that join multiple different group addresses. That means that
LocalAddr on multicast UDPConn returns a first joined group
address is not desirable.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6822108
2012-11-13 12:26:20 +09:00
Brad Fitzpatrick
ef6806fb13
net: close fds eagerly in DialTimeout
...
Integrates with the pollserver now.
Uses the old implementation on windows and plan9.
Fixes #2631
R=paul, iant, adg, bendaglish, rsc
CC=golang-dev
https://golang.org/cl/6815049
2012-11-08 10:35:16 -06:00
Mikio Hara
9773ac1d08
net: fix comment
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6546044
2012-09-21 07:13:36 +09:00
Mikio Hara
e4389c008a
undo CL 6395055 / 2518eee18c4f
...
Broke TCP selfConnect
««« original CL description
net: avoid nil pointer dereference when RemoteAddr.String method chain is called
Fixes #3721 .
R=dave, rsc
CC=golang-dev
https://golang.org/cl/6395055
»»»
R=rsc
CC=golang-dev
https://golang.org/cl/6533043
2012-09-19 01:33:03 +09:00
Mikio Hara
6c4645cffe
net: rename files to clarify platform dependency
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6489056
2012-09-11 07:37:43 +09:00
