qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 19:40:08 -07:00
Code Releases Activity
42,979 Commits 58 Branches 402 Tags 522 MiB
e3cf0525b0
Commit Graph

117 Commits

Author SHA1 Message Date
Lloyd Dewolf
fbbf219ce9 doc/contribute.html rewrite "Set up auth... code review". 
- Fixed term in preceding section: submitted -> merged.
- Clear transitions between web sites.
- Clarify "types" of G Accounts.
- Less verbose "Configure Git" instructions. [l10n]
- Google uses the term "sign in".
- Mention .gitcookie file created.

Update "Register with Gerrit".
- Link directly to gerrit /login/ .

HTML
- Removed non-ascii "hidden characters".
- Encoded some & and >.

Change-Id: I0d99102def6b32e09b8e42fa40e20227ad5e7568
Reviewed-on: https://go-review.googlesource.com/5892
Reviewed-by: Andrew Gerrand <adg@golang.org>
 2015-03-02 02:11:58 +00:00
Oling Cat
ce36552083 doc/contribute: add necessary <code> tags, remove an extra close parenthesis. 
Change-Id: I7238ae84d637534a345e5d077b8c63466148bd75
Reviewed-on: https://go-review.googlesource.com/1521
Reviewed-by: Russ Cox <rsc@golang.org>
 2015-01-07 17:26:50 +00:00
David Symonds
6cb403319f doc: 2015 will be the Year of the Gopher. 
Change-Id: Ic2e34f84596b56715d5f41c9a5250f7c9f8e671b
Reviewed-on: https://go-review.googlesource.com/2087
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Dave Cheney <dave@cheney.net>
 2014-12-31 13:00:03 +00:00
Andrew Gerrand
0293b7ee37 doc: fixes to contributor docs 
Change-Id: Ib31fb1f8239d8113728bc4c6e411416721571341
Reviewed-on: https://go-review.googlesource.com/1743
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
 2014-12-18 02:17:32 +00:00
Andrew Gerrand
968f0df5d8 doc: update source install instructions 
Change-Id: I794a5773ed47d470ff91fcdd82f9747a91424eb4
Reviewed-on: https://go-review.googlesource.com/1402
Reviewed-by: Rob Pike <r@golang.org>
 2014-12-18 00:54:43 +00:00
Andrew Gerrand
722f7d280b doc: use 'git-codereview' in contributor docs 
Change-Id: I63d5c81fdaf9aca2fc3da3defcc6e9c4094c690b
Reviewed-on: https://go-review.googlesource.com/1742
Reviewed-by: Andrew Gerrand <adg@golang.org>
 2014-12-18 00:45:35 +00:00
Andrew Gerrand
d708e92676 [release-branch.go1.4] [release-branch.go1.4] doc: update contribution guidelines 
LGTM=minux, adg, rsc
R=rsc, r, dsymonds, minux, bradfitz, adg, dave, iant
CC=golang-codereviews
https://golang.org/cl/185190043
 2014-12-12 13:59:23 +11:00
Andrew Gerrand
7f0be1f781 all: use golang.org/x/... import paths 
LGTM=rsc, r
R=r, rsc
CC=golang-codereview, golang-codereviews
https://golang.org/cl/168050043
 2014-11-10 09:15:57 +11:00
Russ Cox
220a6de47e build: adjustments for move from src/pkg to src 
This CL adjusts code referring to src/pkg to refer to src.

Immediately after submitting this CL, I will submit
a change doing 'hg mv src/pkg/* src'.
That change will be too large to review with Rietveld
but will contain only the 'hg mv'.

This CL will break the build.
The followup 'hg mv' will fix it.

For more about the move, see golang.org/s/go14nopkg.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/134570043
 2014-09-08 00:06:45 -04:00
Tetsuo Kiso
48347cc1eb doc/contribute.html: capitalize the first letter 
LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/109080048
 2014-07-07 16:31:20 +10:00
Bill Thiede
822b2cbb33 doc/contribute: reorder documented steps to match normal workflow. 
LGTM=adg
R=golang-codereviews, bradfitz, adg
CC=golang-codereviews
https://golang.org/cl/109970043
 2014-07-03 17:42:23 -04:00
Robert Hencke
75ba181841 doc/contribute.html: link to wiki for more code review information 
(from the discussions on CL 89650044)

LGTM=minux.ma, iant
R=iant, minux.ma
CC=golang-codereviews
https://golang.org/cl/97770043
 2014-04-25 20:09:04 -07:00
Nathan John Youngman
d5f208c874 doc: Revise Contribution Guidelines. 
Smooth out the setup process for new contributors.

* Remove references $GOROOT (often not defined).
* Add a note for contributing to subrepositories.
* Emphasize that hg mail also uploads the latest copy.

LGTM=adg
R=golang-codereviews, iant, adg
CC=golang-codereviews
https://golang.org/cl/74370043
 2014-03-17 09:35:04 +11:00
Brad Fitzpatrick
967901a396 doc: update links in contribute.html 
CLA links are now redirects. Use new URLs instead.

Also, use https:// links for all Google sites where
the http version just redirects to https anyway.
(That's all links on the page, as it turns out)

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews
https://golang.org/cl/69980051
 2014-03-05 14:09:03 -08:00
David Symonds
8f3fc547d0 2014: Year of the Gopher. 
R=adg, djd, mpvl, nigeltao
CC=golang-codereviews
https://golang.org/cl/46660043
 2014-01-01 00:00:22 +11:00
Shawn Smith
2f5f193923 doc/contribute: golang-dev -> golang-codereviews 
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/46320043
 2013-12-29 11:11:28 -08:00
Patrick Higgins
6bf6cae28e doc/contribute: add "Understanding the extension" section 
Fixes #4996

R=golang-dev, r, bradfitz
CC=golang-dev
https://golang.org/cl/7547043
 2013-06-05 21:09:43 -07:00
Rick Arnold
cea78cb58e doc/contribute: add instructions to fix codereview on windows 
Tell Windows users how to update Mercurial's library.zip to add some missing dependencies.

Fixes #4745.

R=golang-dev, patrick.allen.higgins, minux.ma, adg
CC=golang-dev
https://golang.org/cl/7558043
 2013-03-11 12:14:42 +11:00
Rob Pike
7ae41e8010 doc: correct some minor HTML errors found by tidy 
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7439046
 2013-02-28 13:32:36 -08:00
Oling Cat
aecbcd0914 doc/contribute: fix some tags, remove extra space. 
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/7327048
 2013-02-15 14:01:12 +11:00
Dave Cheney
eda9590aae doc: update contribute.html 
Fixes #4582.

* mentioned hg upload.
* added section on hg file.
* added small mention about being inside $GOROOT.
* added hg revert @NNNN
* reorganise the hg submit section for the common case of a non committer.
* made the Copyright section h2
* added note about leaving copyright years unchanged.

R=golang-dev, metanata4, shivakumar.gn, minux.ma, adg, shanemhansen
CC=golang-dev, metanata4
https://golang.org/cl/7278047
 2013-02-10 19:40:33 -05:00
Russ Cox
c64469f8e8 doc/contribute.html: mention hg mail during hg change discussion 
People keep not reading all the way to the bottom of the doc
and not running hg mail.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7137057
 2013-01-18 14:08:42 -05:00
Matthew Dempsky
7d403871cb doc/contribute: Link to IssueTracker docs for more "special sentences" 
Update #4582.

R=nigeltao, dave, adg
CC=golang-dev
https://golang.org/cl/7070065
 2013-01-10 14:17:20 +11:00
Caleb Spare
41f32e0dff doc: two minor edits to contribute.html 
- Missing parenthesis
- Fix bad phrasing

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7063048
 2013-01-06 22:44:16 -05:00
Andrew Gerrand
d5d046e306 doc: update standard copyright header 
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/7034044
 2013-01-02 16:26:25 +11:00
Russ Cox
111fcf1579 doc/contribute: mention 'hg help codereview' 
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6932053
 2012-12-11 13:36:43 -05:00
Shenghou Ma
4c473c02e1 doc/contribute.html: assorted fixes 
0. windows uses all.bat instead of ./all.bash
1. correct expected all.bash output
2. mention you need to use an application specific password
if you're using 2-step verification
3. note you can edit files included in CL by 'hg change NNNN'
or 'hg file'

R=golang-dev, adg, r
CC=golang-dev
https://golang.org/cl/6615060
 2012-10-11 23:33:57 +08:00
David Symonds
156d85c3e9 doc: update text about hgrc and environment variables. 
Mercurial has supported environment variables in hgrc files since
version 1.4 (released November 2009).

R=golang-dev, dave, minux.ma
CC=golang-dev
https://golang.org/cl/6619067
 2012-10-08 22:24:41 +11:00
Jonathan Feinberg
452f40f8e0 doc: add important info for would-be go contributors. 
Link to the "installing from source" docs instead of the "installing" docs.

Remind would-be hacker to switch to the default branch from the release branch.

R=rsc
CC=golang-dev
https://golang.org/cl/6559043
 2012-09-26 14:39:31 -04:00
Shenghou Ma
18b281978c doc: delete Mercurial Queues doc 
Fixes #3716.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6310044
 2012-06-16 02:24:44 +08:00
Andrew Gerrand
3238705f0c doc: mention 'hg update default' in contribution guidelines 
Fixes #3634.

R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/6270047
 2012-06-05 00:55:45 +10:00
Jeremy Jackins
959d0c7ac0 doc: fix typo in contribute.html 
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5795050
 2012-03-10 15:13:34 -08:00
Andrew Gerrand
f78d50c6e5 doc: clean up docs page, refer to wiki, change install doc paths 
R=golang-dev, minux.ma, r
CC=golang-dev
https://golang.org/cl/5728051
 2012-03-05 14:31:27 +11:00
Andrew Gerrand
7cb21a79a4 godoc: specify HTML page metadata with a JSON blob 
This allows HTML pages to specify arbitrary data in a header:

<!--{
        "Title": "The page title",
        ...
}-->

replacing the old style comments:

<!-- title The page title -->

R=gri, rsc, r, bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/5532093
 2012-01-19 11:24:54 +11:00
Peter Mundy
834830d2bb doc: use 2012 for year in model standard copyright header 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5531048
 2012-01-09 10:47:28 -08:00
Florian Weimer
b1175bebd0 contribute.html: do not fill in the reviewer field 
The golang-dev mailing list is added automatically.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5482060
 2011-12-13 17:45:01 -05:00
Rob Pike
9ada841f4d contrib*.html: make "golang-dev" the default reviewer. 
also make a couple of links more visible and fix an id= href.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4517063
 2011-05-13 16:25:31 -07:00
Peter Mundy
c6ed78a4c1 doc: contribution copyright year 2011 
R=r
CC=golang-dev
https://golang.org/cl/3907042
 2011-01-08 17:17:15 -08:00
Nigel Tao
3f38342e24 doc: update contribution guidelines to prefix the change description 
with the primary affected package.

R=rsc, adg
CC=golang-dev
https://golang.org/cl/3867041
 2011-01-05 13:00:08 +11:00
Andrew Gerrand
6ab8d24d72 golang.org redesign 
R=r, rsc, gri
CC=golang-dev, iant, ken2, lvd, nigeltao_golang, stephenm
https://golang.org/cl/2182042
 2010-09-16 14:01:02 +10:00
Peter Williams
6372bbbf3e doc: codereview + Mercurial Queues 
R=rsc, r
CC=golang-dev
https://golang.org/cl/1238044
 2010-06-02 17:11:52 -07:00
Robert Griesemer
36ea8bb7bf Minor mistake in docs. 
Fixes #633.

R=adg
CC=golang-dev
https://golang.org/cl/224090
 2010-03-01 16:22:22 -08:00
Russ Cox
c6336155f1 contribute.html: suggest hg mail instead of hg upload 
R=r
CC=golang-dev
https://golang.org/cl/186145
 2010-01-13 16:44:40 -08:00
Bill Neubauer
14992a4e4b doc/contribute.html: change copyright year 
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/184055
 2010-01-11 13:06:58 -08:00
Rob Pike
96ee38bfc2 make it more explicit that design discussions should happen before code reviews 
R=rsc
CC=golang-dev
https://golang.org/cl/180075
 2009-12-17 12:12:47 +11:00
Devon H. O'Dell
ddde7f6625 Add a Makefile in place of all.bash. Update docs to reflect 
this change.

R=rsc
CC=golang-dev
https://golang.org/cl/171048
 2009-12-11 12:48:55 -08:00
Russ Cox
5facb84770 doc/contribute: try to make it clearer that you send a review with hg mail, not hg submit. 
R=r
https://golang.org/cl/171046
 2009-12-09 14:39:41 -08:00
Russ Cox
d55abfd2c9 doc: split contribute.html into code.html and contribute.html 
R=r
https://golang.org/cl/170042
 2009-12-09 14:05:12 -08:00
Fumitoshi Ukai
65112628dc Fix example Makefile to avoid $GOROOT in case it has spaces. 
R=rsc, sergio
https://golang.org/cl/162058
 2009-11-29 21:22:05 -08:00
Rob Pike
2cbeb1dbb1 change the rules for maintaining AUTHORS and CONTRIBUTORS files. 
the current system is too painful, so instead let's just have the coders tell us the details.
we can update the files ourselves.

R=rsc, r1
CC=golang-dev
https://golang.org/cl/157158
 2009-11-24 14:04:43 -08:00
Ian Lance Taylor
568465a931 Mention golang-dev as a default code review destination. 
R=rsc
CC=r
https://golang.org/cl/160056
 2009-11-24 13:36:54 -08:00
Russ Cox
69039e5a5a build Make.deps during make.bash instead 
of keeping a checked-in copy.  doesn't
slow down make.bash appreciably.

R=r
https://golang.org/cl/156099
 2009-11-19 16:27:13 -08:00
Russ Cox
6672eb3797 change code review link to appspot. 
R=r
https://golang.org/cl/153051
 2009-11-10 18:06:50 -08:00
Russ Cox
c9b5ca457d correct mailing list URL 
R=r
http://go/go-review/1024047
 2009-11-10 09:44:04 -08:00
Russ Cox
4414442442 remove internal references from doc/install.html 
and doc/contribute.html.

add #go-nuts to help section on nav bar.

R=r
http://go/go-review/1025035
 2009-11-10 09:37:03 -08:00
Russ Cox
6c7f9f6340 add id tags to contribute.html 
R=r
http://go/go-review/1025033
 2009-11-09 16:56:17 -08:00
Russ Cox
8b04ceff62 copy help section to install doc, 
since most people won't get to the second one.

R=r
http://go/go-review/1024031
 2009-11-08 23:38:30 -08:00
Russ Cox
830813f019 assorted cleanup 
R=r, iant
CC=go-dev
http://go/go-review/1025024
 2009-11-08 21:08:27 -08:00
Russ Cox
696e802329 contribute.html fixes 
R=r
http://go/go-review/1025019
 2009-11-07 18:56:00 -08:00
Vish Subramanian
8910e427bd Contribute code instructions to use "hg codereview-login" did not work for me. I had to use 
"hg code-login".

R=r, rsc
http://go/go-review/1024012
 2009-11-06 17:08:47 -08:00
Ian Lance Taylor
2528f33535 Add a document on contributing to gccgo. 
R=r, rsc
CC=go-dev
http://go/go-review/1025005
 2009-11-06 14:15:41 -08:00
Russ Cox
9ad14c94db expand "this is not just mercurial" section 
R=r
CC=go-dev
http://go/go-review/1024008
 2009-11-06 10:33:46 -08:00
Russ Cox
38a41eec67 contribute.html 
R=r, iant
CC=go-dev
http://go/go-review/1022007
 2009-11-06 10:04:22 -08:00
Rob Pike
5b72f9cd0b save some text from the old FAQ; will get reworked in time 
R=rsc
http://go/go-review/1018008
 2009-11-01 20:48:21 -08:00
Russ Cox
fb39a4d676 write install docs 
R=r
CC=go-dev
http://go/go-review/1015004
 2009-10-23 15:24:08 -07:00
Rob Pike
242788b054 silly change to test the code review process 
R=rsc
http://go/go-review/1013009
 2009-10-22 14:30:56 -07:00
Russ Cox
09fe283489 main landing pages 
R=r
DELTA=55  (7 added, 34 deleted, 14 changed)
OCL=35984
CL=35986
 2009-10-22 00:13:36 -07:00