1
0
mirror of https://github.com/golang/go synced 2024-11-13 17:20:22 -07:00
Commit Graph

410 Commits

Author SHA1 Message Date
David Symonds
a90cbd741a misc/dashboard/codereview: add sameer.
R=r
CC=golang-dev
https://golang.org/cl/6203076
2012-05-15 08:38:05 +10:00
David Symonds
58bcec62c0 misc/dashboard/codereview: set In-Reply-To header to properly thread mail.
R=adg
CC=golang-dev
https://golang.org/cl/6208051
2012-05-14 10:05:39 +10:00
Jean-Marc Eurin
9d063816ef misc/emacs: Restore the window position after a successful gofmt.
This adds restoring the window position so that the buffer doesn't jump around after the erase/copy.

R=sameer
CC=golang-dev
https://golang.org/cl/5981055
2012-05-07 11:46:01 -04:00
Shenghou Ma
018bcc3535 runtime, misc/cgo/test: fix build for Linux/ARM
1. In CL 5989057, I made a mistake in the last minute change.
"MOVW.W R4, -4(SP)" should really be "MOVW.W R4, -4(R13)",
as 5l will rewrite offset for SP.
2. misc/cgo/test/issue1560.go tests for parallel sleep of 1s,
but on ARM, the deadline is frequently missed, so change sleep
time to 2s on ARM.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6202043
2012-05-05 01:35:13 +08:00
David Symonds
c44a22cc49 misc/dashboard/codereview: remove transitional code.
All current CLs have subject lines, so we don't need to check any more.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6196044
2012-05-04 16:40:24 +10:00
Andrew Gerrand
7a77645aa8 misc/dashboard/codereview: add copyright notices to Go files
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6177043
2012-05-03 09:22:45 +10:00
Rob Pike
ce30769ce3 misc/dashboard/codereview: LGTM favicon
R=dsymonds
CC=golang-dev
https://golang.org/cl/6158043
2012-05-02 13:48:49 +10:00
David Symonds
cc9a5c3be7 misc/dashboard/codereview: preserve CL ordering.
R=r
CC=golang-dev
https://golang.org/cl/6136056
2012-05-01 16:15:32 +10:00
David Symonds
83aa040c45 misc/dashboard/codereview: de-dup LGTMs.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6127066
2012-05-01 11:41:32 +10:00
David Symonds
dae2992c98 misc/dashboard/codereview: send mail immediately, and fill in time.Time fields.
If we delay the mail sending, we can't send as the current user.
If we don't fill in the time.Time fields, datastore.Put will fail
because the zero time.Time value is out of its range.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6136053
2012-05-01 11:33:25 +10:00
David Symonds
1bdb788b2e misc/dashboard/codereview: record Message-ID of code review thread mails.
This will allow us to properly thread "R=..." mails at a later time.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135053
2012-04-30 22:47:51 +10:00
David Symonds
5d331964e7 misc/dashboard/codereview: add handy logout URL.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135052
2012-04-30 22:47:06 +10:00
David Symonds
4335ec9eeb misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in.
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6128054
2012-04-30 22:03:56 +10:00
David Symonds
24cce5c60c misc/dashboard/codereview: don't depend on map iteration order for unit calculation.
Fix auth requirements for /gc endpoint too.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6133049
2012-04-28 09:47:15 +10:00
David Symonds
fe252584f5 misc/dashboard/codereview: simplify parallel operations for front page, and capture timing info.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6128044
2012-04-27 23:16:54 +10:00
David Symonds
1a79053725 misc/dashboard/codereview: more abbreviated modification duration.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6131044
2012-04-27 17:12:09 +10:00
David Symonds
0175e3f1e0 misc/dashboard/codereview: new app.
This is live at http://gocodereview.appspot.com/.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6134043
2012-04-27 16:36:02 +10:00
Andrew Gerrand
029d62f5c0 misc/dist: drop repetition in filenames, default to release tag
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6117066
2012-04-26 13:25:53 -07:00
Andrew Gerrand
b6522c43d5 dashboard: sort user interface by internal counter, not date
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6114053
2012-04-25 13:01:08 -07:00
Mikkel Krautz
78e4d1752e misc/dist: more gophers for OS X installer
Replaces the default OS X installer background
with a more fitting image.

R=golang-dev
CC=golang-dev
https://golang.org/cl/6116043
2012-04-24 09:24:19 -07:00
Mikkel Krautz
c17d09a657 misc/dist: require 10.6 or later for OS X .pkgs
This changes the misc/dist program to generate OS X
packages using pkgbuild and productbuild.

The productbuild utility makes it easy to generate
packages with a custom Distribution file.  This allows
us to add an installcheck script that presents a
friendly message to users who are running on an old
version of Mac OS X.

The change also fixes a few issues with the
postinstall script:

 - In-repo version of the script has been made
   executable. Installers generated using the new
   tools couldn't execute it otherwise.

 - It now uses -d for checking for the existence
   of the Xcode specs directory.

 - The call to sudo.bash has been dropped since cov
   and prof aren't bundled with the binary
   distributions.

Fixes #3455.

Tested on 10.5.8, 10.6.0, 10.6.8 and 10.7.3.

R=adg, golang-dev
CC=golang-dev
https://golang.org/cl/5987044
2012-04-23 14:56:03 -07:00
David Symonds
e6c5e2a363 misc/dashboard: cope with removed Package fields.
adg removed some now-unwanted fields in Package a while ago,
but there are still datastore entities with those fields,
so we must explicitly check for ErrFieldMismatch and ignore it.

R=golang-dev, rsc
CC=adg, golang-dev
https://golang.org/cl/6007043
2012-04-12 09:55:37 +10:00
Dave Cheney
4e9f7047dc misc/dist: include directories in distribution tar and zip files.
Fixes #3458.

R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/5969071
2012-04-05 11:39:12 +10:00
Andrew Gerrand
0f775d6b76 misc/dist: label 386 and amd64 as "32-bit x86" and "64-bit x86"
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5986043
2012-04-05 11:16:37 +10:00
Brad Fitzpatrick
0fd53d8be9 misc/dist: check return value from filepath.Walk
Doesn't fix any known issue. This bit me in some unrelated
code and I thought of this tool.

R=golang-dev, krautz, mikkel
CC=golang-dev
https://golang.org/cl/5976067
2012-04-03 12:33:22 -07:00
Andrew Gerrand
48a76e13a5 misc/dashboard: set api_version to go1
R=golang-dev
CC=golang-dev
https://golang.org/cl/5952046
2012-04-03 08:10:51 +10:00
Sameer Ajmani
b0f4d805f2 misc/emacs: fix go-mode syntax table and whitespace handling.
- flag * and / as comment characters
- mark newline as a comment-ender
- include newline in go-mode-whitespace-p

Thanks Jonathan Amsterdam and Steve Yegge for the patch!

R=golang-dev, rsc
CC=golang-dev, jba, stevey
https://golang.org/cl/5938056
2012-04-02 12:59:37 -04:00
Shenghou Ma
a84056dabe gobuilder: work with codereview plugin enabled in .hgrc
Fixes #3312.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5907065
2012-04-02 18:46:24 +08:00
Mikkel Krautz
28ac033b2e dist: make sure OS X packages follow symlinks when installing
R=adg
CC=golang-dev
https://golang.org/cl/5970061
2012-04-02 16:34:11 +10:00
Andrew Gerrand
81dbec12c8 misc/dist: it sucks hwhen you forget to fix typos
R=golang-dev
CC=golang-dev
https://golang.org/cl/5937049
2012-03-28 12:45:39 +11:00
Andrew Gerrand
70a8948a39 misc/dist: support upload only (no build)
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5940050
2012-03-28 12:24:43 +11:00
Ben Fried
bf9620ebbd misc/emacs: fix overindentation caused by mis-parsing lines ending with special chars
Fixes #3313

go-mode-backward-skip-comments is probably due for a more ambitious refactoring --- it repeats guard conditions after every nearly every movement of point.

R=sameer, r
CC=golang-dev
https://golang.org/cl/5844063
2012-03-26 23:26:39 -04:00
Yasuhiro Matsumoto
a3b86e9379 misc/goplay: fix error on IE8.
use cancelBubble=true instead of preventDefault().

R=golang-dev, rsc, adg
CC=golang-dev
https://golang.org/cl/5888043
2012-03-27 11:16:29 +11:00
Andrew Gerrand
0c58eff0b6 misc/dist: don't ship codereview either
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5917043
2012-03-27 10:38:10 +11:00
Andrew Gerrand
9b6555c605 misc/dist: don't include old python dashboard in releases
I'd prefer not to ship a bunch of bad Python code to everyone who uses
Go 1.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5915043
2012-03-27 09:59:20 +11:00
Andrew Gerrand
bfdc45a456 misc/dist: add -wxs flag to provide custom installer.wxs file
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5908055
2012-03-26 17:32:20 +11:00
Joe Poirier
f4fc889424 windows: install fixes
* set default installation drive to C:\
* remove Win64 component property

R=golang-dev, bradfitz, aram
CC=golang-dev
https://golang.org/cl/5901044
2012-03-26 16:48:20 +11:00
Andrew Gerrand
da7959d5dd misc/dist: make godoc shortcut work
R=golang-dev
CC=golang-dev
https://golang.org/cl/5877062
2012-03-23 12:44:33 +11:00
Andrew Gerrand
e9fef33dd8 misc/dist: updates to installer script
Now sets GOROOT.

Fixes #3287.
Fixes #3361.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5877059
2012-03-23 11:48:54 +11:00
Shenghou Ma
1abd8d8fd0 misc/cgo/gmp: update for Go 1
1. make the program go buildable
2. update os.EINVAL and runtime.Cgocalls()
3. wrap mpz_div_2exp() and mpz_mul_2exp to support both
   pre-5.0 and post-5.0 gmp (we really have no reason to
   restrict ourselves to gmp 5.0+)

R=golang-dev, remyoudompheng, iant
CC=golang-dev
https://golang.org/cl/5847061
2012-03-21 00:51:48 +08:00
Andrew Gerrand
c58163c572 misc/dashboard: remove remnants of package dashboard
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5847070
2012-03-20 13:35:31 +11:00
Brad Fitzpatrick
86c7bc6e8b misc/dist: don't ship cmd/cov or cmd/prof
Fixes #3317

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5784083
2012-03-15 15:22:56 -07:00
Andrew Gerrand
e9f82e6b68 misc/dashboard: remove old python package dashboard
This leaves only the project page, which now resides at the web root.

R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/5833044
2012-03-16 08:20:02 +11:00
Francisco Souza
235863cb12 doc: add "Godoc: documenting Go code" article
Originally published on The Go Programming Language Blog, March 31, 2011.

http://blog.golang.org/2011/03/godoc-documenting-go-code.html

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5830043
2012-03-15 14:51:44 +11:00
Brad Fitzpatrick
d6ea81e0b9 misc/dist: don't lose mode bits when setting tar permissions
R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/5822046
2012-03-14 08:24:11 -07:00
Andrew Gerrand
5c8e88d6d2 misc/dist: remove exp and old before building
Fixes #3317.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5784074
2012-03-14 23:47:34 +11:00
Yasuhiro Matsumoto
2fc5dd66df misc/vim: restore fileencodings.
Currently, ftdetect/gofiletype.vim set fileencodings to open the file as
utf-8 encoding event if the file does not contain multibyte characters.
But fileencodings is global option.

$ vim foo.txt
:set fileencodings
utf-8,ucs-bom,cp932

$ vim foo.go
:set fileencodings
utf-8

This change restore fileencodings before opening the file.
Also added specify fileformats=unix.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5718045
2012-03-14 18:43:01 +11:00
Andrew Gerrand
b3ca3e9564 misc/dist: force modes to 0755 or 0644 in tarballs
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5823045
2012-03-14 17:09:15 +11:00
Brad Fitzpatrick
c405b58f3f misc/dist: better archive/tar Headers
This should live in archive/tar later (CL 5796073) but we
can always do that after Go 1 and stick it here for now.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5754096
2012-03-12 21:49:43 -07:00
Andrew Gerrand
677caf7813 misc/dist: trim space from version string
This prevents us from writing filenames like "weekly.2012-03-12\n.foo.bar.tar.gz".

R=bradfitz
CC=golang-dev
https://golang.org/cl/5783090
2012-03-13 15:31:39 +11:00