Robert Griesemer
e36acdfb56
sort: eliminate extra Len() call
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5521052
2012-01-05 18:40:17 -08:00
Robert Hencke
a3baccefd6
various: fix prints
...
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516049
2012-01-05 18:38:01 -08:00
Andrew Gerrand
2c459f14e9
goinstall: fix test data
...
R=gri
CC=golang-dev
https://golang.org/cl/5519048
2012-01-06 09:48:03 +11:00
Eric Eisner
fd1322828c
cmd/go: Pass arguments to command for run
...
Command arguments are separated from input .go file arguments
by a -- separator.
R=rsc, golang-dev, adg
CC=golang-dev
https://golang.org/cl/5514046
2012-01-06 09:23:00 +11:00
Andrew Gerrand
9443949207
doc: add Slices: usage and internals article
...
Originally published on the Go blog on 5 Jan 2011:
http://blog.golang.org/2011/01/go-slices-usage-and-internals.html
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516046
2012-01-06 09:21:43 +11:00
Andrew Gerrand
c2ea412296
goinstall: use correct checkout URL for Google Code svn repos
...
Fixes #2655 .
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5510045
2012-01-06 09:20:59 +11:00
Andrew Gerrand
5353e1ef96
doc: trim spaces from code snippets
...
gofmt likes to put lines like
// STOP OMIT
two blank lines from a closing brace, creating an ugly space inside
<pre> blocks in some of these files. This change resolves this issue.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5520044
2012-01-06 09:20:31 +11:00
Roger Peppe
5f5a7eb4bc
go test: don't try to print package with error message.
...
If there's a error compiling a _test.go file, the error
message tries to print a *Package with %s. There's no String
method on *Package, so the error message looks bad.
Since the error messages identify the file in question
anyway, this CL removes the package from the error message.
R=rsc, gri
CC=golang-dev
https://golang.org/cl/5520045
2012-01-05 13:19:25 -08:00
Charles L. Dorian
149d3f06d8
math: fix typo in all_test.go
...
Logb errors were reported as Ilogb errors.
R=rsc, golang-dev, gri
CC=golang-dev
https://golang.org/cl/5517045
2012-01-05 11:04:14 -08:00
Mikio Hara
bab56ecb4d
net: fix incorrect mode on ListenIP, ListenUDP
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5523044
2012-01-05 09:44:25 -08:00
Jeff R. Allen
c581ec4918
crypto/tls: Improve TLS Client Authentication
...
Fix incorrect marshal/unmarshal of certificateRequest.
Add support for configuring client-auth on the server side.
Fix the certificate selection in the client side.
Update generate_cert.go to new time package
Fixes #2521 .
R=krautz, agl, bradfitz
CC=golang-dev, mikkel
https://golang.org/cl/5448093
2012-01-05 12:05:38 -05:00
Andrew Gerrand
8f1cb093ff
doc/progs: test defer programs
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5517044
2012-01-05 16:43:02 +11:00
Andrew Gerrand
2469a817ba
net: update DialIP comments to mention protocols
...
Fixes #2637 .
R=golang-dev, mikioh.mikioh, iant
CC=golang-dev
https://golang.org/cl/5508043
2012-01-05 15:18:08 +11:00
Alex Brainman
b682da32b3
make.bash: remove old dregs
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5522043
2012-01-05 14:17:32 +11:00
Sanjay Menakuru
2693232f16
cmd/go: include external test files in the files sent to gofmt, govet, and gofix
...
Also, add XTestGoFiles to the go command's public api.
Fixes #2649 .
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502102
2012-01-05 10:37:15 +11:00
Robert Griesemer
3f1eb94ef2
runtime: fix typo in comment
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5511047
2012-01-04 14:06:54 -08:00
Adam Langley
d5e6b8d016
crypto/tls: update generate_cert.go for new time package
...
Fixes #2635 .
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5512043
2012-01-04 14:56:16 -05:00
Dave Cheney
424f53fa0c
exp/ssh: fix two flow control bugs in chanWriter
...
This CL fixes two issues sending data to the remote peer.
The first bug occurs when the size of the buffer passed to
Write is larger than the current window, in this case, w.rwin
can become negative.
The second issue is more problematic than the first as the
amount of data passed to writePacket was not limited to w.rwin.
In this case the remote peer could silently drop the additional
data, or drop the connection.
Credit to Jacek Masiulaniec for the bug report.
R=agl, jacek.masiulaniec
CC=golang-dev
https://golang.org/cl/5511043
2012-01-04 10:36:21 -05:00
Andrew Gerrand
9d92676f63
unsafe: refer to correct reflect functions
...
Fixes #2641 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5509043
2012-01-04 17:14:56 +11:00
Paul Borman
dfedd34d4f
doc: Fix URL to the Xcode web page
...
R=golang-dev, kevlar
CC=golang-dev
https://golang.org/cl/5504113
2012-01-04 11:31:51 +11:00
Andrew Gerrand
126ee245c6
dashboard: increase notification log to 200 lines
...
The go command lists all packages that were built.
A recent breakage notification included this text:
$ tail -100 < log
ok errors
ok exp/ebnf
? exp/ebnflint [no test files]
ok exp/gotype
ok exp/norm
ok exp/spdy
If the breakage occurred before this point it would
not be visible in the output.
R=golang-dev, gri, kevlar
CC=golang-dev
https://golang.org/cl/5504109
2012-01-04 11:22:58 +11:00
Andrew Balholm
99fed2be27
html: parse <frameset> inside body
...
Pass tests6.dat, test 47:
<param><frameset></frameset>
| <html>
| <head>
| <frameset>
Also pass remaining tests in tests6.dat.
R=nigeltao
CC=golang-dev
https://golang.org/cl/5489136
2012-01-04 09:51:15 +11:00
Sanjay Menakuru
7ccd505dc4
cmd/go: include test files in the files sent to gofmt, govet, and gofix
...
Also, add TestGoFiles to the go command's public api.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5505083
2012-01-03 14:12:54 +11:00
Andrew Gerrand
12d4847263
A+C: add Sanjay Menakuru
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5504110
2012-01-03 14:10:12 +11:00
Evan Shaw
c20c09251c
encoding/json: don't marshal special float values
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5500084
2012-01-03 12:30:18 +11:00
Michael Shields
38ff98b4c6
encoding/xml: use strings.Reader in tests.
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502083
2012-01-03 12:22:02 +11:00
John DeNero
c2b87ce007
doc/codewalk/functions.xml: Fix broken function examples
...
I removed the broken function comparison example and fixed a code highlighting regexp.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501078
2012-01-03 12:15:08 +11:00
Christoph Hack
a274798d6e
cmd/go: refer to the right command in the doc description.
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501072
2012-01-03 12:06:12 +11:00
Benny Siegert
8e9e75f008
gotest: make _testmain.go conform to gofmt rules
...
Otherwise, running "gofmt -d ." after "gotest" gives some
spurious changes.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5504101
2012-01-03 12:00:39 +11:00
Olivier Duperray
e4d624b04d
doc/articles: add {{donotedit}} to templates
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502088
2012-01-03 11:40:58 +11:00
Dave Cheney
7f20bcbbcb
exp/ssh: various small fixes
...
transport.go:
* remove unused nil check.
doc.go:
* improve documentation about supported auth
methods and update Run example.
Thanks Jacek Masiulaniec for both reports.
R=jacek.masiulaniec, agl
CC=golang-dev
https://golang.org/cl/5501075
2011-12-27 09:49:19 -05:00
Rob Pike
6a88f1c4cb
bytes.Buffer: read of 0 bytes at EOF shouldn't be an EOF
...
This corner case arose doing an RPC with a empty-slice payload. Ouch.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5505073
2011-12-26 23:49:24 -08:00
Alex Brainman
83d5402443
misc/windows: add src/pkg/runtime/z* files to installation script
...
Fixes #2614 .
R=golang-dev, jdpoirier
CC=golang-dev
https://golang.org/cl/5505070
2011-12-26 20:25:31 +11:00
Vadim Vygonets
f71c03af90
log/syslog: add Alert method
...
Alert logs a message using the LOG_ALERT priority.
Fixes #2325 .
R=mikioh.mikioh, rsc
CC=golang-dev
https://golang.org/cl/5504058
2011-12-26 09:34:27 +09:00
David Symonds
98b90475ac
flag: change Set method Value interface to return error instead of bool.
...
This yields much better error messages when a bad flag value is given.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5498078
2011-12-25 16:12:26 +11:00
David Symonds
57c9bb4a07
testing: use flag.Duration for -timeout flag.
...
R=golang-dev, gustavo, r
CC=golang-dev
https://golang.org/cl/5498077
2011-12-25 16:07:05 +11:00
Nigel Tao
d5e45e3a8a
html: adjust foreign attributes.
...
Pass tests10.dat, test 22:
<!DOCTYPE html><body xlink:href=foo><svg xlink:href=foo></svg>
| <!DOCTYPE html>
| <html>
| <head>
| <body>
| xlink:href="foo"
| <svg svg>
| xlink href="foo"
Also pass tests through test 29:
<div><svg><path></svg><path>
R=andybalholm
CC=golang-dev
https://golang.org/cl/5489117
2011-12-25 12:42:47 +11:00
Andrew Balholm
b28f017537
html: "in select in table" insertion mode.
...
Pass tests10.dat, test 16:
<!DOCTYPE
html><body><table><tr><td><select><svg><g>foo</g><g>bar</g><p>baz</table><p>quux
| <!DOCTYPE html>
| <html>
| <head>
| <body>
| <table>
| <tbody>
| <tr>
| <td>
| <select>
| "foobarbaz"
| <p>
| "quux"
Also pass tests through test 21:
<!DOCTYPE html><frameset></frameset><svg><g></g><g></g><p><span>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5505069
2011-12-24 11:07:14 +11:00
Marcel van Lohuizen
cadbd3ea49
exp/norm: fixed two unrelated bugs in normalization library.
...
1) incorrect length given for out buffer in String.
2) patchTail bug that could cause characters to be lost
when crossing into the out-buffer boundary.
Added tests to expose these bugs. Also slightly improved
performance of Bytes() and String() by sharing the reorderBuffer
across operations.
Fixes #2567 .
R=r
CC=golang-dev
https://golang.org/cl/5502069
2011-12-23 18:21:26 +01:00
Robert Hencke
335c5db76a
net/rpc: trivial test cleanup
...
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5498066
2011-12-23 22:01:46 +09:00
David Symonds
cf506f6eac
flag: add Duration flag type.
...
This works in the expected way: flag.Duration returns a *time.Duration,
and uses time.ParseDuration for parsing the input.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5489113
2011-12-23 16:29:38 +11:00
David Symonds
f298d0ce29
time: add ParseDuration.
...
R=rsc, r, r
CC=golang-dev
https://golang.org/cl/5489111
2011-12-23 16:28:56 +11:00
Andrew Gerrand
e6a322b0b9
dashboard: fix todo caching nil
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504082
2011-12-23 16:04:01 +11:00
Andrew Gerrand
5a65cbacd3
dashboard: cache packages, introduce caching helpers
...
R=rsc, gary.burd, adg
CC=golang-dev
https://golang.org/cl/5498067
2011-12-23 14:44:56 +11:00
Andrew Gerrand
9c2e0b75c9
tag weekly.2011-12-22
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504081
2011-12-23 14:34:15 +11:00
Andrew Gerrand
1a06b513e7
weekly.2011-12-22
...
R=dsymonds, r, r, rsc, adg, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5498074
2011-12-23 14:28:01 +11:00
Russ Cox
eef7184046
cmd/go: two testing fixes
...
1. Show passing output for "go test" (no args) and with -v flag.
2. Warn about out-of-date packages being rebuilt.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5504080
2011-12-22 22:24:43 -05:00
Russ Cox
3800b14071
runtime: delete old asm_*.h if still around
...
Fixes bug Robert ran into.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5501070
2011-12-22 22:24:34 -05:00
Andrew Gerrand
e8ae29588d
cmd/go: update "go help remote" to use correct Google Code urls
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5489114
2011-12-23 14:09:44 +11:00
Alex Brainman
5962ef2c00
path/filepath: implement Base and Dir for windows
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5501069
2011-12-23 13:23:07 +11:00