3 Commits

Author	SHA1	Message	Date
Ian Cottrell	db1ebf78a8	internal/lsp: move unified diff testing to the diff interface ... This now checks at the diff.TextEdit layer rather than myers.Op Change-Id: I706657a6c5705f0ad7109aa81f4dce174dda5f2b Reviewed-on: https://go-review.googlesource.com/c/tools/+/198380 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-10-04 03:44:59 +00:00
Ian Cottrell	b917058f11	internal/lsp: invert the diff dependencies so myers depends on diff ... This makes it so the diff package is depended on by all implementations, rather than the diff package having to depend on the default myers implementation. Change-Id: I04b9caee6ff1017fa8e5476a7434e4b0e17753c3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/198379 Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-10-04 02:16:33 +00:00
Ian Cottrell	85edb9ef32	internal/lsp: abstract the diff library so it can be substituted ... this moves the actual diff algorithm into a different package and then provides hooks so it can be easily replaced with an alternate algorithm. Change-Id: Ia0359f58878493599ea0e0fda8920f21100e16f1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/190898 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-08-20 03:37:07 +00:00