Rob Pike
114f73f822
fix segfault printing errors. add test case and improve messages.
...
Fixes #338 .
R=rsc
CC=golang-dev
https://golang.org/cl/163083
2009-12-02 10:41:28 -08:00
Rob Pike
f6c0eba741
test that arrays work properly.
...
can't mix slices and arrays now; perhaps that should be a TODO
R=rsc
https://golang.org/cl/164079
2009-12-02 10:25:14 -08:00
Russ Cox
69f893a127
codereview: move reviewers to cc line after submit,
...
so that the issue stops showing up on the
per-reviewer dashboard page.
R=r
https://golang.org/cl/164075
2009-12-02 09:10:59 -08:00
Russ Cox
9e55d0d018
time: another bug in SecondsToUTC.
...
added random test to look for more.
Fixes #363 .
R=r, cw
https://golang.org/cl/163071
2009-12-02 08:27:57 -08:00
Ian Lance Taylor
952b91e4ad
Add Shutdown to 32-bit GNU/Linux build.
...
Submitting as a TBR to fix the build.
R=dho, rsc
https://golang.org/cl/164078
2009-12-02 08:24:14 -08:00
Devon H. O'Dell
e9a8ab031d
lxml.etree is the wrong location for this alt package
...
on my linux machine this is the correct one. lxml.etree
exists with an ElementTree class, but does not contain
an .XML method.
R=rsc
https://golang.org/cl/163082
2009-12-02 08:18:26 -08:00
Devon H. O'Dell
742221d20b
xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3)
...
R=rsc
CC=golang-dev
https://golang.org/cl/164053
2009-12-02 01:16:38 -08:00
Russ Cox
8d652ee8ce
time: fix handling of Jan 1 1601, 1201, 801, ...
...
R=r
CC=hurtonm
https://golang.org/cl/164074
2009-12-01 23:38:06 -08:00
Devon H. O'Dell
eb16346dac
net: fix netFD.Close races
...
Fixes #271 .
Fixes #321 .
R=rsc, agl, cw
CC=golang-dev
https://golang.org/cl/163052
2009-12-01 23:28:57 -08:00
Rob Pike
ff3ea68e52
explicitly catch attempt to decode into a value - must be a pointer to see the result.
...
R=rsc
https://golang.org/cl/163070
2009-12-01 21:47:00 -08:00
Rob Pike
f9810f1b12
make io.ReadFile use Stat.Size as a hint for preallocation
...
R=rsc
CC=golang-dev
https://golang.org/cl/163069
2009-12-01 21:44:24 -08:00
Devon H. O'Dell
49ebcfbb83
Add syscall.Shutdown to FreeBSD i386/amd64
...
Necessary for 163052
R=rsc
CC=golang-dev
https://golang.org/cl/164068
2009-12-01 21:43:39 -08:00
Evan Shaw
1664e81585
8g: Match sgen definition to declaration
...
R=rsc
CC=golang-dev
https://golang.org/cl/164069
2009-12-01 21:42:35 -08:00
Devon H. O'Dell
fd7e1a2d87
FreeBSD needs #!/usr/bin/env bash (fixes broken build on FreeBSD)
...
R=gri
https://golang.org/cl/163067
2009-12-01 19:30:17 -08:00
Russ Cox
0b126c1be4
syscall: add Shutdown on OS X, add more constants in mkerror.sh
...
R=dho
CC=golang-dev
https://golang.org/cl/163061
2009-12-01 16:53:43 -08:00
David Symonds
42ec02be36
Add 'copy' as a Go builtin function for Vim syntax highlighter spec.
...
R=rsc
https://golang.org/cl/163049
2009-12-01 16:45:21 -08:00
Rob Pike
ceb1fe2863
update package unicode to Unicode 5.2
...
R=rsc
CC=golang-dev
https://golang.org/cl/163062
2009-12-01 16:22:21 -08:00
Russ Cox
2a54997baa
gob: fix build
...
TBR=r
https://golang.org/cl/163064
2009-12-01 16:18:27 -08:00
Robert Griesemer
e919275825
Integrated feedback by Ken.
...
Easy stuff in this round, more to come.
R=iant, rsc, r, ken2
https://golang.org/cl/163058
2009-12-01 16:15:53 -08:00
Christopher Wedgwood
4f6dbc6901
Explicitly return values where it's shadowing the parameter.
...
Bad returns noticed by "Devon H. O'Dell" <devon.odell@gmail.com>.
Resolves Issue 360.
R=rsc, dho, agl, agl1
CC=ukai
https://golang.org/cl/163055
2009-12-01 15:54:49 -08:00
Charles L. Dorian
e1c347ca59
8g: fix 386 floating point stack bug
...
Also fixes issue 310 comment 5 error.
Fixes #310 .
R=rsc
https://golang.org/cl/163042
2009-12-01 15:53:50 -08:00
Rob Pike
a0f742d343
more gob bugs
...
1) need to send slice and array types (was only sending element types)
2) compatibleType needs to use decoder's type map
R=rsc
CC=golang-dev
https://golang.org/cl/164062
2009-12-01 15:31:28 -08:00
Robert Griesemer
749da968e4
make test.sh work again
...
R=rsc
https://golang.org/cl/164059
2009-12-01 13:08:36 -08:00
Russ Cox
20cacd64f1
A/C: add Charles L. Dorian
...
R=r
https://golang.org/cl/164060
2009-12-01 12:45:41 -08:00
Sven Almgren
5dd66f01cd
Added Sven Almgren to AUTHORS and CONTRIBUTORS
...
R=rsc
https://golang.org/cl/163053
2009-12-01 12:07:43 -08:00
Rob Pike
67dc2ae3a6
a couple of usage fixups in prof
...
R=rsc
https://golang.org/cl/161050
2009-12-01 11:35:34 -08:00
Fazlul Shahriar
db18ce2f53
gofmt: use os.Stdin instead of opening /dev/stdin
...
Opening /dev/stdin can sometimes fail. For example, in the acme editor,
executing "Edit ,|gofmt" fails with:
open /dev/stdin: no such device or address
Executing "Edit ,|ls -l /dev/stdin /proc/self/fd/0" gives:
lrwxrwxrwx 1 root root 15 2009-09-07 02:17 /dev/stdin -> /proc/self/fd/0
lrwx------ 1 fhs users 64 2009-11-26 22:05 /proc/self/fd/0 -> socket:[5528230]
(This is my first change, and I've signed the individual contributor license agreement.)
R=rsc, gri
CC=golang-dev
https://golang.org/cl/162041
2009-12-01 09:32:22 -08:00
Robert Griesemer
9e450880e9
some godoc cleanup:
...
- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold
R=rsc
https://golang.org/cl/163051
2009-12-01 09:15:05 -08:00
Fazlul Shahriar
330139e3f2
Fix typo in spec
...
R=golang-dev, rsc
https://golang.org/cl/164052
2009-11-30 21:23:58 -08:00
Anthony Starks
593ea31361
Syntax coloring and function navigation for BBEdit/TextWrangler
...
R=rsc
CC=agl1
https://golang.org/cl/154123
2009-11-30 19:24:32 -08:00
Anthony Starks
1cf5d0d4a5
Adding to AUTHORS and CONTRIBUTORS as per http://golang.org/doc/contribute.html#copyright
...
R=rsc
https://golang.org/cl/163050
2009-11-30 19:24:11 -08:00
Roger Peppe
99d0c3d85d
change command-line argument to be
...
unnamed, not require -n, in line with other
entries.
R=rsc
CC=r
https://golang.org/cl/162061
2009-11-30 15:16:40 -08:00
Sergey 'SnakE' Gromov
842d69b03d
Make tests run on systems missing time utility
...
R=rsc
CC=golang-dev
https://golang.org/cl/164047
2009-11-30 15:07:57 -08:00
Adrian O'Grady
5fcb0087df
Added my name to the AUTHORS and CONTRIBUTORS files.
...
R=rsc
https://golang.org/cl/157153
2009-11-30 14:27:37 -08:00
Tor Andersson
598f3e284e
A first stab at porting the XCB X11 protocol bindings to go.
...
The python script needs a checkout of xcb/proto to generate
an xproto.go file, which together with xgb.go provide functions
to access all of the core X11 protocol requests. I have included the
generated file.
Extensions and authentication methods are not implemented.
R=r, rsc, nigeltao_golang
https://golang.org/cl/162053
2009-11-30 14:25:50 -08:00
Sergey 'SnakE' Gromov
9d50b468a1
json: Decode into native Go data structures
...
This patch adds an ability to convert JSON-encoded data into
a hierarchy of Go's native data types.
R=rsc
CC=golang-dev
https://golang.org/cl/161060
2009-11-30 13:55:09 -08:00
Robert Griesemer
c1767dbdda
Typo in comment.
...
Fixes #358 .
R=rsc
CC=r
https://golang.org/cl/164043
2009-11-30 12:50:02 -08:00
Péter Szabó
12206f64dd
sync.RWMutex: rewritten to add support for concurrent readers.
...
Also made sync.xadd public to help testing sync.RWMutex.
Also added unit tests for sync.RWMutex.
R=rsc
https://golang.org/cl/162044
2009-11-30 12:10:56 -08:00
Jonathan Wills
229807c8c3
Added a method on UDPConn so they can actually send broadcast packets.
...
R=rsc
https://golang.org/cl/162046
2009-11-30 12:03:55 -08:00
Christopher Wedgwood
a85c258e67
a[b:len(a)] -> a[b:]
...
R=r, rsc
CC=agl1
https://golang.org/cl/161070
2009-11-30 12:03:43 -08:00
Andrew Skiba
68d3b6e51a
Handle \r as a whitespace when parsing JSON string.
...
Fixes #272 .
R=rsc
https://golang.org/cl/161061
2009-11-30 12:03:26 -08:00
Christopher Wedgwood
c78710f53e
Add trivial whitespace to CorruptInputError strings.
...
R=r, rsc
https://golang.org/cl/161058
2009-11-30 12:03:10 -08:00
Christopher Wedgwood
f0c9719540
Minimise bitrot: bytes.Copy -> copy
...
(compile tested only)
R=r, rsc
https://golang.org/cl/161069
2009-11-30 11:57:21 -08:00
Hector Chu
cd9d72ba9e
Ports of lib9, libbio and libmach to Windows.
...
R=rsc
https://golang.org/cl/157159
2009-11-30 11:53:11 -08:00
Russ Cox
49c859a5f1
AUTHORS+CONTRIBUTORS: more names; CLA verified
...
R=gri
CC=r
https://golang.org/cl/163044
2009-11-30 11:38:41 -08:00
Russ Cox
ed62d27a52
template: two bug fixes / nits
...
* diagnose template not created with New
(current code just crashes)
* write []byte uninterpreted
(current code writes fmt format: "[65 65 65 65]")
R=r
CC=golang-dev
https://golang.org/cl/161075
2009-11-30 10:29:14 -08:00
Russ Cox
be32c6aaf5
codereview: allow editing of local CL description
...
between hg clpatch and hg submit.
R=r
https://golang.org/cl/162059
2009-11-30 10:28:48 -08:00
Russ Cox
1dc65e3aca
AUTHORS/CONTRIBUTORS: two more names
...
R=r, SnakE
CC=fhs, pts
https://golang.org/cl/162054
2009-11-30 10:28:31 -08:00
Fumitoshi Ukai
65112628dc
Fix example Makefile to avoid $GOROOT in case it has spaces.
...
R=rsc, sergio
https://golang.org/cl/162058
2009-11-29 21:22:05 -08:00
Russ Cox
be98bc488e
websocket: avoid $GOROOT in case it has spaces
...
Fixes #115 .
R=r, ukai, sergio
https://golang.org/cl/162057
2009-11-29 20:30:02 -08:00