1
0
mirror of https://github.com/golang/go synced 2024-11-12 13:10:33 -07:00
Commit Graph

6 Commits

Author SHA1 Message Date
Francesc Campoy Flores
e3e09e3d5f doc: add error handling on http.ListenAndServe
Fixes #19511

Change-Id: I5585726773b822dba0be0196961132323ebbe084
Reviewed-on: https://go-review.googlesource.com/53071
Reviewed-by: Chris Broadfoot <cbro@golang.org>
2017-08-31 17:52:01 +00:00
Alex Schroeder
44618b28d4 wiki article: remove "flag" import from the code
When reading along the article, the extra code added in the final
version is not explained. The main function calls flag.Parse(), for
example, which will cause an error, unless the readers looks at the
entirety of final.go to see the import added.

The file shown to the users no longer has the extra flags. The testing
code is now in a patch that gets applied to final.go in order to create
final-test.go. This is the file that will be used to test the code,
matching final.go as much as possible.

Change-Id: I022f5f6c88e107c8ba5623661d74a8d260d05266
Reviewed-on: https://go-review.googlesource.com/11061
Reviewed-by: Andrew Gerrand <adg@golang.org>
2015-06-14 23:26:54 +00:00
Rick Arnold
1f1f69e389 build: fix race in doc/articles/wiki test
The original test would open a local port and then immediately close it
and use the port number in subsequent tests. Between the port being closed
and reused by the later process, it could be opened by some other program
on the machine.

Changed the test to run the server process directly and have it save the
assigned port to a text file to be used by client processes.

Fixes #5564.

LGTM=adg
R=golang-codereviews, gobot, adg
CC=golang-codereviews
https://golang.org/cl/72290043
2014-03-18 13:03:03 +11:00
Andrew Gerrand
0d676f3d1e doc/articles/wiki: fix path handling and clean up test process
Fixes #6525.

R=r
CC=golang-dev
https://golang.org/cl/14383043
2013-10-08 11:14:35 +11:00
Andrew Gerrand
d98507f1c4 doc: update wiki tutorial templates, and template discussion
Fixes #3384.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5915044
2012-03-27 16:07:46 +11:00
Andrew Gerrand
cd1a2f7e74 doc: move wiki tutorial into articles directory, rmdir doc/codelab
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5701050
2012-02-27 11:25:43 +11:00