1
0
mirror of https://github.com/golang/go synced 2024-11-19 16:04:48 -07:00
Commit Graph

98 Commits

Author SHA1 Message Date
Russ Cox
d118905c2c codereview: set status while committing CL
Not sure how to detect read-only but at least
this pins the blame on the hg server.

R=r, bradfitz
CC=golang-dev
https://golang.org/cl/4847053
2011-08-10 21:36:59 -04:00
Andrew Gerrand
87d71a3815 codereview: fix for Mercurial 1.9
R=golang-dev, mirtchovski, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/4686049
2011-07-11 22:58:40 -04:00
Andrew Gerrand
b4f0e8ffd3 undo CL 4675045 / 0e11e08951f7
Breaks Mercurial 1.8.3.

««« original CL description
codereview: fix for Mercurial 1.9

Fixes #2038.

R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/4675045
»»»

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4685055
2011-07-12 09:57:39 +10:00
Andrew Gerrand
762ea79057 codereview: fix for Mercurial 1.9
Fixes #2038.

R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/4675045
2011-07-12 09:36:46 +10:00
Russ Cox
3379414b21 codereview: restrict sync to default branch
'default' is the name of the main branch,
the one that isn't a release branch.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4636072
2011-06-29 00:45:29 -04:00
Russ Cox
f79bcb4b86 codereview: make --ignore_hgpatch_failure work again
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4627067
2011-06-27 13:45:17 -04:00
Robert Hencke
58ff8c1dfd codereview.py: note that hg change -d abandons a change list
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4644043
2011-06-20 14:50:00 -04:00
Russ Cox
404d49154b codereview: handle 'null as missing field' in rietveld json
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4543046
2011-05-13 11:17:06 -04:00
Russ Cox
71102ad25b codereview: fix clpatch
TBR=gri
CC=golang-dev
https://golang.org/cl/4534052
2011-05-12 23:11:52 -04:00
Russ Cox
9d2a697fb9 codereview: fetch metadata using JSON API, not XML scraping
Fixes hg clpatch.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/4524045
2011-05-11 23:26:52 -04:00
Russ Cox
35a37f1735 codereview: add release branch support
Note that if you are working on the upcoming release
branch you have to point your extension path to a
copy of lib/codereview/codereview.py that won't change
as the repository flips between release-branch and default branch.
This warning should only apply to this one branch and only to rsc,
but you never know.

R=adg
CC=golang-dev
https://golang.org/cl/4446076
2011-05-03 10:39:11 -04:00
Russ Cox
4efdeeec51 codereview: various fixes
Set mailed bit correctly for self-clpatch.
Use repo.rollback correctly.
Allow leading spaces in some C code.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4438064
2011-04-25 12:12:53 -04:00
Russ Cox
0c6df25df1 codereview: add 'hg undo' command
R=adg, r
CC=golang-dev
https://golang.org/cl/4423045
2011-04-17 14:15:51 -04:00
Russ Cox
740051ae75 codereview: automatically port old diffs forward
In the current codereview, if a patch was written against
a version of a file that had subsequently been edited,
hg clpatch would fail, even if the patch and the edits were
in different parts of the file.  In this situation the reviewer
typically wrote back saying "please hg sync and hg mail
to update the patch".

This change rewrites the patch automatically, using the
same transformation that hg sync + hg mail would.

If the interim changes (since the patch was created)
affect the same line ranges as the patch, clpatch will
still refuse to apply it.  But this CL should make
of the trivial conflicts we see just go away.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4377046
2011-04-08 13:00:40 -04:00
Russ Cox
88bbf4f1df codereview: fix clpatch
I love Python.  Write once, crash anywhere.

TBR=r
CC=golang-dev
https://golang.org/cl/4382043
2011-04-07 13:06:02 -04:00
Russ Cox
710028d3a4 codereview: drop Author: line on self-clpatch
Right now if a Go developer makes a patch on one machine
and then clpatches it onto another machine, changes
subsequently made to the description are kept only
locally, under the assumption that you are running
clpatch because someone else wrote the CL, so you
don't have permission to update the web.

This change makes clpatch discard the "this was a
clpatch" information from the metadata when you
clpatch your own CLs from one machine to another.

This should eliminate some confusion (for example
in CL 4314054) but will no doubt introduce other
confusion.

R=golang-dev, r2
CC=golang-dev
https://golang.org/cl/4387041
2011-04-07 13:03:06 -04:00
Russ Cox
5b0ef4ac1f codereview: recognize code URL without trailing slash
R=adg
CC=golang-dev
https://golang.org/cl/4385042
2011-04-06 23:07:08 -04:00
Russ Cox
36c009d465 codereview: only retry on HTTP 500 error
R=r
CC=golang-dev
https://golang.org/cl/4353047
2011-04-04 15:47:32 -04:00
Andrew Gerrand
5dd0869bf5 codereview: permit CLs of the form weekly.DATE
gobuilder: recognize CLs of the form weekly.DATE

R=rsc, r
CC=golang-dev
https://golang.org/cl/4282052
2011-03-17 09:11:08 +11:00
Robert Hencke
1ddc27888b codereview.py: do not suggest hg change -d if current user is not CL author
R=golang-dev, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4253064
2011-03-08 12:23:06 -05:00
Gustavo Niemeyer
73aacbda20 codereview: fix clpatch with empty diffs
Avoid passing the placeholder diff to hgpatch, so that
clpatch-ing an empty diff grabs the metadata and warns
about it being empty, rather than failing with a
hard-to-debug problem ("mkdir: no such file or dir",
no metadata, etc).

R=rsc
CC=golang-dev
https://golang.org/cl/4172060
2011-02-23 11:48:40 -05:00
Yasuhiro Matsumoto
3108f3f4a0 codereview: use cmd.communicate.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4145046
2011-02-08 22:30:06 -05:00
Yasuhiro Matsumoto
27191b558c codereview: fix hgpatch on windows
R=rsc
CC=golang-dev
https://golang.org/cl/3989059
2011-02-02 22:43:40 -05:00
Russ Cox
fdb46fb470 codereview: record repository, base revision
Include repository URL in initial mail.
Record repository and base revision in patch description.

R=r
CC=golang-dev
https://golang.org/cl/4126052
2011-02-02 16:39:31 -05:00
Russ Cox
dc9a02fa66 codereview: more ascii vs unicode nonsense
R=r
CC=golang-dev
https://golang.org/cl/4124047
2011-02-01 14:17:41 -05:00
Hector Chu
59a6395279 codereview: fix windows
Uploading go files on Windows aborts with gofmt: exceptions.ValueError:
close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr

R=rsc, mattn, Joe Poirier
CC=golang-dev
https://golang.org/cl/4025046
2011-01-24 14:16:24 -05:00
Russ Cox
17fc373af7 codereview: handle file patterns better
If a file pattern is given and matches files that look
like they need to be hg added or hg removed, offer to do so.

If a file pattern is given and matches files in another CL, warn.

If a file pattern doesn't match anything, point that out.

Vet first line of CL description.

Fixes #972.

R=adg, niemeyer
CC=bradfitzgo, golang-dev
https://golang.org/cl/4099042
2011-01-24 14:14:26 -05:00
Hector Chu
1e0efcd579 codereview: fix hg change on Windows
hg change fails on Windows with 'No valid patches found in output from hg diff'.

R=rsc
CC=golang-dev
https://golang.org/cl/4006043
2011-01-19 19:02:47 -05:00
Ryan Hitchman
30c85bf14c codereview: don't mail change lists with no files
R=rsc
CC=golang-dev
https://golang.org/cl/3561041
2011-01-19 14:46:06 -05:00
Eoghan Sherry
2f8ff0b81d codereview: keep quiet when not in use
This prevents status messages from filling the
screen when using a command like 'hg log | less'.

R=rsc
CC=golang-dev
https://golang.org/cl/3666042
2010-12-15 11:49:43 -05:00
Russ Cox
3b6ddd9bce codereview: more utf-8 nonsense
To annoy hg: Μπορώ να φάω σπασμένα γυαλιά χωρίς να πάθω τίποτα.

R=r
CC=golang-dev
https://golang.org/cl/2900041
2010-11-04 13:58:32 -04:00
Fazlul Shahriar
0e816f5972 codereview: fix 'hg sync' and 'hg download' in Python 2.7
Fixes #1218.

R=rsc
CC=golang-dev
https://golang.org/cl/2664041
2010-11-01 16:37:17 -04:00
Andrew Gerrand
f16b6b14d8 misc: update python scripts to specify python2 or nothing
(Hopefully this changeset will notice my +x to googlecode_upload.py)

Fixes #1217.

R=rsc
CC=golang-dev
https://golang.org/cl/2634041
2010-10-21 15:41:51 +11:00
Russ Cox
49bff2da22 codereview: disallow submit of *.[chys] files indented with spaces
R=r
CC=golang-dev
https://golang.org/cl/2383041
2010-10-06 18:10:23 -04:00
Russ Cox
9499856488 codereview: fix upload of hg copied file
Fixes #1134.

R=r, r2
CC=golang-dev
https://golang.org/cl/2264043
2010-09-28 20:29:20 -04:00
Russ Cox
b2a6558811 codereview: convert email address from Rietveld to lower case
before looking for it in the CONTRIBUTORS file

R=r
CC=golang-dev
https://golang.org/cl/1883049
2010-09-11 23:42:29 -04:00
Evan Shaw
9e162aa3be codereview: Fix uploading for Mercurial 1.6.3
See:
http://selenic.com/repo/hg/rev/32b213b9b22c
http://selenic.com/repo/hg/rev/2096496b40ec

R=rsc, adg
CC=golang-dev
https://golang.org/cl/2072041
2010-08-29 23:04:05 -04:00
Russ Cox
f7d87f355c codereview: speed upload
Cuts time to upload trivial 160-file CL by 5x,
from 250 seconds to 50 seconds.

R=r
CC=golang-dev
https://golang.org/cl/1991047
2010-08-26 18:56:29 -04:00
Russ Cox
3b226f9886 codereview: consistent indent, cut dead code
End the charade (farce?) that we are using upload.py unaltered.
Cut all the unused stuff.
Indent using tabs to match the rest of the file.

Next: rewrite MercurialVCS to use mercurial package,
to avoid overhead of forking off a new hg command
multiple times for every file.  And parallelize upload.

R=gri
CC=golang-dev
https://golang.org/cl/2009046
2010-08-26 18:24:14 -04:00
Russ Cox
4ae2b43ef2 codereview: fix hang on standard hg commands
R=gri
CC=golang-dev
https://golang.org/cl/1950045
2010-08-26 17:06:36 -04:00
Russ Cox
e3ac0b5d3f codereview: print status when hung
After 30 seconds, start printing status updates,
so that we can see whether hg is making progress.

$ hg upload 1983051
Thu Aug 26 15:06:15 2010 running gofmt
Thu Aug 26 15:06:30 2010 inspecting src/pkg/big/int_test.go
Thu Aug 26 15:06:45 2010 inspecting src/pkg/cmath/conj.go
Thu Aug 26 15:07:00 2010 inspecting src/pkg/expvar/expvar.go
Thu Aug 26 15:07:15 2010 inspecting src/pkg/os/env_unix.go
Thu Aug 26 15:07:30 2010 inspecting src/pkg/os/sys_bsd.go
Thu Aug 26 15:07:45 2010 inspecting src/pkg/rand/rand_test.go
Thu Aug 26 15:08:00 2010 inspecting src/pkg/runtime/sig.go
Thu Aug 26 15:08:15 2010 inspecting src/pkg/time/time_test.go
Thu Aug 26 15:08:30 2010 inspecting src/pkg/websocket/websocket.go
Thu Aug 26 15:08:45 2010 uploading src/pkg/utf8/utf8.go
Thu Aug 26 15:09:00 2010 uploading src/pkg/unicode/letter_test.go
Thu Aug 26 15:09:15 2010 uploading src/pkg/xml/embed_test.go
Thu Aug 26 15:09:30 2010 uploading src/pkg/time/tick.go
Thu Aug 26 15:09:45 2010 uploading src/pkg/big/rat_test.go
Thu Aug 26 15:10:00 2010 uploading src/pkg/time/sleep_test.go
Thu Aug 26 15:10:15 2010 uploading src/pkg/patch/patch_test.go
Thu Aug 26 15:10:30 2010 uploading src/pkg/rand/rand.go
https://golang.org/cl/1983051

$

R=gri
CC=golang-dev
https://golang.org/cl/2020045
2010-08-26 16:27:42 -04:00
Russ Cox
e63086548b codereview: really disable codereview when not available
$ hg p
codereview disabled: cannot open /Users/rsc/g/go/src/pkg/goplan9.googlecode.com/hg/lib/codereview/codereview.cfg
$

R=dsymonds, r
CC=golang-dev
https://golang.org/cl/1998046
2010-08-25 17:52:25 -04:00
Russ Cox
7886318ca0 codereview: do not send "Abanoned" mail if this CL has
not been mailed out for review.

R=r
CC=golang-dev
https://golang.org/cl/1962046
2010-08-12 14:58:38 -07:00
Ivan Krasin
e8b8aeb02a codereview.py: Fix issues with leading tabulation in the Files: section of CL description.
R=imkrasin, rsc
CC=golang-dev
https://golang.org/cl/1943042
2010-08-12 00:04:17 -07:00
Russ Cox
bbf925aa56 codereview: avoid crash if no config
Fixes #959.

R=r
CC=golang-dev
https://golang.org/cl/1876045
2010-07-26 17:33:50 -07:00
Russ Cox
08e65f79c1 codereview: make 'hg submit' work with Mercurial 1.6
R=r
CC=golang-dev
https://golang.org/cl/1841044
2010-07-16 18:54:38 -07:00
Russ Cox
ad665e4fde codereview: don't run gofmt with an empty file list
R=gri
CC=golang-dev
https://golang.org/cl/1678054
2010-07-15 16:43:06 -07:00
Evan Shaw
e8fcf60093 codereview: Fix for Mercurial >= 1.6
R=rsc, adg, rsc1
CC=golang-dev
https://golang.org/cl/1804041
2010-07-14 17:17:04 -07:00
Russ Cox
93f614ff86 codereview: allow multiple email addresses in CONTRIBUTORS
R=r
CC=golang-dev
https://golang.org/cl/1650041
2010-06-30 23:34:11 -07:00
Paolo Giarrusso
3ca72458ec codereview: avoid exception in match
R=rsc
CC=golang-dev
https://golang.org/cl/1585041
2010-06-09 21:37:11 -07:00