4 Commits

Author	SHA1	Message	Date
Ian Cottrell	cc9bfb3eec	internal/lsp: rewrite the unified diff handling ... It is now in the diff package written in terms of edits, instead of the myers package. This also means that the unified handling is no longer pluggable because it does not need to be. Change-Id: I7141b023e95ed0c1d21cbc81c7420c117fc5ef1a Reviewed-on: https://go-review.googlesource.com/c/tools/+/198517 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-10-04 03:45:17 +00:00
Ian Cottrell	db1ebf78a8	internal/lsp: move unified diff testing to the diff interface ... This now checks at the diff.TextEdit layer rather than myers.Op Change-Id: I706657a6c5705f0ad7109aa81f4dce174dda5f2b Reviewed-on: https://go-review.googlesource.com/c/tools/+/198380 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-10-04 03:44:59 +00:00
Ian Cottrell	6e0078a899	internal/lsp: allow the diff alorithm to be specified per view ... Change-Id: Ib9d44d2012253189f87bc3b15a88b400f76ae955 Reviewed-on: https://go-review.googlesource.com/c/tools/+/198378 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-10-04 02:16:33 +00:00
Ian Cottrell	71894ab67e	internal/lsp: add tests at the diff hook layer ... this makes sure that any diff implementation obeys the semantics we expect at higher layers Change-Id: Iae8842cfb9fece94ea71c04ec146d825eff0cbeb Reviewed-on: https://go-review.googlesource.com/c/tools/+/191017 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-08-26 23:40:50 +00:00