Russ Cox
1329012a23
new command hgpatch, for use by codereview extension
...
R=r
http://go/go-review/1018059
2009-11-05 09:27:19 -08:00
Robert Griesemer
3630bfbe9f
gofmt-ify math, expvar, exp/spacewar
...
R=rsc
http://go/go-review/1018061
2009-11-05 09:08:08 -08:00
Robert Griesemer
e57acdca4d
gofmt-ify parts of xml
...
R=rsc
http://go/go-review/1017049
2009-11-05 08:59:03 -08:00
Robert Griesemer
12dbd06f0a
gofmt-ify encoding
...
R=rsc
http://go/go-review/1017048
2009-11-05 08:55:18 -08:00
Russ Cox
9df7d6ef10
add -l flag to hg gofmt.
...
don't apply gofmt to non-go files during upload check.
R=r
http://go/go-review/1016048
2009-11-05 08:11:44 -08:00
Russ Cox
d8e0d9a778
add "hg gofmt" to run all modified files through gofmt.
...
add check before Upload, for now disabled by default,
that files do not change when run through gofmt.
enable by adding
[codereview]
force_gofmt = True
to .hgrc or .hg/hgrc.
add doc strings for a few more commands.
rename codereview-login to code-login
to make module doc visible.
R=r
CC=gri
http://go/go-review/1018056
2009-11-04 23:43:55 -08:00
Robert Griesemer
ed494c6398
gofmt-ify sort, sync
...
R=rsc
http://go/go-review/1018057
2009-11-04 23:25:29 -08:00
Robert Griesemer
314b358ab7
gofmt-ify strconv
...
(and remove an empty line at the end of a file)
R=rsc
http://go/go-review/1017046
2009-11-04 23:20:49 -08:00
Robert Griesemer
5d37705416
gofmt-ify net
...
R=rsc
http://go/go-review/1017045
2009-11-04 23:16:46 -08:00
Robert Griesemer
7df45566db
gofmt-ify image
...
R=rsc
http://go/go-review/1017044
2009-11-04 22:52:28 -08:00
Robert Griesemer
ca2a69ea06
gofmt-ify hash, http
...
(gofmt will be able to re-align map entries as in http nicely,
eventually)
R=rsc
http://go/go-review/1018055
2009-11-04 22:45:59 -08:00
Robert Griesemer
b16e6ab148
gofmt-ify tabwriter
...
R=rsc
http://go/go-review/1017042
2009-11-04 22:26:48 -08:00
Robert Griesemer
1fede304ff
more comment formatting:
...
- preserve (some) indentation of comment text for /*-style comments
even if the first comment line does not contain any text that might
suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
(this will not introduce a lot of changes since comments of this
kind - until now - were not changed with respect to indentation)
R=rsc
http://go/go-review/1016047
2009-11-04 22:07:13 -08:00
Rob Pike
7f534246c6
bumper for video
...
R=rsc
http://go/go-review/1017038
2009-11-04 21:56:33 -08:00
Robert Griesemer
841c18a95a
gofmt-ify unicode
...
R=r
http://go/go-review/1018051
2009-11-04 21:39:55 -08:00
Kai Backman
55ba9d6a2c
fixing (badly) linux_arm syscall.
...
R=rsc
http://go/go-review/1017037
2009-11-04 21:34:54 -08:00
Robert Griesemer
601ee4807b
- add a blank before the opening { for multi-line composites
...
(request by r)
- feature temporarily disabled
R=rsc
CC=r
http://go/go-review/1018052
2009-11-04 21:15:47 -08:00
Robert Griesemer
398f220d5b
gofmt-ify os
...
R=r
http://go/go-review/1017034
2009-11-04 20:42:40 -08:00
Ken Thompson
9c7535432a
speed up 6l
...
hopefully no change
R=rsc
http://go/go-review/1017035
2009-11-04 18:17:57 -08:00
Russ Cox
cc1a979272
package patch
...
R=r
http://go/go-review/1018043
2009-11-04 17:55:06 -08:00
Rob Pike
31053d4e47
add a final section with a complete example
...
R=rsc
CC=go-dev
http://go/go-review/1017033
2009-11-04 17:29:20 -08:00
Robert Griesemer
5fca0bca61
gofmt-ify compress
...
R=rsc
http://go/go-review/1016045
2009-11-04 17:10:18 -08:00
Robert Griesemer
b6d0a22dc5
gofmt-ify ebnf
...
R=r
http://go/go-review/1018050
2009-11-04 17:05:01 -08:00
Robert Griesemer
646a2c5a42
gofmt-ify bufio
...
R=rsc
http://go/go-review/1018049
2009-11-04 17:04:21 -08:00
Robert Griesemer
03678f7417
gofmt-ify asn1
...
R=rsc
http://go/go-review/1018047
2009-11-04 17:03:08 -08:00
Robert Griesemer
517ebbb24a
gofmt-ify src/pkg/archive
...
R=rsc
http://go/go-review/1018046
2009-11-04 17:02:47 -08:00
Robert Griesemer
eabcc981c5
gofmt-ify crypto
...
R=agl
CC=rsc
http://go/go-review/1017032
2009-11-04 17:02:30 -08:00
Robert Griesemer
2ce57ec10a
gofmt-ify src/pkg/go (excluding printer directory due to pending CL,
...
and parser.go and scanner_test.go which have minor formatting issues)
R=rsc
http://go/go-review/1016042
2009-11-04 17:02:05 -08:00
Robert Griesemer
26c3f6c18d
rename testfiles from .go -> .orig so that they won't be
...
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)
R=rsc
http://go/go-review/1018045
2009-11-04 16:50:13 -08:00
Robert Griesemer
688a6ff71d
gofmt-ify bytes
...
R=r
http://go/go-review/1016044
2009-11-04 16:49:28 -08:00
Robert Griesemer
789b31a416
better placement of /*-style comments interspersed with code on one line
...
R=rsc
http://go/go-review/1017030
2009-11-04 15:33:28 -08:00
Russ Cox
5d436b9def
bytes.SplitAfter and strings.SplitAfter
...
most common usage is:
lines := strings.SplitAfter(text, "\n", 0)
R=r
http://go/go-review/1018042
2009-11-04 15:19:30 -08:00
Russ Cox
3de3af512d
doc doc doc
...
R=r
http://go/go-review/1016039
2009-11-04 15:17:36 -08:00
Russ Cox
e414fda6d4
avoid infinite recursion in matcher.
...
after sync (or sync --local), clean up repository:
* look for and close CLs submitted on our behalf
* remove unmodified files from CLs
* warn about empty CLs
R=r
http://go/go-review/1017029
2009-11-04 15:17:01 -08:00
Rob Pike
56cba8855e
panic can't print interfaces well so use err.String()
...
R=rsc
http://go/go-review/1016041
2009-11-04 15:13:16 -08:00
Robert Griesemer
2f792d32be
- always format blocks with closing } on a new line, even if empty
...
- at the moment this also affects single-line function declarations
because we have disabled them at the moment (but not single-line
function literals)
R=rsc
http://go/go-review/1016040
2009-11-04 13:31:20 -08:00
Rob Pike
98ac4c6e65
stylistic issues in a couple of cmd docs
...
R=rsc
http://go/go-review/1017028
2009-11-04 13:13:17 -08:00
Rob Pike
0d3dd3c950
document godoc and gofmt
...
R=rsc
http://go/go-review/1018036
2009-11-04 11:33:43 -08:00
Robert Griesemer
4bb0271a12
remove reference to /home/r
...
R=rsc
http://go/go-review/1018039
2009-11-04 11:15:19 -08:00
Robert Griesemer
6dbf7aa129
- complete html-escaping also in printer.go
...
R=rsc
http://go/go-review/1017027
2009-11-04 10:59:25 -08:00
Robert Griesemer
c8c3f1d5de
- respect source line breaks in grouped declarations
...
- made ast.Spec nodes implement Node interface
- added extra test cases
R=rsc
http://go/go-review/1016038
2009-11-04 10:58:54 -08:00
Robert Griesemer
524ade9a58
fix bufio test case
...
R=rsc
http://go/go-review/1018038
2009-11-04 10:58:30 -08:00
Robert Griesemer
d06dc14aa8
remove "em" unit from td width specification
...
R=rsc
http://go/go-review/1018037
2009-11-04 10:58:13 -08:00
Russ Cox
d441d545a9
two more regexp tweaks
...
TBR=r
http://go/go-review/1016037
2009-11-04 08:34:31 -08:00
Russ Cox
af2bc8f986
allow "no such host" and also "no answer from server";
...
seems to help on snow leopard.
TBR=r
http://go/go-review/1018035
2009-11-04 08:30:53 -08:00
Russ Cox
506ce11f03
various tweaks to code review.
...
main one is to check at submit time that
user name being used in checkin message
is listed in the CONTRIBUTORS file.
this should catch misconfigurations.
another is to cut the @domain part
from the R= and CC= lines on checkin
messages, so that cc'ing someone on
a change does not mean their email
address is recorded for all time.
R=r
CC=go-dev
http://go/go-review/1016036
2009-11-04 03:15:24 -08:00
Rob Pike
56a38f25a7
document gotest
...
R=rsc
CC=go-dev
http://go/go-review/1017026
2009-11-03 23:06:16 -08:00
Robert Griesemer
467c726eec
add " and ' to list of html-escaped chars
...
R=rsc
http://go/go-review/1017025
2009-11-03 22:52:10 -08:00
Rob Pike
796e29ebfc
add goyacc to the build
...
R=rsc
CC=go-dev
http://go/go-review/1018034
2009-11-03 22:48:48 -08:00
Rob Pike
472576c615
make goyacc and units.y work again (minor tweaks).
...
document goyacc a little.
R=rsc
CC=go-dev
http://go/go-review/1017024
2009-11-03 22:38:43 -08:00
