3 Commits

Author	SHA1	Message	Date
Rebecca Stambler	0bb5a05de8	internal/lsp: use the AST to get correct ranges ... Fixes golang/go#29150 Change-Id: I0cb8be25f7f40f7f8becedf2e0002c58620c72da Reviewed-on: https://go-review.googlesource.com/c/tools/+/202542 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-10-22 16:21:03 +00:00
Rebecca Stambler	3057e18543	internal/lsp: move error range computations into cache package ... A continuation of CL 202298, only for analysis errors. Change-Id: I957d52cef31938ef66be73463e92695a5b56869c Reviewed-on: https://go-review.googlesource.com/c/tools/+/202540 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-10-21 22:12:58 +00:00
Rebecca Stambler	747b8b11d4	internal/lsp: refactor error handling code in type-checking ... This change adds a source.Error type which is used to collect the error information that comes out of the loading, parsing, and type checking stages. We also add specific sources per-error, rather than having them all be labeled as "LSP". This change will enable follow-ups that do a better job of extracting error ranges. Change-Id: I3fbb5e42d66aa2c5bb1b2f41d1eadfc45f3a749b Reviewed-on: https://go-review.googlesource.com/c/tools/+/202298 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>	2019-10-21 18:57:46 +00:00