3 Commits

Author	SHA1	Message	Date
Rohan Challa	7ebc6af015	internal/lsp: add diagnostic on import causing import cycle ... After the addition of golang/go#35964, the import cycle error now has the import stack attached in the message. This CL parses that stack and attached the import cycle diagnostic to the import versus just adding it to the first character of the .go file. Fixes golang/go#33085 Change-Id: I6f5f067c338879b898829951236f816aa63d9dfa Reviewed-on: https://go-review.googlesource.com/c/tools/+/210942 Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-12-13 19:54:01 +00:00
Rohan Challa	3785370768	internal/lsp: fix circular import errors to account for import stack ... Hotfix for broken tests after the import stack got added to the circular import error statement. Change-Id: I0179b9590cad38cf9cb903f9932d9bf8fb8dc6df Reviewed-on: https://go-review.googlesource.com/c/tools/+/210939 Run-TryBot: Rohan Challa <rohan@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>	2019-12-11 19:05:55 +00:00
Rohan Challa	cec958058c	internal/lsp: add error handling for self imports ... This change will provide a more useful error when you are self importing a package. It has TODOs in place to propagate the "import cycle not allowed" error from go list to the user. Updates golang/go#33085 Change-Id: Ia868a7c688b0f0a7a9689cfda5ea8cea8ae1faff Reviewed-on: https://go-review.googlesource.com/c/tools/+/209857 Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-12-06 19:13:54 +00:00