qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-20 08:44:39 -07:00
Code Releases Activity
4,112 Commits 58 Branches 402 Tags 522 MiB
b90c39beee
Commit Graph

71 Commits

Author SHA1 Message Date
Russ Cox
aae0aefb70 codereview: handle spaces and other unexpected chars in nicknames 
R=r
https://golang.org/cl/157053
 2009-11-17 16:52:36 -08:00
Rob Pike
c7ec6ef859 case insensitive matching in CONTRIBUTORS file 
R=rsc
https://golang.org/cl/157043
 2009-11-17 11:40:25 -08:00
Russ Cox
60df923916 codereview: discard \r characters (sigh) 
R=r
https://golang.org/cl/157041
 2009-11-17 09:08:54 -08:00
Russ Cox
1a2418f575 codereview: add clpatch --ignore_hgpatch_errors. 
of limited utility but good for creating the metadata
  for an AUTHORS/CONTRIBUTORS change even if
  the patch doesn't apply cleanly.

R=r
https://golang.org/cl/154140
 2009-11-17 08:47:48 -08:00
Devon H. O'Dell
152bfa03d8 Pass ui into PostMessage to avoid nasty/confusing exception 
R=rsc
https://golang.org/cl/155079
 2009-11-17 08:32:23 -08:00
Robert Griesemer
af872b2ba4 Add id attribute to h2 and h3 tags so that they exist when referring 
to generated pages even if Javascript has not introduced them yet.

R=rsc
https://golang.org/cl/154167
 2009-11-16 15:25:16 -08:00
Russ Cox
780dbdc024 codereview: clpatch tweaks 
R=agl1
https://golang.org/cl/152114
 2009-11-12 18:37:39 -08:00
Russ Cox
c8bb81fddc video is ready 
R=r
http://codereview.prom.corp.google.com/1024050
 2009-11-10 17:05:07 -08:00
Russ Cox
44fb865a48 default to codereview.appspot.com 
R=r
http://codereview.prom.corp.google.com/1026040
 2009-11-10 15:18:40 -08:00
Russ Cox
8a902ed840 video is coming soon 
R=r
http://go/go-review/1024049
 2009-11-10 14:47:23 -08:00
Russ Cox
78c47c36b2 update video links 
R=r
http://go/go-review/1024048
 2009-11-10 14:09:01 -08:00
Russ Cox
4414442442 remove internal references from doc/install.html 
and doc/contribute.html.

add #go-nuts to help section on nav bar.

R=r
http://go/go-review/1025035
 2009-11-10 09:37:03 -08:00
Robert Griesemer
a10e2051ae - add .. link to package directory listing, for easy traversal 
- matches style of source file directory listing

R=rsc
http://go/go-review/1024044
 2009-11-09 23:22:04 -08:00
Robert Griesemer
c110269579 cleanup style: 
- consistently remove all underbars from links
- this removes need for noline style
- removed unused info style

R=r, rsc
http://go/go-review/1025032
 2009-11-09 16:19:38 -08:00
Robert Griesemer
93c3f5124e make search box ever so slightly wider 
R=rsc
http://go/go-review/1024036
 2009-11-09 14:49:01 -08:00
Robert Griesemer
568c018fee make search box width dynamically sized 
R=rsc, agl
http://go/go-review/1024032
 2009-11-09 10:27:07 -08:00
Robert Griesemer
d731dc8e72 Addressing issue brought up by dsymonds: 
- When providing alternative spellings to a query, do not
  prefix it with a package qualifier as the suggestion may
  not have any results. Correctly filtering is quite a bit
  of work, and clicking the alternative spelling will always
  also show the qualified hits if they exist (but also others).
  Seems good enough for now.
- Give user feedback when the query syntax was wrong.
- Package names in search results are now links to the respective
  package documentation.
- Experimented with excluding main packages and test files
  from index with inconclusive results. Code is present and
  can be enabled by changing a flag in the source. This needs
  some more work.

R=rsc
CC=r, dsymonds
http://go/go-review/1026033
 2009-11-08 23:34:08 -08:00
Russ Cox
b1a52ce4a3 make hg mail more forgiving: 
create CL first, even if gofmt is needed
or no reviewers listed.

R=r
http://go/go-review/1025025
 2009-11-08 22:13:10 -08:00
Russ Cox
830813f019 assorted cleanup 
R=r, iant
CC=go-dev
http://go/go-review/1025024
 2009-11-08 21:08:27 -08:00
Robert Griesemer
7837dbfcb8 use grouping instead of colors to show non-global search hits: 
- introduced a new run per file containing all spots belonging
  to the same kind (e.g. var decl, const decl, etc.)
- more comments, better index.go file organization

R=rsc
http://go/go-review/1026028
 2009-11-08 20:17:04 -08:00
Robert Griesemer
202ede1240 - properly align package synopses 
(this was surprisingly hard to get right in HTML)
- show modification times in source directory listings
- various tweaks

R=rsc
http://go/go-review/1024024
 2009-11-08 16:47:32 -08:00
Russ Cox
826e10ce64 links to Go Nuts, issue tracker, 
source code browser on code.google.com
(where LICENSE file is visible)

R=r
http://go/go-review/1024023
 2009-11-08 09:50:16 -08:00
Russ Cox
aa2a9e4796 another attempt at utf-8 uploads. 
the last attempt broke uploads of binary files like .png

R=r
http://go/go-review/1026025
 2009-11-08 09:49:13 -08:00
Robert Griesemer
a011480ff3 TBR 
1st step of renaming dirList.html -> dirlist.html
(OS X filenames are not capitalization-sensitive)

R=rsc
http://go/go-review/1024021
 2009-11-08 00:51:08 -08:00
Robert Griesemer
5de21eb1e9 TBR 
step 2: adding renamed dirlist.html again

R=rsc
http://go/go-review/1024022
 2009-11-08 00:49:56 -08:00
Robert Griesemer
642caacfa3 - added link to sources 
- renamed listing.html -> dirList.html
  (there is a dirs.html already, it should probably have a better name, too)

R=rsc
http://go/go-review/1025020
 2009-11-07 21:24:48 -08:00
Robert Griesemer
171ef39949 nice directory listings 
R=rsc
http://go/go-review/1026020
 2009-11-07 21:12:46 -08:00
Russ Cox
e67161ee3f fix authentication in parallel LoadAllCL 
R=r
http://go/go-review/1024018
 2009-11-07 18:56:29 -08:00
Russ Cox
72a59cecb9 require Mercurial 1.3 again (how did that get dropped?) 
avoid deprecation warning about os.popen3

R=r
http://go/go-review/1026018
 2009-11-07 17:30:40 -08:00
Russ Cox
213bd39a3b fix a few style nits; arrange the doc list in 
an order we want people to read the docs.

R=r
CC=go-dev
http://go/go-review/1025017
 2009-11-07 16:46:49 -08:00
Robert Griesemer
1ac60ddd10 - support to extract one-line package synopsis for package listings 
- formatting in dirs.html is crude, needs better html (open to suggestions),
  but shows the synopsis
- many package comments should probably be adjusted such that the first
  sentence is more concise

R=rsc, iant
http://go/go-review/1025014
 2009-11-07 13:17:53 -08:00
Russ Cox
b94f8131ae new style; live at http://r45:3456/ 
R=r
CC=go-dev
http://go/go-review/1026015
 2009-11-07 12:11:28 -08:00
Russ Cox
f74beebb2f codereview: print gofmt message when aborting 
R=r
CC=vish
http://go/go-review/1026013
 2009-11-06 18:40:30 -08:00
Russ Cox
88e365ce79 make temporary google.com -> golang.org hack more sophisticated 
R=r
http://go/go-review/1024013
 2009-11-06 17:02:47 -08:00
Russ Cox
043486eb3e require gofmt for all $GOROOT/src/.../*.go. 
try harder to post messages to rietveld.

R=gri, r
CC=go-dev
http://go/go-review/1024006
 2009-11-06 09:45:24 -08:00
Russ Cox
f31bc223b3 fix UTF-8 upload bug 
TBR=r
http://go/go-review/1026001
 2009-11-05 18:23:26 -08:00
Russ Cox
790c9b59d6 codereview: new commands 
* clpatch
	* download
	* submit, on behalf of clpatch

stir hgpatch to fix a few bugs

R=r
CC=go-dev
http://go/go-review/1016051
 2009-11-05 14:44:57 -08:00
Rob Pike
f93ecca397 add a place-holder link for the hour-long video 
R=rsc
CC=go-dev
http://go/go-review/1017054
 2009-11-05 13:46:12 -08:00
Adam Langley
51c1bd229b godoc: style update. 
R=r, rsc
CC=go-dev
http://go/go-review/1017051
 2009-11-05 12:18:54 -08:00
Russ Cox
9df7d6ef10 add -l flag to hg gofmt. 
don't apply gofmt to non-go files during upload check.

R=r
http://go/go-review/1016048
 2009-11-05 08:11:44 -08:00
Russ Cox
d8e0d9a778 add "hg gofmt" to run all modified files through gofmt. 
add check before Upload, for now disabled by default,
that files do not change when run through gofmt.
enable by adding

	[codereview]
	force_gofmt = True

to .hgrc or .hg/hgrc.

add doc strings for a few more commands.
rename codereview-login to code-login
to make module doc visible.

R=r
CC=gri
http://go/go-review/1018056
 2009-11-04 23:43:55 -08:00
Russ Cox
e414fda6d4 avoid infinite recursion in matcher. 
after sync (or sync --local), clean up repository:
	* look for and close CLs submitted on our behalf
	* remove unmodified files from CLs
	* warn about empty CLs

R=r
http://go/go-review/1017029
 2009-11-04 15:17:01 -08:00
Robert Griesemer
d06dc14aa8 remove "em" unit from td width specification 
R=rsc
http://go/go-review/1018037
 2009-11-04 10:58:13 -08:00
Russ Cox
506ce11f03 various tweaks to code review. 
main one is to check at submit time that
user name being used in checkin message
is listed in the CONTRIBUTORS file.
this should catch misconfigurations.

another is to cut the @domain part
from the R= and CC= lines on checkin
messages, so that cc'ing someone on
a change does not mean their email
address is recorded for all time.

R=r
CC=go-dev
http://go/go-review/1016036
 2009-11-04 03:15:24 -08:00
Adam Langley
b9ec2adfc7 Update the styling of the godoc pages. 
(root.html is just temporary. It'll need some better content.)

R=r
CC=go-dev
http://go/go-review/1017019
 2009-11-03 19:59:45 -08:00
Robert Griesemer
4818d346b6 support for command documentation: 
- made package tree handler generic so it can work on any fs tree
- cleanups along the way

R=rsc
CC=r
http://go/go-review/1017020
 2009-11-03 19:40:26 -08:00
Robert Griesemer
be56b95770 - show recursive package directory structure in package pages 
- removed some underbars in section headings for better looks
- various minor tweaks

R=rsc
http://go/go-review/1018026
 2009-11-02 22:44:01 -08:00
Russ Cox
9c13215859 rietveld does not like code reviews with subjects longer than 100 characters, so trim the line pulled out of the description to avoid the limit. 
R=r
http://go/go-review/1016027
 2009-11-02 11:37:21 -08:00
Robert Griesemer
49d295d592 - initial steps towards showing directory tree instead of 
just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree

R=rsc
http://go/go-review/1018016
 2009-11-02 09:25:39 -08:00
Russ Cox
dde666dab5 code review: avoid subject changes, fix http_proxy submit bug 
R=r
http://go/go-review/1016021
 2009-11-01 18:46:07 -08:00