3 Commits

Author	SHA1	Message	Date
Dave Cheney	9fb96991e6	net: fix data races on deadline vars ... Fixes #4434. This proposal replaces the previous CL 6855110. Due to issue 599, 64-bit atomic operations should probably be avoided, so use a sync.Mutex instead. Benchmark comparisons against 025b9d070a85 on linux/386: CL 6855110: benchmark old ns/op new ns/op delta BenchmarkTCPOneShot 710024 727409 +2.45% BenchmarkTCPOneShotTimeout 758178 768620 +1.38% BenchmarkTCPPersistent 223464 228058 +2.06% BenchmarkTCPPersistentTimeout 234494 242600 +3.46% This proposal: benchmark old ns/op new ns/op delta BenchmarkTCPOneShot 710024 718492 +1.19% BenchmarkTCPOneShotTimeout 758178 748783 -1.24% BenchmarkTCPPersistent 223464 227628 +1.86% BenchmarkTCPPersistentTimeout 234494 238321 +1.63% R=rsc, dvyukov, mikioh.mikioh, alex.brainman, bradfitz CC=golang-dev, remyoudompheng https://golang.org/cl/6866050	2012-12-05 15:59:01 +11:00
Dave Cheney	5b425cc3ab	undo CL 6855110 / 869253ef7009 ... 64bit atomics are broken on 32bit systems. This is issue 599. linux/arm builders all broke with this change, I am concerned that the other 32bit builders are silently impacted. ««« original CL description net: fix data races on deadline vars Fixes #4434. R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman CC=golang-dev https://golang.org/cl/6855110 »»» R=rsc, mikioh.mikioh, dvyukov, minux.ma CC=golang-dev https://golang.org/cl/6852105	2012-11-30 20:02:30 +11:00
Dave Cheney	be0d84e335	net: fix data races on deadline vars ... Fixes #4434. R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman CC=golang-dev https://golang.org/cl/6855110	2012-11-30 18:26:51 +11:00