qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 08:30:05 -07:00
Code Releases Activity
9,854 Commits 58 Branches 402 Tags 522 MiB
a2846e65dc
Commit Graph

2599 Commits

Author SHA1 Message Date
Russ Cox
a809abafa5 govet: automate test 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4629084
 2011-06-30 10:26:11 -04:00
Julian Phillips
8ffbc4016a goinstall: Add support for generic hosts using special import form 
This change extends goinstall to support "magic" package names of the
form:
        <host>/<repo>.<vcs>/<path>

Where <host> is the hostname, <repo> the path to the repository, <vcs>
the type of vcs (git, hg, bzr or svn), and <path> is the path inside the
repository that contains the source code for the package.

For example: "example.com/pub/foo.hg/src" means download the Mercurial
repository at either pub/foo.hg or pub/foo from example.com and then
build and install the source files from src inside the repository
checkout.

Repositories on the built-in hostings sites (github, bitbucket,
launchpad and googlecode) must still use the old form (i.e.
github.com/xxx/yyy.git/src will be rejected).

R=adg, rsc
CC=golang-dev
https://golang.org/cl/4626064
 2011-06-30 18:54:53 +10:00
Russ Cox
25733a94fd reflect: support for struct tag use by multiple packages 
Each package using struct field tags assumes that
it is the only package storing data in the tag.
This CL adds support in package reflect for sharing
tags between multiple packages.  In this scheme, the
tags must be of the form

        key:"value" key2:"value2"

(raw strings help when writing that tag in Go source).

reflect.StructField's Tag field now has type StructTag
(a string type), which has method Get(key string) string
that returns the associated value.

Clients of json and xml will need to be updated.
Code that says

        type T struct {
                X int "name"
        }

should become

        type T struct {
                X int `json:"name"`  // or `xml:"name"`
        }

Use govet to identify struct tags that need to be changed
to use the new syntax.

R=r, r, dsymonds, bradfitz, kevlar, fvbommel, n13m3y3r
CC=golang-dev
https://golang.org/cl/4645069
 2011-06-29 09:52:34 -04:00
Robert Hencke
83550f0728 gofix: fixes for os/signal changes 
Fixes #1971.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/4630056
 2011-06-29 16:44:47 +10:00
Russ Cox
ff4518da17 gc: fix package quoting logic 
The decision for when to say "hash/crc32".New instead of
crc32.New in an error was double-counting imports
from different packages or indirect imports, so it was
quoting even when there was no ambiguity.

R=ken2
CC=golang-dev
https://golang.org/cl/4645070
 2011-06-28 23:58:35 -04:00
Gustavo Niemeyer
cf143e9dbf ld: fix ELF strip by removing overlap of sections 
The gosymtab and gopclntab sections were pointing to the proper
data, but that data was already owned by the rodata section.
Some ELF references explicitly prohibit multiple sections from
owning the same data, and strip behaves accordingly.

The data for these sections was moved to after rodata, and the
gosymtab and gopclntab sections now own their respective ranges.

This change makes strip happy both with and without -s being
provided at link time.  Note that it won't remove these sections
because they are still allocated, and that's by design since
they are necessary at runtime for generating proper backtraces
and similar introspection operations.

Unlike the previous behavior, -s will now maintain zero-sized
gosymtab and gopclntab sections.  This makes the implementation
slightly cleaner.

Fixes #1242.

NOTE: Tested on Linux amd64/386/arm only.

R=ality, rsc
CC=golang-dev
https://golang.org/cl/4639077
 2011-06-28 22:28:30 +01:00
Russ Cox
d0ac84fe40 cc: broken return is an error, not a warning 
R=ken2
CC=golang-dev
https://golang.org/cl/4626081
 2011-06-28 16:00:55 -04:00
Russ Cox
fe2ccb53c0 cc: add two new #pragma varargck 
#pragma varargck countpos f 1
says that the first argument to f is
the count of variadic arguments that follow.

#pragma varargck type f t
says that t is one of the allowed types for
a variadic argument to f.
(can be repeated)

combined, these can be used to check the
runtime.stdcall functions in the windows port
or in any other port that needs a vararg list of
uintptrs even on a 64-bit platform (where it is
very easy to pass a less-than-uintptr in the ...).

demo:

typedef unsigned int uintptr;

#pragma varargck countpos f 1
#pragma varargck type f uintptr
#pragma varargck type f void*

int f(int count, ...);

void *v;
char *p;

void
main(void)
{
        f(1, v);  // ok
        f(1, main);  // ok
        f(1, p);  // ok
        f(2, v, v);  // ok

        f(2, v);  // found 1 argument after count 2
        f(1, 'a');  // invalid type INT in call to f
        f(1, 0);  // invalid type INT in call to f
}

R=ken, r, alex.brainman
CC=golang-dev
https://golang.org/cl/4634103
 2011-06-27 22:42:34 -04:00
Rob Pike
ebb1566a46 strings.Split: make the default to split all. 
Change the signature of Split to have no count,
assuming a full split, and rename the existing
Split with a count to SplitN.
Do the same to package bytes.
Add a gofix module.

R=adg, dsymonds, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/4661051
 2011-06-28 09:43:14 +10:00
Russ Cox
6aaa86ff66 gc: avoid package name ambiguity in error messages 
Fixes #2006.

R=ken2
CC=golang-dev
https://golang.org/cl/4643056
 2011-06-27 18:44:30 -04:00
Brad Fitzpatrick
19f795042a http: add FileSystem interface, make FileServer use it 
Permits serving from virtual filesystems, such as files linked
into a binary, or from a zip file.

Also adds a gofix for:

http.FileServer(root, prefix) -> http.StripPrefix(prefix, http.FileServer(http.Dir(root)))

R=r, rsc, gri, adg, dsymonds, r, gri
CC=golang-dev
https://golang.org/cl/4629047
 2011-06-27 15:26:36 -07:00
Lucio De Re
6bcfb95168 8a: fixes for Plan 9 build 
8a/a.h:
. Removed <u.h> and <libc.h> includes as they work better in "a.y".
. Made definition of EOF conditional as it's defined in the Plan 9
  header files, but not elsewhere.

8a/a.y:
. Added <u.h> and <libc.h> because <stdio.h> in Plan 9 needs them.
  Sequence <u.h>, <stdio.h>, <libc.h> recommended by RSC.

8a/lex.c:
. Added <u.h> and <libc.h> as now needed by "a.h".
. Dropped <ctype.h>.

cc/lexbody:
. exit() -> exits().
. Dropped unwanted incrementation.

cc/macbody:
. Adjusted a few format specifications.

R=rsc
CC=golang-dev
https://golang.org/cl/4644047
 2011-06-27 14:42:18 -04:00
Anthony Martin
10d0dffd76 ld: elide the Go symbol table when using -s 
R=rsc, n13m3y3r, gustavo
CC=golang-dev
https://golang.org/cl/4661050
 2011-06-27 14:39:38 -04:00
Dmitriy Vyukov
9843ca5e2b gotest: add -test.benchtime and -test.cpu flags. 
-test.benchtime allows to specify benchmark execution time.
-test.cpu allows to execute tests/benchmarks for several
values of GOMAXPROCS.

R=r, r, rsc
CC=golang-dev
https://golang.org/cl/4662046
 2011-06-27 13:31:40 -04:00
Russ Cox
9dd354c63f 5l, 6l, 8l: drop use of ed during build 
build runs with chmod 0 /bin/ed now

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4635071
 2011-06-27 12:03:19 -04:00
Robert Hencke
da19831c17 gofix: fixes for path/filepath changes 
Fixes #1970.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4650050
 2011-06-26 11:24:28 +10:00
Robert Hencke
69905c6213 gofix: fixes for sort changes 
Fixes #1969.

R=gri, rsc, r
CC=golang-dev
https://golang.org/cl/4634076
 2011-06-26 08:48:53 +10:00
Robert Griesemer
f70e8ed0f3 ebnflint: better handling of stdin 
- don't rely on /dev/stdin as the name for standard input
- employ EBNF extraction if the source contains tags

"cat source.html | ebnflint" works now

R=r
CC=golang-dev
https://golang.org/cl/4641075
 2011-06-24 17:29:19 -07:00
Andrew Gerrand
b4bab6f8b3 goinstall: build with make by default, add -make flag 
This is a temporary measure until go/build can build cgo packages.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4627056
 2011-06-24 13:01:17 +10:00
Russ Cox
c475c3071a 5c: do not use R9 and R10 
This program used to use R9 and R10.
Now it fails to compile (out of registers).
I used to know a simpler test but can't remember it.

Learned something new: Rietveld refuses change
list descriptions bigger than 10 kB.

int sum(int x, int y, int z, int w) {
        return
        (((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))))*
        ((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))))*
        (((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))))*
        ((((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))%
        (((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))))/
        ((((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))|
        (((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w))&
        ((x*y+z*w|x*y+z*w)^
        (x*y+z*w|x*y+z*w)))))))
        ;
}

R=ken2
CC=golang-dev
https://golang.org/cl/4650053
 2011-06-22 23:22:36 -04:00
Gustavo Niemeyer
89d334ffe1 ld: don't attempt to build dynamic sections unnecessarily 
This prevents ld from generating zeroed symtab entries for
sections that aren't going to be generated because dynamic
linkage has been disabled (-d was used or no dynamic libs
were seen).  Even though they were not explicitly added by
doelf, the section creation process was making them
reachable again.

The windows head is being disconsidered for this because
apparently it's not taking into account debug['d'].

This makes elflint 0.1% happier.

R=golang-dev, rsc, gustavo
CC=golang-dev
https://golang.org/cl/4638050
 2011-06-22 15:12:22 -04:00
Robert Griesemer
712fb6dcd3 os.Error API: don't export os.ErrorString, use os.NewError consistently 
This is a core API change.

1) gofix misc src
2) Manual adjustments to the following files under src/pkg:
   gob/decode.go
   rpc/client.go
   os/error.go
   io/io.go
   bufio/bufio.go
   http/request.go
   websocket/client.go
as well as:
   src/cmd/gofix/testdata/*.go.in (reverted)
   test/fixedbugs/bug243.go
3) Implemented gofix patch (oserrorstring.go) and test case (oserrorstring_test.go)

Compiles and runs all tests.

R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/4607052
 2011-06-22 10:52:47 -07:00
Lucio De Re
10b5519d3a 8l: more fixes for Plan 9 
Once these changes are effected, it is possible to construct
"8l" native on a (386?) Plan 9 system, albeit with assistance
from modules such as mkfiles that are not (yet) included in any
public patches.

8l/asm.c:
. Corrected some format qualifiers.

8l/list.c:
. Cast a print() argument to (int) to match the given format.
  It may be possible to change the format (%R), but I have not
  looked into it.

8l/obj.c:
. Removed some unused code.

8l/span.c:
. Removed unnecessary incrementation on "bp".
. Corrected some format qualifiers.

ld/data.c:
. Corrected some format qualifiers.
. Cast print argument to (int): used as field size.
. Use braces to suppress warning about empty if() statements.

ld/dwarf.c:
. Trivial spelling mistake in comment.

ld/ldelf.c:
. Added USED() statements to silence warnings.
. Dropped redundant address (&) operators.
. corrected some format qualifiers.
. Cast to (int) for switch selection variable.

ld/macho.c:
. Added USED() statements to silence warnings.

ld/ldpe.c:
. Added USED() statements to silence warnings.
. More careful use of "sect" variable.
. Corrected some format qualifiers.
. Removed redundant assignments.
. Minor fix dropped as it was submitted separately.

ld/pe.c:
. Dropped <time.h> which is now in <u.h>.
. Dropped redundant address (&) operators.
. Added a missing variable initialisation.

ld/symtab.c:
. Added USED() statements to silence warnings.
. Removed redundant incrementation.
. Corrected some format qualifiers.

All the above have been tested against a (very) recent release
and do not seem to trigger any regressions.

All review suggestions have been incorporated.

R=rsc
CC=golang-dev
https://golang.org/cl/4633043
 2011-06-21 12:14:32 -04:00
Robert Hencke
b88e669a8f nacl, tiny: remove vestiges 
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/4635053
 2011-06-21 12:02:40 -04:00
Russ Cox
d6be71c788 gopprof: update list of memory allocators 
Also import new weblist command from Google version.

R=r, bradfitz
CC=golang-dev
https://golang.org/cl/4650048
 2011-06-21 11:27:08 -04:00
Andrew Gerrand
f338d9f73b goinstall: undo 1ad616fb313d (always rebuild...) 
CL 4627051 is a better way of doing the same thing.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4654045
 2011-06-21 17:13:16 +10:00
Andrew Gerrand
ceae2c9301 goinstall: undo repo peeking code 
Keeping the Julian's good refactoring work.

R=rsc
CC=golang-dev
https://golang.org/cl/4638049
 2011-06-21 11:28:15 +10:00
Anthony Martin
028f74f827 5g, 6g, 8g: fix comments in method call generation 
R=golang-dev
CC=golang-dev
https://golang.org/cl/4652042
 2011-06-20 14:49:29 -04:00
Anthony Martin
12b2269860 5g, 5l: fix more set but not used warnings 
These are present when building with gcc 4.6.

R=golang-dev, dave
CC=golang-dev, lvd
https://golang.org/cl/4636047
 2011-06-20 14:18:04 -04:00
Andrew Gerrand
f22e5cfc6d goinstall: update doc.go 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4645048
 2011-06-20 16:39:16 +10:00
Andrew Gerrand
f3a7dad654 goinstall: s/vlogf/printf/ 
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4628050
 2011-06-20 14:44:14 +10:00
Andrew Gerrand
e068b85bea goinstall: wait for all commands to finish instead of timeout 
goinstall: make ".git" repo suffix optional

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/4643048
 2011-06-20 14:12:23 +10:00
Julian Phillips
c319fb07bc goinstall: Add support for arbitary code repositories 
Extend goinstall to support downloading from any hg/git/svn/bzr hosting
site, not just the standard ones.  The type of hosting is automatically
checked by trying all the tools, so the import statement looks like:

  import "example.com/mything"

Which will work for Mercurial (http), Subversion (http, svn), Git (http,
git) and Bazaar (http, bzr) hosting.

All the existing package imports will work through this new mechanism,
but the existing hard-coded host support is left in place to ensure
there is no change in behaviour.

R=golang-dev, bradfitz, fvbommel, go.peter.90, n13m3y3r, adg, duperray.olivier
CC=golang-dev
https://golang.org/cl/4650043
 2011-06-20 13:00:43 +10:00
Robert Hencke
a5b5e2b79e godefs: rudimentary tests 
currently only defined for darwin

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4528123
 2011-06-20 11:54:07 +10:00
Rob Pike
783c46b197 8a: delete dreg l.s 
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4631053
 2011-06-20 11:53:41 +10:00
Dave Cheney
cbb2d8e20e cc: nit: silence comment warnings 
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/4648043
 2011-06-19 13:58:08 +10:00
Joe Poirier
26b6a97c15 Make.ccmd: link with mach lib, 
remove explicit linking in make files

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4629051
 2011-06-19 13:57:22 +10:00
Andrew Gerrand
c967ba0210 goinstall: always rebuild a package after its dependencies are built 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4627047
 2011-06-19 09:36:45 +10:00
Russ Cox
cf9f380499 gc: unsafe.Alignof, unsafe.Offsetof, unsafe.Sizeof now return uintptr 
R=ken2
CC=golang-dev
https://golang.org/cl/4640045
 2011-06-17 16:12:14 -04:00
Russ Cox
b96ff8458c 5g, 8g: fix build 
R=ken2
CC=golang-dev
https://golang.org/cl/4627045
 2011-06-17 16:05:00 -04:00
Russ Cox
7f4c5ea7d8 gc: implement goto restriction 
Remove now-unnecessary zeroing of stack frames.

R=ken2
CC=golang-dev
https://golang.org/cl/4641044
 2011-06-17 15:25:05 -04:00
Russ Cox
e852202f37 gc: descriptive panic for nil pointer -> value method call 
R=ken2
CC=golang-dev
https://golang.org/cl/4646042
 2011-06-17 15:23:27 -04:00
Russ Cox
21e75da486 respect goto restrictions 
R=gri
CC=golang-dev
https://golang.org/cl/4625044
 2011-06-17 06:07:13 -04:00
Alex Brainman
eaa082f691 8l: minor fix discovered by lucio 
R=lucio.dere, vcc.163, bradfitz
CC=golang-dev
https://golang.org/cl/4645044
 2011-06-17 15:55:54 +10:00
Andrew Gerrand
4340b57d88 goinstall, go/build: support building cgo packages 
Fixes #1962.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4636044
 2011-06-17 11:15:54 +10:00
Alex Brainman
c562fbc44e cgo: make file path work for windows 
R=golang-dev, mattn.jp, adg
CC=golang-dev
https://golang.org/cl/4634043
 2011-06-17 10:17:33 +10:00
Brad Fitzpatrick
6e9b1a78ff http: make Headers be source of truth 
Previously Request and Response had redundant fields for
Referer, UserAgent, and cookies which caused confusion and
bugs.  It also didn't allow us to expand the package over
time, since the way to access fields would be in the Headers
one day and promoted to a field the next day.  That would be
hard to gofix, especially with code ranging over Headers.

After a discussion on the mail package's design with a similar
problem, we've designed to make the Headers be the source of
truth and add accessors instead.

Request:
change: Referer -> Referer()
change: UserAgent -> UserAgent()
change: Cookie -> Cookies()
new: Cookie(name) *Cookie
new: AddCookie(*Cookie)

Response:
change: Cookie -> Cookies()

Cookie:
new: String() string

R=rsc
CC=golang-dev
https://golang.org/cl/4620049
 2011-06-16 13:02:28 -07:00
Russ Cox
5a5a7b5163 6g, 8g: fix goto fix 
R=ken2
CC=golang-dev
https://golang.org/cl/4632041
 2011-06-16 01:25:49 -04:00
Russ Cox
5d9dbe19a7 gc: work around goto bug 
R=ken2
CC=golang-dev
https://golang.org/cl/4629042
 2011-06-16 00:18:43 -04:00
Robert Griesemer
fb9ea79916 godoc: replace direct OS file system accesses in favor 
of accesses via a FileSystem interface.

Preparation for appengine version which gets its files
via a snapshot or zip file and uses a corresponding
FileSystem implementation.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4572065
 2011-06-15 14:06:35 -07:00
Scott Lawrence
bee3b0358c gofix: Fix inconsistent indentation in help output 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4572066
 2011-06-15 21:07:21 +10:00
Andrew Gerrand
db5a4ffc2a goinstall: use go/make package to scan and build packages 
R=rsc, n13m3y3r, kevlar
CC=golang-dev
https://golang.org/cl/4515180
 2011-06-15 13:28:35 +10:00
Lucio De Re
340251e43d build: fix header files for Plan 9 
The "elf.h" header changes involve only comments, the released
Plan 9 C preprocessing function does not cope with multiline
comments following the #define keyword.  All multiline comments
have been moved to the line above the associated definition.
Sigh!  Fixing the Plan 9 compiler is not an option.

<time.h> does not exist in the Plan 9 Native library.  I have
moved it from src/cmd/ld/pe.h to include/u.h. RSC correctly points
out that this copy of <u.h> is not the one used to compile the
Go release on Plan 9 platforms.

R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/4574042
 2011-06-14 14:14:11 -04:00
Gustavo Niemeyer
a84e9d01f0 ld: make .rodata section read-only 
Fixes the respective warning from elflint.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4607048
 2011-06-14 15:13:54 -03:00
Wei Guangjing
9e2ffc315f ld: fix link Windows PE __declspec(dllimport) symbol 
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4568077
 2011-06-14 11:05:59 -04:00
Luuk van Dijk
2ad42a8249 gc: frame compaction for arm. 
Required moving some parts of gc/pgen.c to ?g/ggen.c

on linux tests pass for all 3 architectures, and
frames are actually compacted (diagnostic code for
that has been removed from the CL).

R=rsc
CC=golang-dev
https://golang.org/cl/4571071
 2011-06-14 17:03:37 +02:00
Russ Cox
9968090ddd cgo: handle new Apple LLVM-based gcc from Xcode 4.2 
That gcc does not include enumerator names and values
in its DWARF debug output.  Create a data block from which
we can read the values instead.

Fixes #1881.

R=iant
CC=golang-dev
https://golang.org/cl/4607045
 2011-06-13 14:43:54 -04:00
Luuk van Dijk
d164b6081d ld: dwarf emit filenames in debug_line header instead of as extended opcodes. 
Makes it possible for older tools like objdump to find the filenames,
fixes  objdump -d -l --start-address=0x400c00 --stop-address=0x400c36 6.out
fixes #1950

R=rsc
CC=golang-dev
https://golang.org/cl/4609043
 2011-06-13 16:56:43 +02:00
Stephen Ma
b4bb970e18 gc: handle go print() and go println() 
Fixes #1952.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4611041
 2011-06-13 22:50:51 +10:00
Dave Cheney
86183e43c9 gopack: make unused page function a fatal error 
R=iant, rsc
CC=golang-dev
https://golang.org/cl/4601051
 2011-06-09 22:41:19 -04:00
Dave Cheney
aac6afbb11 gopack: remove warning from the use of mktemp 
gcc-4.6 considers mktemp to be racey

R=golang-dev, rsc, iant
CC=golang-dev
https://golang.org/cl/4602050
 2011-06-09 18:04:26 -07:00
Russ Cox
1fddbab736 5l: fix softfloat nits 
Need to load math.a so that sqrtGoC is available.
Also was missing prototype.

R=ken2
CC=golang-dev
https://golang.org/cl/4517148
 2011-06-09 18:38:25 -04:00
Russ Cox
900c5fa98e gc: compactframe breaks arm - fix build 
R=lvd
CC=golang-dev
https://golang.org/cl/4591063
 2011-06-09 18:28:27 -04:00
Luuk van Dijk
fd2e24727e gc: nit 
R=rsc
CC=golang-dev
https://golang.org/cl/4604041
 2011-06-10 00:08:57 +02:00
Russ Cox
3e57d7f7bf 5l: delete dead code 
Thumb code and ARM pre-V4 code is unused,
unmaintained, and almost certainly wrong by now.
Every time I try to change 5l I have to sort out
what's dead code and what's not.

30% of lines of code in this directory deleted.

R=ken2
CC=golang-dev
https://golang.org/cl/4601049
 2011-06-09 18:07:56 -04:00
Luuk van Dijk
2ac375b2df gc: compact stackframe 
After allocparams and walk, remove unused auto variables
and re-layout the remaining in reverse alignment order.

R=rsc
CC=golang-dev
https://golang.org/cl/4568068
 2011-06-10 00:02:34 +02:00
Fan Hongjian
fc41e621e8 math: add sqrt_arm.s and sqrtGoC.go as fallback to soft fp emulation 
5a: add SQRTF and SQRTD
5l: add ASQRTF and ASQRTD

Use ARMv7 VFP VSQRT instruction to speed up math.Sqrt

R=rsc, dave, m
CC=golang-dev
https://golang.org/cl/4551082
 2011-06-09 17:19:08 -04:00
Russ Cox
17ca32e9db gc: nits 
R=ken2
CC=golang-dev
https://golang.org/cl/4572052
 2011-06-09 11:44:28 -04:00
Robert Griesemer
013cfea362 gofmt: update test script so that it passes again 
(TODO: should replace this with a Go program, eventually)

R=bradfitz
CC=golang-dev
https://golang.org/cl/4584047
 2011-06-08 12:05:40 -07:00
Robert Griesemer
a609a6bb63 ebnf: follow EBNF for EBNF faithfully 
Apply analogous changes in godoc/spec.go.

Fixes #1829.

R=nmessenger, r
CC=golang-dev
https://golang.org/cl/4528127
 2011-06-08 09:10:30 -07:00
Dave Cheney
6998ea2982 gc: alternative clang compatible abort. 
Tested on clang 2.9/amd64

R=rsc, jeff, r
CC=golang-dev
https://golang.org/cl/4517143
 2011-06-08 10:46:15 +10:00
Brad Fitzpatrick
be48115f48 gofix: fix diff regression from exec change 
Also pass -u to diff to be consistent with gofmt.

Fixes #1619

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4591041
 2011-06-07 11:53:47 -07:00
Robert Hencke
8cd7aac223 godefs: do not assume forward type references are enums 
Fixes #1466.

R=mikioh.mikioh, rsc
CC=golang-dev
https://golang.org/cl/4564043
 2011-06-07 14:28:10 -04:00
Anthony Martin
c5030e5f4b ld: fix and simplify ELF symbol generation 
I started looking at this code because the nm in GNU
binutils was ignoring the first symbol in the .symtab
section.  Apparently, the System V ABI reserves the
first entry and requires all fields inside to be set
to zero.

The list of changes is as follows:

  · reserve the first symbol entry (as noted above)
  · fix the section indices for .data and .bss symbols
  · factor out common code for Elf32 and Elf64
  · remove the special case for elfsymo in [568]l/asm.c:/^asmb
  · add the "etext" symbol in 6l
  · add static symbols

R=rsc
CC=golang-dev
https://golang.org/cl/4524075
 2011-06-07 14:26:16 -04:00
Caine Tighe
7c19d88b0f gc/lex.c: fix formatting of #include statement 
R=rsc, gri
CC=golang-dev
https://golang.org/cl/4564048
 2011-06-07 09:57:26 -07:00
Brad Fitzpatrick
687102ed4f gofmt: fix -d regression from exec change 
Fixes #1916

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4590041
 2011-06-07 09:38:04 -07:00
Dave Cheney
4881e7744a cgo: support non intel gcc machine flags 
R=adg
CC=golang-dev
https://golang.org/cl/4528124
 2011-06-07 16:59:35 +10:00
Dave Cheney
60a4b5e4db gc: enable building under clang/2.9 
To build under clang, pass the path to clang in CC when
calling ./make.bash

CC=/opt/llvm/llvm-2.9/bin/clang ./make.bash

Credit goes to jmhodges for suggestions.

R=jeff, r, ality
CC=golang-dev
https://golang.org/cl/4527098
 2011-06-06 19:53:44 +10:00
Russ Cox
84f291b1bd 8g: compute register liveness during regopt 
Input code like

0000 (x.go:2) TEXT    main+0(SB),$36-0
0001 (x.go:3) MOVL    $5,i+-8(SP)
0002 (x.go:3) MOVL    $0,i+-4(SP)
0003 (x.go:4) MOVL    $1,BX
0004 (x.go:4) MOVL    i+-8(SP),AX
0005 (x.go:4) MOVL    i+-4(SP),DX
0006 (x.go:4) MOVL    AX,autotmp_0000+-20(SP)
0007 (x.go:4) MOVL    DX,autotmp_0000+-16(SP)
0008 (x.go:4) MOVL    autotmp_0000+-20(SP),CX
0009 (x.go:4) CMPL    autotmp_0000+-16(SP),$0
0010 (x.go:4) JNE     ,13
0011 (x.go:4) CMPL    CX,$32
0012 (x.go:4) JCS     ,14
0013 (x.go:4) MOVL    $0,BX
0014 (x.go:4) SHLL    CX,BX
0015 (x.go:4) MOVL    BX,x+-12(SP)
0016 (x.go:5) MOVL    x+-12(SP),AX
0017 (x.go:5) CDQ     ,
0018 (x.go:5) MOVL    AX,autotmp_0001+-28(SP)
0019 (x.go:5) MOVL    DX,autotmp_0001+-24(SP)
0020 (x.go:5) MOVL    autotmp_0001+-28(SP),AX
0021 (x.go:5) MOVL    autotmp_0001+-24(SP),DX
0022 (x.go:5) MOVL    AX,(SP)
0023 (x.go:5) MOVL    DX,4(SP)
0024 (x.go:5) CALL    ,runtime.printint+0(SB)
0025 (x.go:5) CALL    ,runtime.printnl+0(SB)
0026 (x.go:6) RET     ,

is problematic because the liveness range for
autotmp_0000 (0006-0009) is nested completely
inside a span where BX holds a live value (0003-0015).
Because the register allocator only looks at 0006-0009
to see which registers are used, it misses the fact that
BX is unavailable and uses it anyway.

The n->pun = anyregalloc() check in tempname is
a workaround for this bug, but I hit it again because
I did the tempname call before allocating BX, even
though I then used the temporary after storing in BX.
This should fix the real bug, and then we can remove
the workaround in tempname.

The code creates pseudo-variables for each register
and includes that information in the liveness propagation.
Then the regu fields can be populated using that more
complete information.  With that approach, BX is marked
as in use on every line in the whole span 0003-0015,
so that the decision about autotmp_0000
(using only 0006-0009) still has all the information
it needs.

This is not specific to the 386, but it only happens in
generated code of the form

        load R1
        ...
        load var into R2
        ...
        store R2 back into var
        ...
        use R1

and for the most part the other compilers generate
the loads for a given compiled line before any of
the stores.  Even so, this may not be the case everywhere,
so the change is worth making in all three.

R=ken2, ken, ken
CC=golang-dev
https://golang.org/cl/4529106
 2011-06-03 14:10:39 -04:00
Lucio De Re
9baaa6f742 8l, ld: Initial adjustments for Plan 9 native compilation of 8l 
These changes are not particularly invasive and have been tested
as broadly as possible.

8l/l.h:
  -	#pragma varargck: added some, removed duplicates.

ld/dwarf.c:
  -	As Plan 9 has no NULL, changed all occurrences to nil.
  -	Added USED(size); where necessary.
  -	Added (void) argument in definition of finddebugruntimepath().
  -	Plan 9 compiler was complaining about multiple
        assignments, repeaired by breaking up the commands.
  -	Correction: havedynamic = 1; restored.

ld/go.c:
  -	Needed USED(file); in two functions.
  -	Removed unused assignments flagged by the Plan 9 compiler.

ld/lib.c:
  -	Replaced unlink() with remove() which seems available everywhere.
  -	Removed USED(c4); and USED(magic) no longer required.
  -	Removed code flagged as unused by the Plan 9 compiler.
  -	Added attributes to a number of format strings.

R=rsc
CC=golang-dev
https://golang.org/cl/4435047
 2011-06-03 13:20:31 -04:00
Luuk van Dijk
ab8ed7f8dd gc: renamed walkdef to typecheckdef and moved from walk to typedef. 
also inlined a typechecking function in dcl away.

R=rsc
CC=golang-dev
https://golang.org/cl/4550115
 2011-06-03 17:44:02 +02:00
Luuk van Dijk
56668283f1 gc: allow tags on parameters in export section of object files. 
This is in preparation of escape analysis; function parameters
can now be tagged with interesting bits by the compiler by
assigning to n->note.

tested by having typecheck put a fake tag on all parameters of
pointer type and compiling the tree.

R=rsc
CC=golang-dev
https://golang.org/cl/4524092
 2011-06-03 03:54:56 +02:00
Luuk van Dijk
e59aa8ea4a gc: typecheck the whole tree before walking. preparation for some escape-analysis related changes. 
R=rsc
CC=golang-dev
https://golang.org/cl/4528116
 2011-06-02 18:48:17 +02:00
Brad Fitzpatrick
f259f6ba0a exec: new API, replace Run with Command 
This removes exec.Run and replaces exec.Cmd with a
new implementation. The new exec.Cmd represents
both a currently-running command and also a command
being prepared. It has a good zero value.

You can Start + Wait on a Cmd, or simply Run it.
Start (and Run) deal with copying stdout, stdin,
and stderr between the Cmd's io.Readers and
io.Writers.

There are convenience methods to capture a command's
stdout and/or stderr.

R=r, n13m3y3r, rsc, gustavo, alex.brainman, dsymonds, r, adg, duzy.chan, mike.rosset, kevlar
CC=golang-dev
https://golang.org/cl/4552052
 2011-06-01 15:26:53 -07:00
Luuk van Dijk
2c4edb0eea gc: make merely referencing an outer variable in a closure not force heapallocation. 
before: runtime_test.BenchmarkCallClosure1       20000000              135 ns/op
after:  runtime_test.BenchmarkCallClosure1      500000000                6 ns/op

R=rsc
CC=golang-dev
https://golang.org/cl/4527091
 2011-06-01 17:02:43 +02:00
Rob Pike
73d57642a4 filepath: remove string constants. They are unnecessary. 
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4527090
 2011-06-01 13:06:04 +10:00
Andrew Gerrand
581bd378ec gobuilder: include file missing from change, fix build 
R=golang-dev
CC=golang-dev
https://golang.org/cl/4539099
 2011-06-01 11:56:46 +10:00
Andrew Gerrand
9f0cabfab9 goinstall: document GOPATH and support relative/absolute installs 
goinstall: more verbose logging with -v

Fixes #1901.

R=rsc, n13m3y3r
CC=golang-dev
https://golang.org/cl/4524078
 2011-06-01 10:48:15 +10:00
Russ Cox
15dcdf751c gc: fix m[x], _ = y.(T) 
Fixes #1900.

R=ken2
CC=golang-dev
https://golang.org/cl/4561053
 2011-05-31 15:52:04 -04:00
Anthony Martin
5b62ba14c4 gc: disallow ... in type conversions 
Fixes #1866.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4548073
 2011-05-31 15:41:47 -04:00
Russ Cox
5ab096d030 gc: implement new shift rules 
The change is that 1.0<<2 is now okay.

R=ken2
CC=golang-dev
https://golang.org/cl/4524084
 2011-05-31 15:05:40 -04:00
Luuk van Dijk
9b82408f6d gc: elide call to runtime.closure for function literals called in-place. 
before:
runtime_test.BenchmarkCallClosure        5000000               499 ns/op
runtime_test.BenchmarkCallClosure1       5000000               681 ns/op

after:
runtime_test.BenchmarkCallClosure       500000000                5 ns/op
runtime_test.BenchmarkCallClosure1       10000000              160 ns/op

R=rsc
CC=golang-dev
https://golang.org/cl/4515167
 2011-05-31 20:52:21 +02:00
Anthony Martin
67b4db9e9e gc: check parameter declarations in interface fields 
Fixes #1663.
Fixes #1871.

R=rsc, lstoakes
CC=golang-dev
https://golang.org/cl/4530084
 2011-05-31 13:41:32 -04:00
Russ Cox
2c6a2a9773 goinstall: skip standard packages 
R=adg, n13m3y3r
CC=golang-dev
https://golang.org/cl/4526084
 2011-05-30 18:23:16 -04:00
Robert Hencke
3fbd478a8a pkg: spelling tweaks, I-Z 
also, a few miscellaneous fixes to files outside pkg

R=golang-dev, dsymonds, mikioh.mikioh, r
CC=golang-dev
https://golang.org/cl/4517116
 2011-05-30 18:02:59 +10:00
Alex Brainman
9107b530d8 goinstall: use bash to execute gomake 
R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/4551074
 2011-05-30 16:15:08 +10:00
Alex Brainman
b7582852f6 gotest, pkg/exec: use bash instead of sh to execute shell scripts on windows 
As suggested by dho, iant2.

R=golang-dev, rsc
CC=devon.odell, golang-dev, iant
https://golang.org/cl/4515147
 2011-05-28 21:26:03 +10:00
Gustavo Niemeyer
a825e8a69f cgo: restrict #cgo directives to prevent shell expansion 
Fixes issue #1879.

Directives were not directly expanded, but since their
content ended up in makefiles, further expansion would
take place there.  This prevents such artifacts by
restricting the set of characters that may be used in
a directive value.

To build the list of safe characters I went through the
contents of /usr/lib/pkgconfig and extracted LDFLAGS
and CFLAGS information, so hopefully this is a
reasonable default to get started.

R=rsc
CC=golang-dev
https://golang.org/cl/4532092
 2011-05-27 08:46:51 -03:00
Gustavo Niemeyer
bddb75127f cgo: support pkg-config for flags and libs 
Fixes issue #1853.

R=golang-dev, mattn.jp, adg
CC=golang-dev
https://golang.org/cl/4550084
 2011-05-26 22:19:23 -03:00
Ian Lance Taylor
9ef8ebafe4 gc: patch y.tab.c to fix build when using Bison 2.5 
Fixes #1843.

R=rsc
CC=golang-dev
https://golang.org/cl/4535101
 2011-05-26 11:28:23 -07:00
Russ Cox
e94eb38975 gc: typo 
R=ken2
CC=golang-dev
https://golang.org/cl/4539086
 2011-05-25 10:19:50 -04:00
Russ Cox
2286471651 5g: alignment fixes 
Makes all.bash work after echo 4 >/proc/cpu/alignment,
which means kill the process on an unaligned access.

The default behavior on DreamPlug/GuruPlug/SheevaPlug
is to simulate an ARMv3 and just let the unaligned accesses
stop at the word boundary, resulting in all kinds of surprises.

Fixes #1240.

R=ken2
CC=golang-dev
https://golang.org/cl/4551064
 2011-05-25 10:18:49 -04:00
Russ Cox
831c684434 5l: fix build 
R=ken2
CC=golang-dev
https://golang.org/cl/4538095
 2011-05-25 09:44:05 -04:00
Russ Cox
64b497c62a ld: add -w to disable dwarf, make errors obviously from dwarf 
Reenable dwarf output on Mac.
Was writing headers but no actual dwarf data.

Fixes #1877 (accidentally).
Workaround for issue 1878.

R=lvd
CC=golang-dev
https://golang.org/cl/4515139
 2011-05-25 08:25:33 -04:00
Wei Guangjing
2ad58d48fb 8l: emit resources (.rsrc) in Windows PE. 
R=alex.brainman, rsc
CC=golang-dev, vcc.163
https://golang.org/cl/4516055
 2011-05-25 07:53:00 -04:00
Russ Cox
d2b2b3f4a8 6l, 8l: fix Mach-O binaries with many dynamic libraries 
R=ken2
CC=golang-dev
https://golang.org/cl/4529084
 2011-05-24 19:50:13 -04:00
Anthony Martin
0b209b36b6 gc: relax assignability of method receivers 
The spec was adjusted in commit df410d6a4842 to allow the
implicit assignment of strutures with unexported fields in
method receivers.  This change updates the compiler.

Also moved bug322 into fixedbugs and updated golden.out
to reflect the removal of the last known bug.

Fixes #1402.

R=golang-dev, gri, rsc
CC=golang-dev
https://golang.org/cl/4526069
 2011-05-24 19:48:19 -04:00
Robert Griesemer
3c7271f057 go spec: be precise with the use of the informal ellipsis … and the Go token ... 
Fixes #1867.

R=r
CC=golang-dev
https://golang.org/cl/4538092
 2011-05-24 14:18:44 -07:00
Dave Cheney
648f25b237 5l: fix set but not used warnings 
R=rsc, iant
CC=golang-dev
https://golang.org/cl/4538083
 2011-05-21 08:00:53 -07:00
Russ Cox
975ba88e0e cgo: use packed struct to fix Windows behavior 
R=golang-dev, mattn.jp, jcowgar, iant
CC=golang-dev
https://golang.org/cl/4535080
 2011-05-18 14:08:12 -04:00
Wei Guangjing
b256358008 6l: fix emit windows dwarf sections 
R=alex.brainman, rsc
CC=golang-dev, vcc.163
https://golang.org/cl/4532069
 2011-05-18 13:12:38 -04:00
Anthony Martin
f570d9d765 8g: fix conversion from float to uint64 
The code for converting negative floats was
incorrectly loading an FP control word from
the stack without ever having stored it there.

Thanks to Lars Pensjö for reporting this bug.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4515091
 2011-05-16 22:14:56 -04:00
Alexey Borzenkov
b701cf3332 runtime: make StackSystem part of StackGuard 
Fixes #1779

R=rsc
CC=golang-dev
https://golang.org/cl/4543052
 2011-05-16 16:57:49 -04:00
Russ Cox
e69b9ddd42 ld: do not emit reference to dynamic library named "" 
Fixes #1778.

R=ken2
CC=golang-dev
https://golang.org/cl/4550047
 2011-05-16 16:24:17 -04:00
Russ Cox
2d310a0087 5c, 5g: another attempt at silencing gcc 
R=ken2
CC=golang-dev
https://golang.org/cl/4535074
 2011-05-16 16:15:13 -04:00
Russ Cox
40745a579c 5l: delete pre-ARMv4 instruction implementations 
Add implementation for addr<->reg short moves.
Align large data, for ARM.

R=ken2
CC=golang-dev
https://golang.org/cl/4545050
 2011-05-16 16:14:37 -04:00
Robert Hencke
d49844bcce gofmt: skip bug340.go in test.sh 
bug340.go is a test case for a syntax error

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4523069
 2011-05-14 23:06:50 -07:00
Luuk van Dijk
36cec789cd gc: generalize dst = append(src,...) inlining to arbitrary src and dst arguments. 
R=rsc
CC=golang-dev
https://golang.org/cl/4517057
 2011-05-14 00:35:10 +02:00
Robert Griesemer
ba006e6b6a go/types: type checker API + testing infrastructure 
At the moment types.Check() only deals with global
types and only partially so. But the framework is
there to compute them and check for cycles. An initial
type test is passing.

First step of a series of CLs to come.

R=rsc
CC=golang-dev
https://golang.org/cl/4425063
 2011-05-13 15:31:09 -07:00
Russ Cox
2d174db6a6 5c, 5g: fix build with too-smart gcc 
R=ken2
CC=golang-dev
https://golang.org/cl/4543049
 2011-05-13 12:15:46 -04:00
Brad Fitzpatrick
05a1b7ec41 http: remove finalURL from Client.Get; move to Response 
This CL:

-- removes Response.RequestMethod string
-- adds Response.Request *Request
-- removes the finalURL result parameter from client.Get()
-- adds a gofix rule for callers of http.Get which assign
   the final url to the blank identifier; warning otherwise

Caller who did:

res, finalURL, err := http.Get(...)

now need to do:

res, err := http.Get(...)
if err != nil {
   ...
}
finalURL := res.Request.URL.String()

R=rsc
CC=golang-dev
https://golang.org/cl/4535056
 2011-05-13 07:31:24 -07:00
Alex Brainman
34ac4ec30c 6l, 8l: emit windows dwarf sections similar to other platforms 
R=golang-dev, rsc
CC=golang-dev, vcc.163
https://golang.org/cl/4517056
 2011-05-13 16:05:47 +10:00
Robert Hencke
a005617c5a gotest: document unit of time for elapsed() 
R=golang-dev
CC=golang-dev
https://golang.org/cl/4543044
 2011-05-12 22:00:14 -07:00
Russ Cox
70798eaad6 5l, 8l: add ELF symbol table to binary 
Should have been added long ago.
Thanks to Alex Brainman for noticing.

R=ken2
CC=golang-dev
https://golang.org/cl/4538046
 2011-05-11 23:59:36 -04:00
Anthony Martin
4fca395321 ld: fix alignment of rodata section on Plan 9 
This was causing a panic in the reflect package
since type.* pointers with their low bits set are
assumed to have certain flags set that disallow
the use of reflection.

Thanks to Pavel and Taru for help tracking down
this bug.

R=rsc, paulzhol, taruti
CC=golang-dev
https://golang.org/cl/4511041
 2011-05-11 23:52:05 -04:00
Lorenzo Stoakes
f58d911698 gc: fix type switch error message for invalid cases. 
Fixes #1606.

R=rsc
CC=golang-dev
https://golang.org/cl/4532045
 2011-05-11 23:41:59 -04:00
Luuk van Dijk
d6b2925923 gc: inline append when len<cap 
issue 1604

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/4313062
 2011-05-11 16:35:11 +02:00
Russ Cox
3f335f80b4 gc: fix unsafe.Sizeof 
Fixes #1608.
Fixes #1787.

R=ken2
CC=golang-dev
https://golang.org/cl/4530045
 2011-05-10 17:00:15 -04:00
Joe Poirier
733fde588b windows: reset command var to sh for correct error output messages 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4492043
 2011-05-06 22:05:04 -07:00
Roger Peppe
1dc914bc0d cgo: put CFLAGS before filename argument 
This means that the -x flag can work, which could enable
support for other languages (e.g. objective-C).

R=iant, rsc
CC=golang-dev
https://golang.org/cl/4476049
 2011-05-06 13:35:51 -07:00
Robert Griesemer
e49d50e203 gofmt: update test.sh (exclude a file w/ incorrect syntax) 
R=iant, iant2
CC=golang-dev
https://golang.org/cl/4453058
 2011-05-03 09:56:18 -07:00
Russ Cox
296d6871a8 ld: make ELF binaries with no shared library dependencies static binaries 
$ file $GOROOT/bin/{godoc,goyacc}
/home/rsc/g/go/bin/godoc:  ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), not strpped
/home/rsc/g/go/bin/goyacc: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped
$

Fixes #1758.

R=iant
CC=golang-dev
https://golang.org/cl/4428079
 2011-05-03 01:56:23 -04:00
Russ Cox
4002014cf8 http/pprof: fix POST reading bug 
R=bradfitz
CC=golang-dev
https://golang.org/cl/4430075
 2011-05-02 17:34:22 -04:00
Robert Griesemer
c783e68ff5 godoc: added -index flag to enable/disable search index 
Fixes #1647.

R=adg, rsc1, r2, rsc, r
CC=golang-dev
https://golang.org/cl/4444083
 2011-05-02 13:28:02 -07:00
Russ Cox
a46a311dec 5a, 6a, 8a, cc: remove old environment variables 
Uses of $INCLUDE and $NPROC are left over from Plan 9.
Remove them to avoid causing confusion.

R=golang-dev, r2
CC=golang-dev
https://golang.org/cl/4445079
 2011-05-02 11:24:32 -04:00
Russ Cox
8133cb3565 gc: preserve original expression for errors 
Fixes #1722.

R=ken2
CC=golang-dev
https://golang.org/cl/4442099
 2011-04-28 13:14:35 -04:00
Lorenzo Stoakes
b6f0632e93 gc: correctly handle fields of pointer type to recursive forward references 
Previously, whether declaring a type which copied the structure of a type it was referenced in via a pointer field would work depended on whether you declared it before or after the type it copied, e.g. type T2 T1; type T1 struct { F *T2 } would work, however type T1 struct { F *T2 }; type T2 T1 wouldn't.

Fixes #667.

R=rsc
CC=golang-dev
https://golang.org/cl/4313064
 2011-04-28 00:13:49 -04:00
Russ Cox
09092a78e6 cgo: handle versioned ELF symbols 
Fixes #1397.

R=iant
CC=golang-dev
https://golang.org/cl/4444064
 2011-04-27 23:21:03 -04:00
Russ Cox
5eeaca12d3 gopack: preserve safe flag when not adding unsafe objects to archive 
R=dsymonds
CC=golang-dev
https://golang.org/cl/4436060
 2011-04-27 09:20:53 -04:00
Andrew Gerrand
ca8a055f5c goinstall: support GOPATH; building and installing outside the Go tree 
For example, with GOPATH set like so
        GOPATH=/home/adg/gocode
And after creating some subdirectories
        mkdir /home/adg/gocode/{bin,pkg,src}

I can use goinstall to install the github.com/nf/goto web server,
which depends on the github.com/nf/stat package, with
        goinstall github.com/nf/goto

This downloads and installs all dependencies (that aren't already
installed) like so
        /home/adg/gocode/bin/goto
        /home/adg/gocode/pkg/darwin_amd64/github.com/nf/stat.a
        /home/adg/gocode/src/github.com/nf/goto/...
        /home/adg/gocode/src/github.com/nf/stat/...

R=rsc, niemeyer
CC=golang-dev
https://golang.org/cl/4438043
 2011-04-27 11:00:34 +10:00
Alex Brainman
2d99974ec5 8l: do not emit empty dwarf pe sections 
This change will allow to generate valid executable,
even if rsc disables dwarf generation, as it happend
at revision 9a64273f9d68.

R=rsc
CC=golang-dev, lvd, vcc
https://golang.org/cl/4425066
 2011-04-26 17:12:16 +10:00
Russ Cox
bac8f18035 gc: fix order of operations for f() < g(). 
Also, 6g was passing uninitialized
Node &n2 to regalloc, causing non-deterministic
register collisions (but only when both left and
right hand side of comparison had function calls).

Fixes #1728.

R=ken2
CC=golang-dev
https://golang.org/cl/4425070
 2011-04-26 00:57:03 -04:00
Russ Cox
4684df520f gc: explain why invalid receiver types are invalid 
Fixes #1680.

R=ken2
CC=golang-dev
https://golang.org/cl/4446061
 2011-04-25 17:16:44 -04:00
Russ Cox
c2c7ee2736 ld: fix 6l -d on Mac, diagnose invalid use of -d 
R=r
CC=golang-dev
https://golang.org/cl/4430064
 2011-04-25 13:57:52 -04:00
Russ Cox
07abf1c732 fix tree for reflect rename 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4435067
 2011-04-25 13:39:36 -04:00
Russ Cox
41342dc73c gofix: add support for reflect rename 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4450053
 2011-04-25 13:39:00 -04:00
Fazlul Shahriar
f1781bec3b 8g,8l: fix "set but not used" gcc error 
$ gcc --version
gcc (GCC) 4.6.0 20110415 (prerelease)

R=golang-dev, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4442080
 2011-04-25 12:14:30 -04:00
Russ Cox
3a1fdc655e gc: fix import width bug 
Fixes #1705.

R=ken2
CC=golang-dev
https://golang.org/cl/4443060
 2011-04-25 12:08:48 -04:00
Robert Hencke
883d68f885 gc: allow complex types to be receiver types 
Fixes #1716.

R=golang-dev, rsc1, rsc
CC=golang-dev
https://golang.org/cl/4439068
 2011-04-25 12:02:54 -04:00
Russ Cox
c0a895fc0a gc: fix conversion of user-defined string type to []byte 
Fixes #1709.

R=ken2
CC=golang-dev
https://golang.org/cl/4438068
 2011-04-23 10:55:32 -04:00
Russ Cox
815a1b84c7 gc: fix return variable named _ 
Fixes #1712.

R=ken2
CC=golang-dev
https://golang.org/cl/4445055
 2011-04-23 10:54:19 -04:00
Russ Cox
7879d3118c gc: fix line number at EOF 
Fixes #1474.

R=ken2
CC=golang-dev
https://golang.org/cl/4432061
 2011-04-23 10:54:05 -04:00
Anthony Martin
c7008f47ec ld: fix Plan 9 symbol table 
Static symbols were not being marked as such.

I also made the 'z' symbols use the first byte of
the name instead of an explicit NUL so that if
the symbol table format is ever changed, the only
place that would need updating is addhist().

R=rsc
CC=golang-dev
https://golang.org/cl/4366047
 2011-04-23 10:53:49 -04:00
Lucio De Re
f367c13c79 8l/prof.c: #if 0 is not accepted by the Plan 9 native toolchain. 
The solution may be a bit of a sledgehammer, but it looks like
a temporary situation anyway.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4400042
 2011-04-21 17:03:58 -04:00
Albert Strasheim
10d1680efb cgo: avoid "incompatible pointer type" warning 
R=rsc
CC=golang-dev
https://golang.org/cl/4409041
 2011-04-21 17:02:52 -04:00
Quan Yong Zhai
256df10eae gc: fix copy([]int, string) error message 
R=rsc
CC=golang-dev
https://golang.org/cl/4433064
 2011-04-21 12:09:29 -04:00
Russ Cox
f10a7882c6 gc: another pointer to interface message 
R=ken2
CC=golang-dev
https://golang.org/cl/4444056
 2011-04-21 08:20:29 -04:00
Russ Cox
5ff3336490 gc: correct handling of unexported method names in embedded interfaces 
go/types: update for export data format change
reflect: require package qualifiers to match during interface check
runtime: require package qualifiers to match during interface check
test: fixed bug324, adapt to be silent

Fixes #1550.
Issue 1536 remains open.

R=gri, ken2, r
CC=golang-dev
https://golang.org/cl/4442071
 2011-04-21 08:14:50 -04:00
Alex Brainman
5aad514674 syscall: correct Windows CreateProcess input parameters 
Fixes #1718.

R=golang-dev, rsc, peterGo, r
CC=golang-dev
https://golang.org/cl/4435059
 2011-04-21 10:36:27 +10:00
Russ Cox
047e698c52 ld: remove MachoLoad limit 
Fixes #1571.

R=ken2
CC=golang-dev
https://golang.org/cl/4443052
 2011-04-20 16:25:00 -04:00
Russ Cox
ec735c4ec8 gc: fix error for +string 
Fixes #1710.

R=ken2
CC=golang-dev
https://golang.org/cl/4444054
 2011-04-20 16:12:47 -04:00
Robert Griesemer
7412583e89 gofix, gofmt: update documentation 
gofmt: also fix a typo in gofmt.go

R=rsc, r
CC=golang-dev
https://golang.org/cl/4431055
 2011-04-20 11:01:21 -07:00
David Crawshaw
123e89fef1 gofmt: add -diff 
Some code duplication with gofix.

R=rsc, gri, bradfitzgo, r2, adg, peterGo, r, brainman
CC=golang-dev
https://golang.org/cl/4430054
 2011-04-20 10:07:56 -07:00
Andrew Gerrand
aaa6ce2301 goinstall: support building executable commands 
This CL gives goinstall the ability to build commands,
not just packages.

"goinstall foo.googlecode.com/hg/bar" will build the command named
"bar" and install it to GOBIN. "goinstall ." will use the name of the
local directory as the command name.

R=rsc, niemeyer
CC=golang-dev
https://golang.org/cl/4426045
 2011-04-20 12:02:29 +10:00
Russ Cox
3bac16a6bf reflect: allow Slice of arrays 
R=r
CC=golang-dev
https://golang.org/cl/4444049
 2011-04-18 20:00:42 -04:00
Russ Cox
b331f3cfd0 5c: make alignment rules match 5g, just like 6c matches 6g 
I should have done this a year ago in:

        changeset:   5137:686b18098944
        user:        Russ Cox <rsc@golang.org>
        date:        Thu Mar 25 14:05:54 2010 -0700
        files:       src/cmd/8c/swt.c
        description:
        make alignment rules match 8g, just like 6c matches 6g.

        R=ken2
        CC=golang-dev
        https://golang.org/cl/760042

R=ken2
CC=golang-dev
https://golang.org/cl/4437054
 2011-04-18 18:50:31 -04:00
Russ Cox
cded21a337 changes for more restricted reflect.SetValue 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4423043
 2011-04-18 14:36:22 -04:00
Russ Cox
beb64bbd6e gc: fix complex move again 
R=ken2
CC=golang-dev
https://golang.org/cl/4443047
 2011-04-18 13:22:31 -04:00
Russ Cox
3d36a81fcc undo 4439044 
cannot use regalloc with floating point on 386.
will redo some other way.

R=ken2
CC=golang-dev
https://golang.org/cl/4439045
 2011-04-15 19:17:16 -04:00
Russ Cox
a12d70f60d gc: fix complex move bug 
R=ken2
CC=golang-dev
https://golang.org/cl/4439044
 2011-04-15 16:16:33 -04:00
Russ Cox
de5616fbb4 gc: print of unsafe.Pointer 
Got lost when I introduced TUNSAFEPTR.

R=ken2
CC=golang-dev
https://golang.org/cl/4442046
 2011-04-15 16:16:20 -04:00
Ian Lance Taylor
4c137b6162 5g: correct size of reg array. 
Found by gcc 4.5.2 -Werror build reported on IRC by niemeyer.

R=ken2, rsc, r2
CC=golang-dev
https://golang.org/cl/4438042
 2011-04-15 13:09:57 -07:00
Rob Pike
07dc26f88d 6l: fix another "set and not used". 
R=rsc
CC=golang-dev
https://golang.org/cl/4433042
 2011-04-15 08:31:32 -07:00
Russ Cox
db7a2024f9 gc: printing of multiple assignment 
R=ken2
CC=golang-dev
https://golang.org/cl/4429043
 2011-04-15 10:34:55 -04:00
Dave Cheney
29cf90a4ef libmach: fix warnings. 
Fixes #1706.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/4413051
 2011-04-14 23:58:08 -04:00
Russ Cox
89fc2c8f4f gopack: fix prefix bug 
When prefix doesn't match, was deleting entire .6 file.

R=dsymonds
CC=golang-dev
https://golang.org/cl/4427041
 2011-04-14 23:34:14 -04:00
Robert Griesemer
604c161e32 gofmt: exclude test case that doesn't compile w/o errors 
R=r, r2
CC=golang-dev
https://golang.org/cl/4398048
 2011-04-14 17:06:38 -07:00
Robert Griesemer
c78cddd7de gofmt: gofmt test harness bug fix 
Don't use the rewrite rule from a previous test
for the next test if there is no rewrite rule
provided.

R=r, r2
CC=golang-dev
https://golang.org/cl/4419045
 2011-04-14 16:33:29 -07:00
Robert Griesemer
a49e7f393f gofmt: don't crash when rewriting nil interfaces in AST. 
The new reflection API makes it an error to call value.Set(x)
if x is invalid. Guard for it.

Added corresponding test case.

Fixes #1696.

R=rsc, r
CC=golang-dev
https://golang.org/cl/4398047
 2011-04-14 14:25:25 -07:00
Rob Pike
a89c0ff39e for GCC4.6: fix a bunch of set-and-not-used errors. 
R=rsc
CC=golang-dev
https://golang.org/cl/4406048
 2011-04-14 13:31:37 -07:00
Brad Fitzpatrick
02cae293cc gotest: generate gofmt-compliant code 
R=r
CC=golang-dev
https://golang.org/cl/4400047
 2011-04-14 11:50:00 -07:00
Russ Cox
3441bda959 gotest: add timing, respect $GOARCH 
R=r, r2
CC=golang-dev
https://golang.org/cl/4370049
 2011-04-14 10:59:33 -04:00
Russ Cox
bd43a2d9ff ld: defend against some broken object files 
Fixes #1698.
Fixes #1699.

R=ken2
CC=golang-dev
https://golang.org/cl/4419041
 2011-04-14 10:42:48 -04:00
Russ Cox
bd77eedacf gc: fix use of typekind array in error messages 
Fixes #1697.

R=ken2
CC=golang-dev
https://golang.org/cl/4395045
 2011-04-14 09:33:53 -04:00
Luuk van Dijk
dd93df35b9 runtime: fix gdb support for channels. 
R=rsc
CC=golang-dev
https://golang.org/cl/4418043
 2011-04-14 15:32:20 +02:00
Russ Cox
507df959e4 runtime: drop chan circular linked list in favor of circular buffer 
The list elements are already being allocated out of a
single memory buffer.  We can drop the Link* pointer
following and the memory it requires, replacing it with
index operations.

The change also keeps a channel from containing a pointer
back into its own allocation block, which would create a
cycle.  Blocks involved in cycles are not guaranteed to be
finalized properly, and channels depend on finalizers to
free OS-level locks on some systems.  The self-reference
was keeping channels from being garbage collected.

runtime-gdb.py will need to be updated in order to dump
the content of buffered channels with the new data structure.

Fixes #1676.

R=ken2, r
CC=golang-dev
https://golang.org/cl/4411045
 2011-04-13 23:42:06 -04:00
Russ Cox
017e73c1b2 gc: fix func syntax error 
Fixes #1685.

R=ken2
CC=golang-dev
https://golang.org/cl/4414042
 2011-04-13 22:48:21 -04:00
Rob Pike
bb855f985a govet: make name-matching for printf etc. case-insensitive. 
Update goyacc, cgo to be more canonical in their naming and silence the new warnings.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/4417042
 2011-04-13 16:57:44 -07:00
Robert Griesemer
a2e286828b gofmt: gofmt -s -w src misc 
R=r, bradfitzwork
CC=golang-dev
https://golang.org/cl/4406044
 2011-04-13 15:13:59 -07:00
Robert Griesemer
5666ec8735 fix build: disable gofmt test script, enable gotest testing instead 
R=rsc
CC=golang-dev
https://golang.org/cl/4403045
 2011-04-13 14:24:38 -07:00
Robert Griesemer
99f069a97f gofmt: add test framework in Go 
- replaced existing testdata/test.sh with new gofmt_test
- added initial test case for rewrite tests

TODO: Need to add more tests.

R=rsc
CC=golang-dev
https://golang.org/cl/4368063
 2011-04-13 13:59:59 -07:00
Robert Griesemer
3d4b55ad5b gofmt: minor refactor to permit easy testing 
R=rsc
CC=golang-dev
https://golang.org/cl/4397046
 2011-04-13 13:57:53 -07:00
Rob Pike
e6cf42c39a gofix: fix embarrassing typo in osopen.go 
R=rsc, gri
CC=golang-dev
https://golang.org/cl/4411044
 2011-04-13 13:49:24 -07:00
Russ Cox
1d26908d3f build: use gcc -Werror 
Better to fix the warnings that we find.

R=iant
CC=golang-dev
https://golang.org/cl/4406042
 2011-04-13 16:18:09 -04:00
Robert Griesemer
a5ca635287 gofmt: avoid endless loops 
With the (partial) resolution of identifiers done
by the go/parser, ast.Objects point may introduce
cycles in the AST. Don't follow *ast.Objects, and
replace them with nil instead (they are likely
incorrect after a rewrite anyway).

- minor manual cleanups after reflect change automatic rewrite
- includes fix by rsc related to reflect change

Fixes #1667.

R=rsc
CC=golang-dev
https://golang.org/cl/4387044
 2011-04-13 09:38:13 -07:00
Lucio De Re
36b6d1aaf2 8l: correct Plan 9 compiler warnings 
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4390047
 2011-04-12 16:21:01 -04:00
Lucio De Re
11e07d23ed ld: ELF header function declarations. 
Added "void" inside "()" for two functions.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4381056
 2011-04-12 11:00:09 -07:00
Luuk van Dijk
0cc055e8f7 ld: fix dwarf decoding of strings for struct's fieldnames 
Moved Sym printing to Yconv.
Fixed warning in data.c

R=rsc
CC=golang-dev
https://golang.org/cl/4378052
 2011-04-11 16:38:37 -04:00
Russ Cox
1bc84b7e18 ld: 25% faster 
The ld time was dominated by symbol table processing, so
  * increase hash table size
  * emit fewer symbols in gc (just 1 per string, 1 per type)
  * add read-only lookup to avoid creating spurious symbols
  * add linked list to speed whole-table traversals

Breaks dwarf generator (no idea why), so disable dwarf.

Reduces time for 6l to link godoc by 25%.

R=ken2
CC=golang-dev
https://golang.org/cl/4383047
 2011-04-09 09:44:20 -04:00
Russ Cox
23f6479be6 8g: optimize byte mov 
Rewrite MOVB with less expensive
instruction when possible.

Suggested by atomic symbol.

benchmark                                        old ns/op    new ns/op    delta
crc32.BenchmarkCrc32KB                               13066         3942  -69.83%
crc64.BenchmarkCrc64KB                                8780         5949  -32.24%
lzw.BenchmarkDecoder1e4                             771224       636538  -17.46%
lzw.BenchmarkDecoder1e5                            7101218      6096634  -14.15%
lzw.BenchmarkDecoder1e6                           69762020     60789400  -12.86%
lzw.BenchmarkEncoder1e4                             707968       638812   -9.77%
lzw.BenchmarkEncoder1e5                            6567122      5965552   -9.16%
lzw.BenchmarkEncoder1e6                           65006000     58911680   -9.38%
utf8_test.BenchmarkRuneCountTenASCIIChars              166          165   -0.60%
utf8_test.BenchmarkRuneCountTenJapaneseChars           246          258   +4.88%
utf8_test.BenchmarkEncodeASCIIRune                      13           10  -23.08%
utf8_test.BenchmarkEncodeJapaneseRune                   37           16  -56.76%
utf8_test.BenchmarkDecodeASCIIRune                      23           21   -8.70%
utf8_test.BenchmarkDecodeJapaneseRune                   58           32  -44.83%

R=ken2
CC=golang-dev
https://golang.org/cl/4381045
 2011-04-08 13:53:59 -04:00
Russ Cox
e7c4a6dfca gc: fix weird error message 
Fixes #1670.

R=ken2
CC=golang-dev
https://golang.org/cl/4386045
 2011-04-08 13:53:32 -04:00
Russ Cox
d26e73646e ld: fix arm build 
R=ken2
CC=golang-dev, mikkel
https://golang.org/cl/4384048
 2011-04-08 13:42:11 -04:00
Rob Pike
ddd0fa1744 gotest: Fix fix for \r\n on windows. 
R=rsc, brainman, rh, r2
CC=golang-dev
https://golang.org/cl/4366045
 2011-04-08 09:50:20 -07:00
Russ Cox
db5c5d6fa6 update go tree for reflect changes 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4353043
 2011-04-08 12:27:58 -04:00
Russ Cox
fb94eb1922 gofix: reflect changes 
R=gri
CC=golang-dev
https://golang.org/cl/4343047
 2011-04-08 12:27:24 -04:00
Russ Cox
877c1892bb gofix: add -diff, various fixes and helpers 
* add -diff command line option
  * use scoping information in refersTo, isPkgDot, isPtrPkgDot.
  * add new scoping-based helpers countUses, rewriteUses, assignsTo, isTopName.
  * rename rewrite to walk, add walkBeforeAfter.
  * add toy typechecker, a placeholder for go/types

R=gri
CC=golang-dev
https://golang.org/cl/4285053
 2011-04-08 12:27:08 -04:00
Russ Cox
846a368b88 gofix: be more conservative about rewrite to os.Create 
Rewrite only if we understood all the flags we saw.

R=r
CC=golang-dev
https://golang.org/cl/4376046
 2011-04-08 10:59:25 -04:00
Alex Brainman
d976314776 gotest: handle \r\n returned by gomake on Windows (fixes build) 
R=golang-dev, peterGo, rsc1
CC=Joe Poirier, golang-dev
https://golang.org/cl/4370048
 2011-04-08 23:53:57 +10:00
Robert Griesemer
1baffa7da0 gotype: use go/types GcImporter 
R=rsc
CC=golang-dev
https://golang.org/cl/4358043
 2011-04-07 21:42:30 -07:00
Russ Cox
35c880b1e2 gc: bug327 
Fixes #1674.

R=ken2
CC=golang-dev
https://golang.org/cl/4368057
 2011-04-07 18:53:47 -04:00
Mikkel Krautz
2aceea630f ld: fix Mach-O X86_64_RELOC_SIGNED relocations 
Fixes #1658.

R=rsc
CC=golang-dev
https://golang.org/cl/4344066
 2011-04-07 14:20:42 -04:00
Mikkel Krautz
cf3323f511 ld: fix Mach-O bss bug 
Fixes #1559.

R=rsc
CC=golang-dev, peterGo, rog
https://golang.org/cl/4356046
 2011-04-07 13:17:28 -04:00
Rob Pike
63e28ae4ab gotest: fix windows build. 
R=rsc
CC=golang-dev
https://golang.org/cl/4339055
 2011-04-05 13:51:49 -07:00
Rob Pike
88a8ac08b9 gotest: fix a bug in error handling. 
If the command couldn't be found, argv[0] would be wiped.
Also, fix a print statement not to refer to make - it was a vestige of a prior form.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/4360048
 2011-04-05 12:51:10 -07:00
Peter Mundy
b2bf14acd9 gotest: fixes for [^.]_test file pattern 
R=rsc, r
CC=golang-dev
https://golang.org/cl/4339054
 2011-04-05 11:49:44 -07:00
Russ Cox
de3aac609c gofix: don't rewrite O_APPEND opens 
R=r, rog
CC=golang-dev
https://golang.org/cl/4364041
 2011-04-05 11:12:02 -04:00
Rob Pike
8a90fd3c72 os: New Open API. 
We replace the current Open with:
OpenFile(name, flag, perm) // same as old Open
Open(name) // same as old Open(name, O_RDONLY, 0)
Create(name) // same as old Open(name, O_RDWR|O_TRUNC|O_CREAT, 0666)

This CL includes a gofix module and full code updates: all.bash passes.
(There may be a few comments I missed.)

The interesting packages are:
        gofix
        os
Everything else is automatically generated except for hand tweaks to:
        src/pkg/io/ioutil/ioutil.go
        src/pkg/io/ioutil/tempfile.go
        src/pkg/crypto/tls/generate_cert.go
        src/cmd/goyacc/goyacc.go
        src/cmd/goyacc/units.y

R=golang-dev, bradfitzwork, rsc, r2
CC=golang-dev
https://golang.org/cl/4357052
 2011-04-04 23:42:14 -07:00
Russ Cox
d3ca620baf gotest: fix build 
TBR=r
CC=golang-dev
https://golang.org/cl/4351047
 2011-04-04 16:35:40 -04:00
Rob Pike
60c4c3464b path/filepath.Glob: add an error return. 
The error will only occur for invalid patterns, but without this
error path there is no way to know that Glob has failed due to
an invalid pattern.

R=rsc
CC=golang-dev
https://golang.org/cl/4346044
 2011-04-04 13:09:34 -07:00
Russ Cox
6865cc0e8e gc: avoid saying same error 3 times 
R=ken2
CC=golang-dev
https://golang.org/cl/4316051
 2011-04-01 20:52:38 -04:00
Alex Brainman
799be52b35 gotest: another attempt to make it run on Windows 
R=golang-dev, rsc1
CC=golang-dev
https://golang.org/cl/4347041
 2011-04-01 13:38:33 +11:00
Alex Brainman
6c651728d8 gotest: execute gomake properly on Windows 
R=peterGo, rsc, Joe Poirier
CC=golang-dev
https://golang.org/cl/4280087
 2011-04-01 10:10:15 +11:00
Ian Lance Taylor
554082d6b1 testing: add -test.timeout option. 
Since Go code can deadlock, this lets a testsuite driver set a
time limit for the test to run.  This is simple but imperfect,
in that it only catches deadlocks in Go code, not in the
runtime scheduler.

R=r, rsc, iant2
CC=golang-dev
https://golang.org/cl/4326048
 2011-03-31 15:27:51 -07:00
Rob Pike
7d77e3117c gotest: another try at flags. 
doc.go contains the details. The short story:
- command line is passed to the binary
- a new flag, -file, is needed to name files
- known flags have the "test." prefix added for convenience.
- gotest-specific flags are trimmed from the command line.

The effect should be that most existing uses are unaffected,
the ability to name files is still present, and it's nicer to use.
The downside is a lot more code in gotest.

Also allow a test to be called just Test.

R=rsc, niemeyer, rog, r2
CC=golang-dev
https://golang.org/cl/4307049
 2011-03-30 21:14:49 -07:00
Russ Cox
5a7a074261 gopack: comment out debugging print 
TBR=r
CC=golang-dev
https://golang.org/cl/4333048
 2011-03-30 22:41:32 -04:00
Russ Cox
3d2e57a312 gopack: add P flag to remove prefix from filename information 
R=r, r2
CC=golang-dev
https://golang.org/cl/4307047
 2011-03-30 22:19:02 -04:00
Robert Griesemer
7a5bbfd47f gotype: support for more tests, added one new test 
also: minor fix to parser

Note: gotest won't run the gotype test yet until
it permits TestXXX functions where XXX is empty.

R=r
CC=golang-dev
https://golang.org/cl/4300053
 2011-03-30 15:27:23 -07:00
Robert Griesemer
61aaadf217 gotest: exclude . files when parsing directories (per r's suggestion) 
R=r, rsc1, iant2
CC=golang-dev
https://golang.org/cl/4329044
 2011-03-30 09:46:11 -07:00
Andrew Gerrand
6b567d26b7 godoc: remove errant space in HTML tag 
R=gri
CC=golang-dev
https://golang.org/cl/4277087
 2011-03-30 16:41:41 +11:00
Robert Griesemer
1afc37fa7e go/printer/gofmt: remove special case for multi-line raw strings 
As a special case, multi-line raw strings (i.e., strings in `` quotes)
were not indented if they were the only token on a line. This heuristic
was meant to improve formatting for multi-line raw strings where sub-
sequent lines are not indented at the level of the surrounding code.
Multiple people have complained about this. Removing the heuristic
again because it makes the formatting more regular, easier to under-
stand, and simplifies the implementation.

- manual changes to ebnf/ebnf_test.go for readability
- gofmt -w src misc

Fixes #1643.

R=r, rsc
CC=golang-dev
https://golang.org/cl/4307045
 2011-03-29 18:30:59 -07:00
Rob Pike
d844aae690 prints: fix a couple of formatting errors caught by govet 
R=rsc, agl, agl1
CC=golang-dev
https://golang.org/cl/4337041
 2011-03-29 14:03:08 -07:00
Rob Pike
fb80f63cf7 gotest: replace the shell script with the compiled program written in go. 
Update the make sequence: gotest must now be installed after the packages.

R=rsc
CC=golang-dev
https://golang.org/cl/4323044
 2011-03-29 13:29:20 -07:00
Rob Pike
518c0adb17 govet: fix bug introduced at 4313054 
R=rsc, gri
CC=golang-dev
https://golang.org/cl/4336042
 2011-03-29 13:18:52 -07:00
Rob Pike
f61b7e5dc5 gotry: move into its own directory, separate from gotest. 
R=rsc
CC=golang-dev
https://golang.org/cl/4327045
 2011-03-29 13:00:24 -07:00
Rob Pike
62ed6ee6c4 ngotest: correctly handle packages with tests outside the package. 
R=rsc
CC=golang-dev
https://golang.org/cl/4330043
 2011-03-29 12:50:41 -07:00
Rob Pike
e393efc499 ngotest: a new gotest command, written in Go. 
It runs all tests correctly and saves significant time by avoiding the shell script.
However, this is just the code for the command, for review.
A separate CL will move this into the real gotest, which will take some dancing.

R=rsc, peterGo, bsiegert, albert.strasheim, rog, niemeyer, r2
CC=golang-dev
https://golang.org/cl/4281073
 2011-03-29 10:11:33 -07:00
Robert Griesemer
536531769b CL 4291070: incorporating rsc's feedback 
R=rsc
CC=golang-dev
https://golang.org/cl/4313054
 2011-03-29 09:08:23 -07:00
Russ Cox
2a1b4a83fc gofix: netdial 
R=adg
CC=golang-dev
https://golang.org/cl/4278053
 2011-03-28 23:29:00 -04:00
Robert Griesemer
b2658452a6 go/scanner: return literal as string instead of []byte 
Removed many string conversions in dependent code.
Runs all tests. No change to gofmt output.

R=r
CC=golang-dev
https://golang.org/cl/4291070
 2011-03-28 16:44:28 -07:00
Robert Griesemer
5be77a204b go/ast: implemented NewPackage 
NewPackage creates an ast.Package node from
a set of package files and resolves unresolved
identifiers.

Also:
- Changed semantics of Scope.Insert: If an
  object is inserted w/o errors, the result
  is nil (before it was obj).
- Fixed an identifier resolution bug in the
  parser: map keys must not be resolved.

gotype runs through several go/* packages
and successfully resolves all (non-field/method)
identifiers.

R=rog, rsc
CC=golang-dev
https://golang.org/cl/4298044
 2011-03-28 10:46:26 -07:00
Ian Lance Taylor
2795b13156 gc: remove interim ... error which rejects valid code. 
It's been six months.

R=rsc
CC=golang-dev
https://golang.org/cl/4289073
 2011-03-25 18:31:55 -07:00
Rob Pike
d406f8f650 testing: set up structure for faster testing using the new -test.short flag. 
New make target "testshort" runs "gotest -test.short" and is invoked
by run.bash, which is invoked by all.bash.

Use -test.short to make one package (crypto ecdsa) run much faster.
More changes to come.

Once this is in, I will update the long-running tests to use the new flag.

R=rsc
CC=golang-dev
https://golang.org/cl/4317043
 2011-03-25 14:50:44 -07:00
Russ Cox
543acc97f9 testing: add -test.cpuprofile flag 
R=r
CC=golang-dev
https://golang.org/cl/4272066
 2011-03-23 18:17:14 -04:00
Luuk van Dijk
14b9032f84 5l/6l/8l: undo spadj cleanup at ARET for following instructions in the same stackframe. 
5l was already correct, clarified comment and added diags for unmaintained code.

R=rsc
CC=golang-dev
https://golang.org/cl/4277070
 2011-03-23 23:11:29 +01:00
Brad Fitzpatrick
054a0c338f gotest: fix gofmt issue in generated _testmain.go 
R=rsc, r
CC=golang-dev
https://golang.org/cl/4287074
 2011-03-23 14:23:05 -07:00
Russ Cox
f2483c74f6 gofmt: add profiling flag 
R=gri
CC=golang-dev
https://golang.org/cl/4295062
 2011-03-23 14:28:38 -04:00
Russ Cox
fba0606220 godefs: handle volatile 
R=iant
CC=golang-dev
https://golang.org/cl/4291063
 2011-03-23 11:33:53 -04:00
Andrew Gerrand
005fe41125 godoc: add -template flag to specify custom templates 
R=gri, niemeyer, rsc1
CC=golang-dev
https://golang.org/cl/4291059
 2011-03-23 09:44:23 +11:00
Robert Griesemer
76061f7240 go/printer: Revert API change of CL 4274075. 
Revert changes to printer.Config. Pass in the
nodeSizes map trough an internal helper function.

R=golang-dev, rsc1
CC=golang-dev
https://golang.org/cl/4309042
 2011-03-22 14:14:26 -07:00
Russ Cox
1da382c871 gopprof: fix bug: do not rotate 180 degrees for large scrolls 
R=r
CC=golang-dev
https://golang.org/cl/4273088
 2011-03-22 02:04:59 -04:00