1
0
mirror of https://github.com/golang/go synced 2024-11-19 13:34:45 -07:00
Commit Graph

158 Commits

Author SHA1 Message Date
Russ Cox
e414fda6d4 avoid infinite recursion in matcher.
after sync (or sync --local), clean up repository:
	* look for and close CLs submitted on our behalf
	* remove unmodified files from CLs
	* warn about empty CLs

R=r
http://go/go-review/1017029
2009-11-04 15:17:01 -08:00
Russ Cox
506ce11f03 various tweaks to code review.
main one is to check at submit time that
user name being used in checkin message
is listed in the CONTRIBUTORS file.
this should catch misconfigurations.

another is to cut the @domain part
from the R= and CC= lines on checkin
messages, so that cc'ing someone on
a change does not mean their email
address is recorded for all time.

R=r
CC=go-dev
http://go/go-review/1016036
2009-11-04 03:15:24 -08:00
Russ Cox
9c13215859 rietveld does not like code reviews with subjects longer than 100 characters, so trim the line pulled out of the description to avoid the limit.
R=r
http://go/go-review/1016027
2009-11-02 11:37:21 -08:00
Russ Cox
dde666dab5 code review: avoid subject changes, fix http_proxy submit bug
R=r
http://go/go-review/1016021
2009-11-01 18:46:07 -08:00
Russ Cox
45495249e1 code review fixes
* clean up error handling: show Exception info
* white space fixes
* clean up output when creating CL
* simplify hg change command; add hg file
* fix stale cookie bug (thanks iant)
* in LoadAllCL, load each CL in a different thread,
  to parallelize the slow web fetches
* throw away support for Mercurial before version 1.3
* add @CL-number file pattern for commands like diff
* make hg sync show files being sync'ed

R=r
http://go/go-review/1016016
2009-11-01 05:49:35 -08:00
Russ Cox
439f9ca809 add codereview-login command
R=r
CC=go-dev
http://go/go-review/1012007
2009-10-22 14:14:17 -07:00
Russ Cox
eea2573032 fix handling of escaped characters like ' " & < >
R=r
http://go/go-review/1013007
2009-10-22 11:21:13 -07:00
Russ Cox
79a63728eb Initial checkin of codereview plugin.
The master copy is going to live elsewhere,
but weAPOSTROPHEll keep a copy in the Go tree so that
developers donAPOSTROPHEt have to check out two
different repositories.

R=r
CC=go-dev
http://go/go-review/1012006
2009-10-22 11:12:39 -07:00