2 Commits

Author	SHA1	Message	Date
Rebecca Stambler	5123702d80	internal/lsp: fix update code lens and add a regression test ... CL 235619 introduced a bug into the command code, resulting in code lenses suggesting `go mod get` commands. Fix this issue and add an end-to-end code lens regression test. Fixes golang/go#39446 Change-Id: I3646aec881b69f43e5320adcb0976b3516a46761 Reviewed-on: https://go-review.googlesource.com/c/tools/+/236841 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>	2020-06-08 16:37:37 +00:00
Rob Findley	cb8d9cd245	internal/lsp: support configurable codeLens ... Some code lenses may be undesirable for certain users or editors -- for example a code lens that runs tests, when VSCode already supports this functionality outside of the LSP. To handle such situations, support configuring code lenses via a new 'codelens' gopls option. Add support for code lens in regtests, and use this to test the new configuration. To achieve this, thread through a new 'EditorConfig' type that configures the fake editor's LSP session. It made sense to move the test Env overlay onto this config object as well. While looking at them, document some types in source.Options. Change-Id: I961077422a273829c5cbd83c3b87fae29f77eeda Reviewed-on: https://go-review.googlesource.com/c/tools/+/232680 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2020-05-08 18:47:35 +00:00