kortschak
987877771e
x/tools/present: fix element number check
...
Fixes golang/go#20605
Change-Id: Ia87097741b743d9b138f0f16540d601b9525c7de
Reviewed-on: https://go-review.googlesource.com/45110
Reviewed-by: Andrew Gerrand <adg@golang.org>
2017-06-08 00:01:16 +00:00
Eyal Posener
92d42b9ff1
present: return an error for a bad link instead of panic
...
Change-Id: Ic41b2794268b6399bda01febafb85852f6634198
Reviewed-on: https://go-review.googlesource.com/44690
Reviewed-by: Andrew Gerrand <adg@golang.org>
2017-06-05 22:57:01 +00:00
Alexis Hildebrandt
11b386927a
present: fix misspelled log message
...
Change-Id: I959bc4ec6ba4995a1da7d300cf9d3b63e96b1a0e
Reviewed-on: https://go-review.googlesource.com/42817
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2017-05-08 18:52:03 +00:00
Rob Pike
31d5e8dca1
go.tools/present: fix printf bug found by go vet
...
LGTM=iant
R=adg, iant
CC=golang-codereviews
https://golang.org/cl/93450044
2014-05-16 14:29:34 -07:00
Francesc Campoy
5f5d42a466
go.tools/present: links with the prefix "javascript:" should be executed in the same window.
...
Using url.Parse instead of more ad hoc solution.
R=r
CC=golang-codereviews
https://golang.org/cl/47320043
2014-01-03 14:51:34 -08:00
Francesc Campoy
3d2d158b9d
go.tools/present: Open links with local (non absolute) URLs in the same window.
...
This allows having links from one slide to another one in the same presentation.
Also it is needed in the new tour to cross reference lessons.
R=r
CC=golang-codereviews
https://golang.org/cl/46130043
2013-12-28 21:10:40 -08:00
Andrew Gerrand
9fc516408c
go.tools/godoc/present: move present package from go.talks
...
Godoc depends on go.talks/pkg/present by way of go.tools/pkg/blog.
Better to keep all godoc dependencies in one place.
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/13656047
2013-09-19 10:55:46 +10:00
