Rob Pike
5fea8c030b
text/template: fix type of ComplexZero in test
...
Was stupidly float64; should be complex128.
The tests still pass.
Fixes #5649 .
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12107044
2013-07-31 13:04:57 +10:00
Russ Cox
6a13897bc6
runtime: ARM _sfloat has no arguments
...
Fixes one build failure.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/12139043
2013-07-30 22:58:38 -04:00
Russ Cox
57933b86b1
cmd/go: send timed out test SIGQUIT before SIGKILL
...
There is a chance that the SIGQUIT will make the test process
dump its stacks as part of exiting, which would be nice for
finding out what it is doing.
Right now the builders are occasionally timing out running
the runtime test. I hope this will give us some information
about the state of the runtime.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/12041051
2013-07-30 22:52:10 -04:00
Russ Cox
4042b77776
runtime: cut struct Hmap back to 48-byte allocation
...
struct Hmap is the header for a map value.
CL 8377046 made flags a uint32 so that it could be updated atomically,
but that bumped the struct to 56 bytes, which allocates as 64 bytes (on amd64).
hash0 is initialized from runtime.fastrand1, which returns a uint32,
so the top 32 bits were always zero anyway. Declare it as a uint32
to reclaim 4 bytes and bring the Hmap size back down to a 48-byte allocation.
Fixes #5237 .
R=golang-dev, khr, khr
CC=bradfitz, dvyukov, golang-dev
https://golang.org/cl/12034047
2013-07-30 22:48:03 -04:00
Shivakumar GN
3abaf5cae0
net/http: skip TestDirJoin on Windows, even if /etc/hosts exists
...
Fixes #5460 .
R=golang-dev, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/12123043
2013-07-30 18:25:08 -07:00
Robert Griesemer
12a38d5b95
container/list: document complexity of Len
...
Fixes #5972 .
R=golang-dev, adonovan
CC=golang-dev
https://golang.org/cl/12125043
2013-07-30 13:35:14 -07:00
Dmitriy Vyukov
3d6bce411c
runtime: fix code formatting
...
This is mainly to force another build
with goroutine preemption.
R=rsc
CC=golang-dev
https://golang.org/cl/12006045
2013-07-30 23:48:18 +04:00
Dmitriy Vyukov
a20784bdaf
runtime: enable goroutine preemption
...
All known issues with preemption have beed fixed.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12008044
2013-07-30 22:17:38 +04:00
Dmitriy Vyukov
5c8ad2e13d
runtime: fix race builders
...
Do not run Syscall benchmarks under race detector,
they split stack in syscall status.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12093045
2013-07-30 22:13:51 +04:00
Dmitriy Vyukov
3b6de5e847
net: fix memory leak on unix
...
If netFD is closed by finalizer, runtime netpoll descriptor is not freed.
R=golang-dev, dave, alex.brainman
CC=golang-dev
https://golang.org/cl/12037043
2013-07-30 19:47:16 +04:00
Russ Cox
cd2eb48722
cmd/gc: don't report mark if other things are broken
...
Fixes #5598 .
R=ken2
CC=golang-dev
https://golang.org/cl/12104043
2013-07-30 10:27:26 -04:00
Russ Cox
27d17255db
cmd/gc: insert \n at end of every input file
...
Not just the first one.
Fixes #5433 .
Fixes #5913 .
R=ken2
CC=golang-dev
https://golang.org/cl/12028049
2013-07-30 10:27:08 -04:00
Mikio Hara
28138f1364
net: fix comment on SetKeepAlivePeriod
...
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/12091043
2013-07-30 16:31:57 +09:00
Mikio Hara
8f32df5455
net: add missing SetKeepAlivePeriod for Plan 9
...
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/12082045
2013-07-30 16:29:51 +09:00
Andrew Gerrand
d920d8d849
doc: don't block page load on JavaScript fetch
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/12050045
2013-07-30 14:22:14 +10:00
Alex A Skinner
789e1c351e
encoding/xml: Do not pass through invalid utf8 bytes
...
EscapeText now escapes 0xFFFD returned from DecodeRune as 0xFFFD, rather than passing through the original byte.
Fixes #5880 .
R=golang-dev, r, bradfitz, adg
CC=golang-dev
https://golang.org/cl/11975043
2013-07-30 14:11:47 +10:00
Andrew Gerrand
51b3611a72
A+C: Alex A Skinner (individual CLA)
...
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/12084043
2013-07-30 14:10:50 +10:00
Rémy Oudompheng
4eaf91a7a7
cmd/gc: make bisonerrors compatible with GNU Bison 3.0
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11990043
2013-07-30 04:31:15 +02:00
Andrew Gerrand
fc32bfa9cc
doc/codewalk: test source code
...
Fixes #2648 .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11331043
2013-07-30 09:42:53 +10:00
Robert Griesemer
3eb9adeeb8
go/parser: don't report name errors if DeclarationErrors is not set
...
R=adonovan
CC=golang-dev
https://golang.org/cl/12072043
2013-07-29 16:00:28 -07:00
Russ Cox
fdb69cb0a3
build: fix build
...
As promised.
TBR=dvyukov
CC=golang-dev
https://golang.org/cl/12063043
2013-07-29 16:52:40 -04:00
Robert Griesemer
340918a8a3
go/parser: selectors may be method expressions
...
R=adonovan
CC=golang-dev
https://golang.org/cl/12062043
2013-07-29 13:52:15 -07:00
Russ Cox
46437f0028
build: break builds
...
I want to see the timing information in build logs,
and we can't see the logs for "ok" builds.
So make the build fail everywhere.
Will roll back immediately.
TBR=dvyukov
CC=golang-dev
https://golang.org/cl/12058046
2013-07-29 16:52:03 -04:00
Russ Cox
c7d5c438a2
runtime: adjust timediv to avoid _vasop; mark _subv okay
...
R=dvyukov
CC=golang-dev
https://golang.org/cl/12028046
2013-07-29 16:42:07 -04:00
Russ Cox
98cc58e2c7
runtime: fix timediv calls on NetBSD, OpenBSD
...
Document endian-ness assumption.
R=dvyukov
CC=golang-dev
https://golang.org/cl/12056044
2013-07-29 16:31:42 -04:00
Dmitriy Vyukov
14e3540430
runtime: fix arm build
...
The current failure is:
fatal error: runtime: stack split during syscall
goroutine 2 [stack split]:
_si2v(0xb6ebaebc, 0x3b9aca00)
/usr/local/go/src/pkg/runtime/vlrt_arm.c:628 fp=0xb6ebae9c
runtime.timediv(0xf8475800, 0xd, 0x3b9aca00, 0xb6ebaef4)
/usr/local/go/src/pkg/runtime/runtime.c:424 +0x1c fp=0xb6ebaed4
Just adding textflag 7 causes the following error:
notetsleep: nosplit stack overflow
128 assumed on entry to notetsleep
96 after notetsleep uses 32
60 after runtime.futexsleep uses 36
4 after runtime.timediv uses 56
-4 after _si2v uses 8
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12001045
2013-07-30 00:08:30 +04:00
Robert Griesemer
5bd61e0603
math/big: better documentation for Rat.Float64
...
R=adonovan, r
CC=golang-dev
https://golang.org/cl/11961043
2013-07-29 13:06:34 -07:00
Dmitriy Vyukov
64db2ec915
runtime: fix arm build
...
The current failure is:
fatal error: runtime: stack split during syscall
goroutine 2 [stack split]:
_addv(0xb6fa0f28, 0xd0a5112e, 0x13156d6e, 0xf8475800, 0xd)
/usr/local/go/src/pkg/runtime/vlrt_arm.c:66 fp=0xb6fa0ef8
notetsleep(0xb6fa0f9c, 0xf8475800, 0xd, 0x0, 0x0, ...)
/usr/local/go/src/pkg/runtime/lock_futex.c:156 +0xd0 fp=0xb6fa0f18
runtime.notetsleepg(0xb6fa0f9c, 0xf8475800, 0xd)
/usr/local/go/src/pkg/runtime/lock_futex.c:197 +0x74 fp=0xb6fa0f3c
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12052043
2013-07-29 23:41:12 +04:00
Dmitriy Vyukov
d91219e458
runtime: fix linux/arm build
...
notetsleep: nosplit stack overflow
128 assumed on entry to notetsleep
80 after notetsleep uses 48
44 after runtime.futexsleep uses 36
-12 after runtime.timediv uses 56
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12049043
2013-07-29 22:59:30 +04:00
Dmitriy Vyukov
ddc01d5b06
runtime: fix openbsd build
...
notetsleep: nosplit stack overflow
120 assumed on entry to notetsleep
96 after notetsleep uses 24
88 on entry to runtime.semasleep
32 after runtime.semasleep uses 56
24 on entry to runtime.nanotime
-8 after runtime.nanotime uses 32
Nanotime seems to be using only 24 bytes of stack space.
Unless I am missing something.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12041044
2013-07-29 22:58:58 +04:00
Dmitriy Vyukov
d83688165a
runtime: fix freebsd build
...
notetsleep: nosplit stack overflow
120 assumed on entry to notetsleep
80 after notetsleep uses 40
72 on entry to runtime.futexsleep
16 after runtime.futexsleep uses 56
8 on entry to runtime.printf
-16 after runtime.printf uses 24
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12047043
2013-07-29 22:58:26 +04:00
Dmitriy Vyukov
e84d9e1fb3
runtime: do not split stacks in syscall status
...
Split stack checks (morestack) corrupt g->sched,
but g->sched must be preserved consistent for GC/traceback.
The change implements runtime.notetsleepg function,
which does entersyscall/exitsyscall and is carefully arranged
to not call any split functions in between.
R=rsc
CC=golang-dev
https://golang.org/cl/11575044
2013-07-29 22:22:34 +04:00
Dmitriy Vyukov
b8734748b6
net: fix memory leaks on windows
...
Close netpoll descriptor along with socket.
Ensure that error paths close the descriptor as well.
R=golang-dev, mikioh.mikioh, alex.brainman
CC=golang-dev
https://golang.org/cl/11987043
2013-07-29 20:01:13 +04:00
Pieter Droogendijk
6350e45892
runtime: allow SetFinalizer with a func(interface{})
...
Fixes #5368 .
R=golang-dev, dvyukov
CC=golang-dev, rsc
https://golang.org/cl/11858043
2013-07-29 19:43:08 +04:00
Mikio Hara
3398322d5e
net: remove redundant comment on isWildcard
...
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11985043
2013-07-29 23:26:11 +09:00
Mikio Hara
442e614cab
net: document sockaddr interface
...
This is in preparation for runtime-integrated network pollster for BSD
variants.
Update #5199
R=golang-dev, fvbommel, dave
CC=golang-dev
https://golang.org/cl/11984043
2013-07-29 23:25:39 +09:00
Andrew Gerrand
f6dd45bf82
doc/articles: state that slices/arrays start at the 0th element
...
Fixes #5881 .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11892043
2013-07-29 18:33:39 +10:00
Alex Brainman
6db195cae2
misc/dashboard/builder: increase cmdTimeout to 10 minutes
...
It takes more then 5 minutes to clone go repo
on windows-386 builder now.
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/12007043
2013-07-29 14:31:21 +10:00
David Symonds
e87af8c43d
misc/dashboard: don't update tip tag for release branch commits.
...
This will mean that sub-repositories won't get built against the
release branch. They are often not compatible because the subrepos
often run ahead of the current release (e.g. go.tools is using
new additions to go/ast, and go.net is using new things in syscall)
so there's little point in checking them against cherrypick commits
when they'll be tested against those commits on tip anyway.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/12001043
2013-07-29 12:08:19 +10:00
Rémy Oudompheng
b7c3d06a1f
all: move examples into package *_test.
...
Fixes #5677 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/11992043
2013-07-29 01:25:51 +02:00
Rémy Oudompheng
d26d5e6403
effective_go.html: make snippets look formatted.
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/11991043
2013-07-29 00:57:19 +02:00
Rémy Oudompheng
05026c4ebd
compress/flate: reduce tiny allocs done by encoder.
...
benchmark old allocs new allocs delta
BenchmarkEncodeDigitsSpeed1e4 942 91 -90.34%
BenchmarkEncodeDigitsSpeed1e5 1919 178 -90.72%
BenchmarkEncodeDigitsSpeed1e6 18539 1517 -91.82%
BenchmarkEncodeDigitsDefault1e4 734 100 -86.38%
BenchmarkEncodeDigitsDefault1e5 1958 193 -90.14%
BenchmarkEncodeDigitsDefault1e6 17338 1426 -91.78%
BenchmarkEncodeDigitsCompress1e4 734 100 -86.38%
BenchmarkEncodeDigitsCompress1e5 1958 193 -90.14%
BenchmarkEncodeDigitsCompress1e6 17338 1426 -91.78%
BenchmarkEncodeTwainSpeed1e4 1865 109 -94.16%
BenchmarkEncodeTwainSpeed1e5 3943 211 -94.65%
BenchmarkEncodeTwainSpeed1e6 31279 1595 -94.90%
BenchmarkEncodeTwainDefault1e4 1811 103 -94.31%
BenchmarkEncodeTwainDefault1e5 3708 199 -94.63%
BenchmarkEncodeTwainDefault1e6 26738 1330 -95.03%
BenchmarkEncodeTwainCompress1e4 1811 103 -94.31%
BenchmarkEncodeTwainCompress1e5 3693 190 -94.86%
BenchmarkEncodeTwainCompress1e6 26902 1333 -95.04%
benchmark old bytes new bytes delta
BenchmarkEncodeDigitsSpeed1e4 1469438 1453920 -1.06%
BenchmarkEncodeDigitsSpeed1e5 1490898 1458961 -2.14%
BenchmarkEncodeDigitsSpeed1e6 1858819 1542407 -17.02%
BenchmarkEncodeDigitsDefault1e4 1465903 1454160 -0.80%
BenchmarkEncodeDigitsDefault1e5 1491841 1459361 -2.18%
BenchmarkEncodeDigitsDefault1e6 1825424 1531545 -16.10%
BenchmarkEncodeDigitsCompress1e4 1465903 1454160 -0.80%
BenchmarkEncodeDigitsCompress1e5 1491681 1459361 -2.17%
BenchmarkEncodeDigitsCompress1e6 1825424 1531545 -16.10%
BenchmarkEncodeTwainSpeed1e4 1485308 1454400 -2.08%
BenchmarkEncodeTwainSpeed1e5 1526065 1459878 -4.34%
BenchmarkEncodeTwainSpeed1e6 2066627 1536296 -25.66%
BenchmarkEncodeTwainDefault1e4 1484380 1454240 -2.03%
BenchmarkEncodeTwainDefault1e5 1521793 1459558 -4.09%
BenchmarkEncodeTwainDefault1e6 1977504 1523388 -22.96%
BenchmarkEncodeTwainCompress1e4 1484380 1454240 -2.03%
BenchmarkEncodeTwainCompress1e5 1521457 1459318 -4.08%
BenchmarkEncodeTwainCompress1e6 1980000 1523609 -23.05%
benchmark old ns/op new ns/op delta
BenchmarkEncodeDigitsSpeed1e4 1472128 1384343 -5.96%
BenchmarkEncodeDigitsSpeed1e5 8283663 8112304 -2.07%
BenchmarkEncodeDigitsSpeed1e6 77459311 76364216 -1.41%
BenchmarkEncodeDigitsDefault1e4 1813090 1746552 -3.67%
BenchmarkEncodeDigitsDefault1e5 26221292 26052516 -0.64%
BenchmarkEncodeDigitsDefault1e6 286512472 286099039 -0.14%
BenchmarkEncodeDigitsCompress1e4 1809373 1747230 -3.43%
BenchmarkEncodeDigitsCompress1e5 26231580 26038456 -0.74%
BenchmarkEncodeDigitsCompress1e6 286140002 286025372 -0.04%
BenchmarkEncodeTwainSpeed1e4 1594094 1438600 -9.75%
BenchmarkEncodeTwainSpeed1e5 7669724 7316288 -4.61%
BenchmarkEncodeTwainSpeed1e6 68731353 65938994 -4.06%
BenchmarkEncodeTwainDefault1e4 2063497 1866488 -9.55%
BenchmarkEncodeTwainDefault1e5 22602689 22221377 -1.69%
BenchmarkEncodeTwainDefault1e6 233376842 232114297 -0.54%
BenchmarkEncodeTwainCompress1e4 2062441 1949676 -5.47%
BenchmarkEncodeTwainCompress1e5 28264344 27930627 -1.18%
BenchmarkEncodeTwainCompress1e6 304369641 303704330 -0.22%
benchmark old MB/s new MB/s speedup
BenchmarkEncodeDigitsSpeed1e4 6.79 7.22 1.06x
BenchmarkEncodeDigitsSpeed1e5 12.07 12.33 1.02x
BenchmarkEncodeDigitsSpeed1e6 12.91 13.10 1.01x
BenchmarkEncodeDigitsDefault1e4 5.52 5.73 1.04x
BenchmarkEncodeDigitsDefault1e5 3.81 3.84 1.01x
BenchmarkEncodeDigitsDefault1e6 3.49 3.50 1.00x
BenchmarkEncodeDigitsCompress1e4 5.53 5.72 1.03x
BenchmarkEncodeDigitsCompress1e5 3.81 3.84 1.01x
BenchmarkEncodeDigitsCompress1e6 3.49 3.50 1.00x
BenchmarkEncodeTwainSpeed1e4 6.27 6.95 1.11x
BenchmarkEncodeTwainSpeed1e5 13.04 13.67 1.05x
BenchmarkEncodeTwainSpeed1e6 14.55 15.17 1.04x
BenchmarkEncodeTwainDefault1e4 4.85 5.36 1.11x
BenchmarkEncodeTwainDefault1e5 4.42 4.50 1.02x
BenchmarkEncodeTwainDefault1e6 4.28 4.31 1.01x
BenchmarkEncodeTwainCompress1e4 4.85 5.13 1.06x
BenchmarkEncodeTwainCompress1e5 3.54 3.58 1.01x
BenchmarkEncodeTwainCompress1e6 3.29 3.29 1.00x
R=imkrasin, golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/10006043
2013-07-28 09:42:40 +02:00
Mikio Hara
a64bea5c99
net: make UnixAddr implement sockaddr interface
...
This is in preparation for runtime-integrated network pollster for BSD
variants.
Update #5199
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11932044
2013-07-28 16:15:07 +09:00
Mikio Hara
e257cd8aae
net: extend sockaddr interface to the all address families
...
This CL extends existing sockaddr interface to accommodate not only
internet protocol family endpoint addressess but unix network family
endpoint addresses.
This is in preparation for runtime-integrated network pollster for BSD
variants.
Update #5199
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/11979043
2013-07-28 12:52:30 +09:00
Mikio Hara
bf61a97f24
net: simplify socket option helpers
...
Also consolidates syscall.IPPROTO_TCP level option helper files.
R=golang-dev, dave, alex.brainman
CC=golang-dev
https://golang.org/cl/8637049
2013-07-28 11:18:06 +09:00
Dmitriy Vyukov
7da7d71cf4
misc/dashboard: fix typo in comment
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11936045
2013-07-27 13:54:34 +04:00
Dmitriy Vyukov
d5c7ef6216
cmd/dist: fix crash on windows
...
currently 'dist install' always crashes on windows
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/11919043
2013-07-27 13:53:18 +04:00
Dmitriy Vyukov
91d35ad1b8
runtime: fix potential deadlock in netpoll on windows
...
If netpoll has been told to block, it must not return with nil,
otherwise scheduler assumes that netpoll is disabled.
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/11920044
2013-07-27 13:46:40 +04:00
Dmitriy Vyukov
29f17fb01c
net: temporary skip hanging test on windows
...
Update #5971 .
R=alex.brainman
CC=golang-dev
https://golang.org/cl/11938046
2013-07-27 13:36:27 +04:00
ChaiShushan
c44e483542
misc/notepadplus: use new User Defined Language system (UDL2)
...
Add missing single quotation and backslash marks.
Change dot and underscore character keyword type.
"_" is a predeclared identifier, not a operator.
"." is a selector, x.f should be one identifier highlight.
So the fix is to change it.
Fixes #5775 .
Fixes #5788 .
Fixes #5798 .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/10480044
2013-07-27 08:12:42 +10:00