Vincent Vanackere
f18a4e9609
syscall : add ProcAttr field to pass an unescaped command line on windows
...
On windows, the command line is passed as a single null-terminated string. While the automatic parameter escaping done by syscall.StartProcess works fine with most Windows programs, some applications do their own custom parsing of the command line, in which case the automatic escaping becomes harmful.
This CL adds a new extra CmdLine field to syscall.ProcAttr that will be used as the raw/unescaped command line if not empty.
Fixes #1849 .
R=golang-dev, alex.brainman, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4548050
2011-05-31 10:21:38 -04:00
Alexey Borzenkov
c4206cb231
runtime: save cdecl registers in Windows SEH handler
...
Fixes #1779
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4566041
2011-05-31 10:11:47 -04:00
Gustavo Niemeyer
463f478dbb
filepath: Abs must always return a clean path
...
When I was first coding Abs, I wondered if people wouldn't
expect the path to be consistently clean, even if the path
passed in was already absolute.
CL 4524078 has a potential problem based on exactly that
assumption, so it feels like this behavior is indeed the
most useful and least surprising.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4548074
2011-05-30 22:28:59 -03:00
Rob Pike
0de328edd6
unicode: make the tables smaller.
...
By splitting the ranges into 16-bit values and 32-bit values,
we can reduce about 3000 entries by 48 bits per entry, or about
16KB, at the cost of a little more complexity in the code.
R=iant, bradfitz, rsc, r
CC=golang-dev
https://golang.org/cl/4547066
2011-05-31 09:58:07 +10:00
Russ Cox
2c6a2a9773
goinstall: skip standard packages
...
R=adg, n13m3y3r
CC=golang-dev
https://golang.org/cl/4526084
2011-05-30 18:23:16 -04:00
Gustavo Niemeyer
87dbec54bb
template: fix and clean interaction between quotes and formatters
...
Fixes issue #1897 .
R=r, gustavo, r
CC=golang-dev
https://golang.org/cl/4561049
2011-05-30 11:53:09 -03:00
Andrew Gerrand
55f8fd2684
gobuilder: remove some windows-specificity
...
R=alex.brainman
CC=golang-dev
https://golang.org/cl/4528109
2011-05-30 20:19:56 +10:00
Robert Hencke
3fbd478a8a
pkg: spelling tweaks, I-Z
...
also, a few miscellaneous fixes to files outside pkg
R=golang-dev, dsymonds, mikioh.mikioh, r
CC=golang-dev
https://golang.org/cl/4517116
2011-05-30 18:02:59 +10:00
Alex Brainman
9107b530d8
goinstall: use bash to execute gomake
...
R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/4551074
2011-05-30 16:15:08 +10:00
Yasuhiro Matsumoto
1042572528
src: Make.pkg don't create $(TARGDIR) with goinstall.
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4548071
2011-05-30 12:35:55 +10:00
Yasuhiro Matsumoto
c6fd1e0115
misc/vim: limit Fmt command to Go buffers.
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4548072
2011-05-30 12:20:00 +10:00
Andrew Gerrand
5784dcfd19
dashboard: send notification emails when the build breaks
...
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4530061
2011-05-30 11:27:31 +10:00
Alex Brainman
55dd63bb4e
gobuilder: fixes for windows
...
R=r, devon.odell, iant, rsc, adg
CC=bradfitz, golang-dev, jdpoirier
https://golang.org/cl/4536053
2011-05-30 11:20:46 +10:00
Nigel Tao
a479bc8d02
image/png: fix encoding of images that don't start at (0, 0).
...
R=r
CC=golang-dev
https://golang.org/cl/4560049
2011-05-30 10:55:37 +10:00
David Symonds
5d5d84f3df
gob: fix documentation on Decoder.Decode.
...
R=r, adg
CC=golang-dev
https://golang.org/cl/4515159
2011-05-30 10:48:08 +10:00
Brad Fitzpatrick
da32ed7bf1
http: let Transport use a custom net.Dial function
...
Permits the use of SOCKS proxy dialer with
the transport.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4536091
2011-05-29 09:32:36 -07:00
Rob Pike
62943df829
template: cosmetic cleanups.
...
Remove the idea of space being white. Sometimes space is green.
Simplify a comment and remove the Latin.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4532096
2011-05-29 16:13:41 +10:00
Gustavo Niemeyer
e11d94fcd7
template: fix quote-handling with formatters
...
Fixes issue #1896 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4539093
2011-05-29 00:23:32 -03:00
Yasuhiro Matsumoto
0f4510b370
os: fix os.MkdirAll with backslash path separator.
...
MkdirAll() need to use isSeparator().
Move primary defines of filepath.Separator/filepath.ListSeparator
to os.PathSeparator/os.PathListSeparator.
Move filepath.isSeparator() to os.IsPathSeparator().
filepath package refer them from os package.
Fixes #1831 .
R=rsc, alex.brainman
CC=golang-dev
https://golang.org/cl/4535100
2011-05-29 13:03:49 +10:00
Alex Brainman
505f0bb3ce
os: fix windows version of Readdir(0)
...
Fixes #1893 .
R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/4528106
2011-05-29 11:59:35 +10:00
Alex Brainman
b7582852f6
gotest, pkg/exec: use bash instead of sh to execute shell scripts on windows
...
As suggested by dho, iant2.
R=golang-dev, rsc
CC=devon.odell, golang-dev, iant
https://golang.org/cl/4515147
2011-05-28 21:26:03 +10:00
Evan Shaw
f369fc09f4
go/scanner: don't allow "0x" and "0X" as integers
...
R=gri
CC=golang-dev
https://golang.org/cl/4560047
2011-05-27 16:47:26 -07:00
Brad Fitzpatrick
399a311e64
http: client+server benchmark
...
baseline runs: (6g, gopher.mtv)
http_test.BenchmarkClientServer 5000 412588 ns/op
http_test.BenchmarkClientServer 5000 403346 ns/op
http_test.BenchmarkClientServer 5000 413936 ns/op
http_test.BenchmarkClientServer 5000 410287 ns/op
http_test.BenchmarkClientServer 5000 388037 ns/op
http_test.BenchmarkClientServer 5000 405545 ns/op
http_test.BenchmarkClientServer 5000 405179 ns/op
http_test.BenchmarkClientServer 5000 413827 ns/op
http_test.BenchmarkClientServer 5000 392723 ns/op
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4515155
2011-05-27 16:43:02 -07:00
Brad Fitzpatrick
f7a266a5aa
encoding/binary: add a non-reflect fast path for Write
...
before/after:
binary.BenchmarkWrite 100000 18312 ns/op
binary.BenchmarkWrite 500000 4468 ns/op
R=rsc, gri
CC=golang-dev
https://golang.org/cl/4515154
2011-05-27 16:29:33 -07:00
Evan Shaw
3b980579b4
big: make Int and Rat implement fmt.Scanner
...
R=gri
CC=golang-dev
https://golang.org/cl/4552056
2011-05-27 15:51:00 -07:00
Rob Pike
5a35757f3f
time: midnight is 12AM.
...
This is the other half of the problem fixed at noon by the previous change.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4515150
2011-05-28 07:06:53 +10:00
Brad Fitzpatrick
685a8157e6
os: yet more Readdir tests and fix earlier regression
...
R=golang-dev, fshahriar
CC=golang-dev
https://golang.org/cl/4548068
2011-05-27 12:58:59 -07:00
Brad Fitzpatrick
0e865ab8e7
os: improve Readdir test coverage, fix Readdir(0) on EOF
...
Adds tests for Readdir and Readdirnames with different n
values. No good way to inject faults during full reads,
though.
Also fixes bug report from fshahriar:
Readdir(0) wasn't behaving like Readdir(-1).
R=rsc, fshahriar
CC=golang-dev
https://golang.org/cl/4529092
2011-05-27 12:14:48 -07:00
Brad Fitzpatrick
0b204e4625
http: propagate Set-Cookie in reverse proxy
...
Also adds Host header tests.
Fixes #1886
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4556063
2011-05-27 11:06:53 -07:00
Brad Fitzpatrick
b88be14982
http/spdy: temporarily disable some failing tests
...
Issue 1886 has details
R=golang-dev, willchan
CC=golang-dev
https://golang.org/cl/4527083
2011-05-27 10:08:31 -07:00
Rob Pike
406d73876d
time: fix Format bug: noon is 12PM, not 0PM.
...
Fixes #1882 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4556062
2011-05-27 23:24:39 +10:00
Gustavo Niemeyer
a825e8a69f
cgo: restrict #cgo directives to prevent shell expansion
...
Fixes issue #1879 .
Directives were not directly expanded, but since their
content ended up in makefiles, further expansion would
take place there. This prevents such artifacts by
restricting the set of characters that may be used in
a directive value.
To build the list of safe characters I went through the
contents of /usr/lib/pkgconfig and extracted LDFLAGS
and CFLAGS information, so hopefully this is a
reasonable default to get started.
R=rsc
CC=golang-dev
https://golang.org/cl/4532092
2011-05-27 08:46:51 -03:00
Rob Pike
a1d2cbf645
crypto/tls/generate_cert.go: fix misspelling of O_CREATE.
...
Fixes #1888 .
R=ken
CC=golang-dev
https://golang.org/cl/4515148
2011-05-27 21:06:50 +10:00
Alex Brainman
cb96d98b06
os: another attempt to handle OpenFile flag parameter properly on Windows
...
Fixes #1791 .
R=rsc, r, r, iant
CC=golang-dev
https://golang.org/cl/4551046
2011-05-27 17:02:24 +10:00
Andrew Gerrand
2386808ee9
doc: put Release History link on 'Documentation' page
...
Also put Weekly Snapshot History link on 'Contributing' page
Fixes #1885 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4559049
2011-05-27 16:07:30 +10:00
Dmitry Chestnykh
e4492ce3c3
runtime: fix mmap error return on linux.
...
Fixes #1511 again.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/4527070
2011-05-26 21:43:27 -07:00
Gustavo Niemeyer
bddb75127f
cgo: support pkg-config for flags and libs
...
Fixes issue #1853 .
R=golang-dev, mattn.jp, adg
CC=golang-dev
https://golang.org/cl/4550084
2011-05-26 22:19:23 -03:00
Mikio Hara
12376c93ef
syscall: add routing messages support for BSD variants
...
R=rsc
CC=golang-dev
https://golang.org/cl/4539084
2011-05-26 20:02:03 -04:00
Alex Brainman
86327cdcf5
os: TestMkdirAll should not fail to delete _test/_TestMkdirAll_ on Windows
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4515142
2011-05-27 09:52:15 +10:00
Mikio Hara
4d118835ab
syscall: add routing messages support for Linux
...
R=rsc
CC=golang-dev
https://golang.org/cl/4515135
2011-05-26 17:04:58 -04:00
Ivan Krasin
1b5d04c5ae
compress/flate: fix Huffman tree bug
...
Incorporate refactoring and a regression test from https://golang.org/cl/4538090/
R=rsc, go.peter.90, imkrasin
CC=golang-dev, mirtchovski
https://golang.org/cl/4524070
2011-05-26 17:02:11 -04:00
Robert Griesemer
e8c87a7ddd
fix build: temporarily disable the use of strings.Reader UnreadRune in fmt
...
R=r
CC=golang-dev
https://golang.org/cl/4532090
2011-05-26 11:54:10 -07:00
Ian Lance Taylor
9ef8ebafe4
gc: patch y.tab.c to fix build when using Bison 2.5
...
Fixes #1843 .
R=rsc
CC=golang-dev
https://golang.org/cl/4535101
2011-05-26 11:28:23 -07:00
Robert Griesemer
5b1fb9d5c6
io: add ByteScanner, RuneScanner interfaces
...
R=r, rsc
CC=golang-dev
https://golang.org/cl/4530069
2011-05-26 11:03:52 -07:00
Robert Griesemer
9cd3372f9b
strings: implement UnreadByte, UnreadRune
...
Added corresponding tests.
R=rsc
CC=golang-dev
https://golang.org/cl/4560045
2011-05-26 11:02:07 -07:00
William Chan
abb970ef57
http/spdy: redo interfaces, flesh out implementation & frame types
...
Added a new Framer to handle reading/writing Frames. This is necessary since we have to maintain a compression context across streams.
TODO:
* Separate the types and read/write routines into different files.
* Improve error handling.
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4503042
2011-05-26 09:54:54 -07:00
Brad Fitzpatrick
4bb337e525
CONTRIBUTORS: add William Chan (Google CLA)
...
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4552066
2011-05-26 09:53:28 -07:00
Brad Fitzpatrick
3648a03b3a
encoding/binary: add a non-reflect fast path for Read
...
before/after:
binary.BenchmarkRead 200000 10860 ns/op
binary.BenchmarkRead 500000 2846 ns/op
R=rsc
CC=golang-dev
https://golang.org/cl/4547062
2011-05-26 09:01:05 -07:00
Yasuhiro Matsumoto
c0decc35ae
exp/eval: fix compile error.
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4550086
2011-05-26 22:05:25 +10:00
Brad Fitzpatrick
4923ba9155
mime/multipart: misc code/doc fixes
...
R=rsc
CC=golang-dev
https://golang.org/cl/4532089
2011-05-25 19:21:05 -07:00