Kai Backman
95b40f6ca1
Fix a deadlock bug in the rpc client. The panic will trigger
...
regularly when client connections are flaky (probably another
issue).
(credits to jussi@tinkercad.com for finding the issue)
R=rsc, r
CC=golang-dev, jussi
https://golang.org/cl/2831042
2010-11-02 14:04:56 -07:00
Rob Pike
59315fbfb5
netchan: fix locking bug.
...
There's no need to hold the client mutex when calling encode, since encode itself
uses a mutex to make the writes atomic. However, we need to keep
the messages ordered, so add a mutex for that purpose alone.
Fixes #1244 .
R=rsc
CC=golang-dev
https://golang.org/cl/2833041
2010-11-02 10:58:27 -07:00
Robert Griesemer
396228a652
go/scanner: removed scanner/internal-only uses of token.Position
...
First step towards a more light-weight implementation of token.Position:
- only use token.Position for reporting token and error position
- use offsets only for scanner control
- no interface changes yet
R=rsc
CC=golang-dev
https://golang.org/cl/2825041
2010-11-02 10:38:07 -07:00
Rob Pike
0808b199e0
Effective Go: append and a few words about ...
...
R=rsc, gri, iant
CC=golang-dev
https://golang.org/cl/2821041
2010-11-01 21:46:04 -07:00
Rob Pike
c33289238e
test/ken/convert.go: add conversion torture test
...
(written by ken)
R=ken2
CC=golang-dev
https://golang.org/cl/2823042
2010-11-01 17:49:06 -07:00
Alex Brainman
8f8f625cb1
8l: pe generation fixes
...
Restore ability to have different file and
section alignment in generated pe file.
Stop generating .bss pe section, it is
part of .data now.
Some code refactoring.
R=rsc, vcc
CC=golang-dev
https://golang.org/cl/2731041
2010-11-02 10:56:56 +11:00
Robert Griesemer
ce98044523
fix build
...
R=rsc
CC=golang-dev
https://golang.org/cl/2820041
2010-11-01 15:25:39 -07:00
Brad Fitzpatrick
b0afb931a8
Use strings.Contains in src/cmd/...
...
R=r
CC=golang-dev, r2, rsc
https://golang.org/cl/2819041
2010-11-01 15:21:35 -07:00
Robert Griesemer
7996924c89
go/printer: do not remove parens around composite literals starting with a type name in control clauses
...
(even when they are nested inside an expression).
Fixes #1243 .
R=rsc
CC=golang-dev
https://golang.org/cl/2817041
2010-11-01 15:08:03 -07:00
Robert Griesemer
9384fdc96a
go/ast: add Inspect function for easy AST inspection w/o a visitor
...
R=rsc
CC=golang-dev
https://golang.org/cl/2770044
2010-11-01 15:06:34 -07:00
Wei Guangjing
035696c59a
debug/pe, cgo: add windows support
...
R=rsc, mattn
CC=golang-dev
https://golang.org/cl/1976045
2010-11-01 17:52:26 -04:00
Brad Fitzpatrick
e198a5086a
strings: Contains
...
Tiny helper to avoid strings.Index(s, sub) != -1
R=rsc, r2, r
CC=golang-dev
https://golang.org/cl/2265044
2010-11-01 14:32:48 -07:00
Rob Pike
e8436689ad
gotest: if the benchmark list is empty, print it in a way that
...
gofmt will leave alone.
R=rsc, bradfitz, bradfitzpatrick
CC=golang-dev
https://golang.org/cl/2816041
2010-11-01 14:23:07 -07:00
Albert Strasheim
6442f38a91
syscall: SIO constants for Linux
...
R=rsc
CC=golang-dev
https://golang.org/cl/2303043
2010-11-01 16:42:33 -04:00
Fazlul Shahriar
0e816f5972
codereview: fix 'hg sync' and 'hg download' in Python 2.7
...
Fixes #1218 .
R=rsc
CC=golang-dev
https://golang.org/cl/2664041
2010-11-01 16:37:17 -04:00
Roger Peppe
270bad3939
testing: add Benchmark to allow benchmarks to be run without gotest.
...
R=rsc
CC=golang-dev
https://golang.org/cl/2506042
2010-11-01 16:15:17 -04:00
Michael Hoisie
7b4eed7d66
http server: don't send trailing '0' for chunked encoding when responding with 304 NotModified
...
R=rsc, adg
CC=golang-dev
https://golang.org/cl/2723041
2010-11-01 16:15:03 -04:00
Russ Cox
276003adb1
build: fiddle with make variables
...
Fixes #1234 .
R=r, r2
CC=golang-dev
https://golang.org/cl/2735043
2010-11-01 16:14:58 -04:00
Anthony Martin
51b15d68aa
libutf: update to Unicode 5.2.0 to match pkg/unicode
...
R=rsc, r, PeterGo, r2
CC=golang-dev
https://golang.org/cl/2753045
2010-11-01 16:14:48 -04:00
Evan Shaw
884dceca1f
6a/6l: fix MOVOU encoding
...
The andproto field was set incorrectly, causing 6a to encode illegal
instructions.
R=rsc
CC=golang-dev
https://golang.org/cl/2781042
2010-11-01 16:14:43 -04:00
Robert Griesemer
68ac0c1d94
go/scanner: don't accept '\x0g' character escape (bug fix)
...
Added more test cases.
R=rsc
CC=golang-dev
https://golang.org/cl/2804041
2010-11-01 12:50:21 -07:00
Rob Pike
6dc4c58f87
gob: documentation. this time for sure.
...
if the interface value is nil, it sends no value,
R=rsc, adg
CC=golang-dev
https://golang.org/cl/2801042
2010-10-31 17:48:19 -07:00
Rob Pike
fbfb1d9e72
mkrunetype: install a Makefile and tweak it slightly so it can be built.
...
R=rsc
CC=golang-dev
https://golang.org/cl/2813041
2010-10-31 17:46:26 -07:00
Rob Pike
41ac2f8a42
gob: update documentation about wire format for interfaces.
...
R=rsc
CC=golang-dev
https://golang.org/cl/2814041
2010-10-31 15:08:45 -07:00
Rob Pike
7f7cb166c8
gob: several fixes.
...
1) Be sure to use the eval-time encoder/decoder rather than
the compile-time decoder. In a few cases the receiver for
the compiling encoder was being pickled incorrectly into a
closure.
(This is the fix for issue 1238).
2) Get the innermost name right when given a pointer to an
unnamed type.
3) Use a count to delineate interface values, making it
possible to ignore values without having a concrete type
to encode into. This is a protocol change but only for the
new feature, so it shouldn't affect anyone. The old test
worked because, amazingly, it depended on bug #1 .
Fixes #1238 .
R=rsc, albert.strasheim
CC=golang-dev
https://golang.org/cl/2806041
2010-10-31 13:41:30 -07:00
Evan Shaw
f62772b1e5
kate: update for append
...
R=golang-dev, PeterGo, gri
CC=golang-dev
https://golang.org/cl/2710044
2010-10-30 21:25:19 -07:00
Evan Shaw
5bf420f0c8
pidigits: Remove TODO, minor improvements
...
I tried adding a Scale method to big.Int and it didn't make any noticeable
difference, so I'm removing my TODO.
Also got rid of a few obvious allocations that I missed earlier for a modest
improvement (~5%).
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/2711043
2010-10-30 20:16:44 -07:00
Alex Brainman
a8c4da996e
syscall: fix windows build
...
R=golang-dev
CC=golang-dev
https://golang.org/cl/2713043
2010-10-30 23:55:22 +11:00
Alex Brainman
7812b79627
syscall: fix Stat(path) where path is directory with trailing '/' on windows
...
Fixes #1220 .
R=rsc, r
CC=golang-dev
https://golang.org/cl/2728043
2010-10-30 23:06:49 +11:00
Anthony Starks
edaeb88bd5
misc/bbedit: support append, other builtins
...
R=golang-dev, PeterGo, adg
CC=golang-dev
https://golang.org/cl/2791042
2010-10-30 22:15:59 +11:00
David Symonds
0451cd1950
misc/vim: update list of builtins.
...
R=adg
CC=golang-dev
https://golang.org/cl/2807041
2010-10-30 22:07:01 +11:00
Rob Pike
c490bb6f81
gob: clarify the comments about installing the debug/dumper.
...
R=rsc
CC=golang-dev
https://golang.org/cl/2789043
2010-10-29 15:52:25 -07:00
Rob Pike
96b9efe8a9
gob: make the debugging (dumping) code work again. Mostly rewrite it, in fact.
...
It's still not compiled in by default.
R=rsc, r2
CC=golang-dev
https://golang.org/cl/2754043
2010-10-29 15:07:56 -07:00
Robert Griesemer
907e998cba
go/scanner: added another test case, clarified some code
...
R=rsc
CC=golang-dev
https://golang.org/cl/2741042
2010-10-29 15:07:04 -07:00
Robert Griesemer
11684680fa
go spec: append is now implemented
...
R=r, r2
CC=golang-dev
https://golang.org/cl/2717043
2010-10-29 11:44:48 -07:00
Robert Griesemer
7eb5c9a520
ebnf: use append
...
R=r, rsc
CC=golang-dev
https://golang.org/cl/2799041
2010-10-28 21:23:24 -07:00
Robert Griesemer
75855a8f5e
tabwriter: use append
...
R=rsc
CC=golang-dev
https://golang.org/cl/2798041
2010-10-28 21:23:04 -07:00
Robert Griesemer
5762cd3755
go/doc: use append
...
R=rsc
CC=golang-dev
https://golang.org/cl/2792041
2010-10-28 17:26:01 -07:00
Rob Pike
4e9cc085d2
testing: eliminate testing/regexp
...
Rather than updating the stripped-down regexp implementation embedded
in testing, delete it by passing the one function we need from the package
main file created by gotest.
R=rsc
CC=golang-dev
https://golang.org/cl/2761043
2010-10-28 16:54:24 -07:00
Rob Pike
1f4d54ea01
regexp: eliminate vector in favor of append.
...
R=rsc
CC=golang-dev
https://golang.org/cl/2795041
2010-10-28 15:54:01 -07:00
Robert Griesemer
fafb116c75
go/printer: use append
...
R=rsc
CC=golang-dev
https://golang.org/cl/2793041
2010-10-28 15:09:47 -07:00
Robert Griesemer
098e94173a
go/typechecker: use append
...
R=rsc
CC=golang-dev
https://golang.org/cl/2736044
2010-10-28 15:09:21 -07:00
Andrew Gerrand
6062515a93
container/list: document iteration
...
R=rsc
CC=golang-dev
https://golang.org/cl/2768042
2010-10-29 08:48:16 +11:00
Robert Griesemer
302b0ff942
go/parser: use append
...
R=rsc
CC=golang-dev
https://golang.org/cl/2720042
2010-10-28 13:36:28 -07:00
Robert Griesemer
12be168b4b
godoc: bug fix (bug introduced with revision 3ee58453e961)
...
(thanks to Chris Dollin for identifying the cause)
Fixes #1237 .
R=rsc
CC=golang-dev
https://golang.org/cl/2753043
2010-10-28 08:44:25 -07:00
Robert Griesemer
e79ebb008f
test for append() built-in
...
R=r, rsc
CC=golang-dev
https://golang.org/cl/2777041
2010-10-28 08:14:31 -07:00
Russ Cox
69c4e9380b
use append
...
R=gri, r, r2
CC=golang-dev
https://golang.org/cl/2743042
2010-10-27 19:47:23 -07:00
Russ Cox
d8b5d039cd
gc: implement append
...
R=ken2
CC=golang-dev
https://golang.org/cl/2757042
2010-10-27 17:56:32 -07:00
Russ Cox
b803a255fc
retag release to avoid hg bug
...
R=adg, golang-dev, r2
CC=golang-dev
https://golang.org/cl/2782041
2010-10-27 17:31:37 -07:00
Andrew Gerrand
fded5fed0b
tag release.2010-10-27
...
R=rsc
CC=golang-dev
https://golang.org/cl/2778042
2010-10-28 11:21:44 +11:00