6 Commits

Author	SHA1	Message	Date
Brad Fitzpatrick	ae534bcb6c	astutil: fix a comment corruption case ... This fixes a case where adding an import when there are is no existing import declaration can corrupt the position of comments attached to types. This was the last known goimports/astutil corruption case. See golang.org/issue/6884 for more details. Unfortunately this requires changing the API to add a *token.FileSet, which we should've had before. I will update goimports (the only user of this API?) immediately after submitting this. This CL also contains a hack (used only in this case of no imports): rather than fix the comment positions by hand (something that only Robert might know how to do), it instead just prints the AST, manipulates the source, and re-parses the AST. We can fix up later. Fixes golang/go#6884 R=golang-dev, gri CC=golang-dev https://golang.org/cl/38270043	2013-12-16 14:43:29 -08:00
Robert Griesemer	849643aaaf	go.tools: cleanups (added copyrights to astutil, clearer logic in go/types) ... R=adonovan CC=golang-dev https://golang.org/cl/29110043	2013-11-19 09:07:02 -08:00
David Crawshaw	545b16b6db	go.tools/astutil: add AddNamedImport ... R=bradfitz CC=golang-dev https://golang.org/cl/23850044	2013-11-12 18:02:47 -05:00
David Crawshaw	0d4ee40f21	go.tools/astutil: add Imports, which returns imports grouped by spacing. ... R=bradfitz CC=golang-dev https://golang.org/cl/23660045	2013-11-08 14:51:15 -05:00
David Crawshaw	6df4bd0406	go.tools/astutil: make sure import blocks are marked as such (Lparen=1) ... R=bradfitz CC=golang-dev https://golang.org/cl/22320044	2013-11-06 15:31:54 -05:00
David Crawshaw	0b5928ea2a	go.tools/astutil: a package for common AST utilities. ... Lifts the import management utilities from gofix into a package, so they can be used by goimports. R=bradfitz CC=golang-dev https://golang.org/cl/22430043	2013-11-06 13:30:30 -05:00