3 Commits

Author	SHA1	Message	Date
Heschi Kreinick	5916a50871	internal/lsp: check for file URIs on LSP requests ... In general, we expect all URIs to be file:// scheme. Silently ignore requests that come in for other schemes. (In the command-line client we panic since we should never see anything else.) The calling convention for beginFileRequest is odd; see the function comment. Fixes golang/go#33699. Change-Id: Ie721e9a85478f3a12975f6528cfbd28cc7910be8 Reviewed-on: https://go-review.googlesource.com/c/tools/+/219483 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2020-02-14 22:51:26 +00:00
Heschi Kreinick	f7b8cc7bd0	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths ... Create a real type for protocol.DocumentURIs. Remove span.NewURI in favor of path/URI-specific constructors. Remove span.Parse's ability to parse URI-based spans, which appears to be totally unused. As a consequence, we no longer mangle non-file URIs to start with file://, and crash all over the place when one is opened. Updates golang/go#33699. Change-Id: Ic7347c9768e38002b4ad9c84471329d0af7d2e05 Reviewed-on: https://go-review.googlesource.com/c/tools/+/219482 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2020-02-14 22:51:03 +00:00
Jędrzej Szczepaniak	59b2cd78f8	tools/gopls: add cmd support for implementation ... This change adds command line support for implementation. Example: $ gopls implementation ~/tmp/foo/main.go:8:6 $ gopls implementation ~/tmp/foo/main.go:#53 Updates golang/go#32875 Change-Id: I3aa89a788ded886368b07c1824325069f3cba88a Reviewed-on: https://go-review.googlesource.com/c/tools/+/208357 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>	2019-11-25 20:27:09 +00:00